mbox series

[v4,0/5] Lazy flush for the auth session

Message ID 20240918203559.192605-1-jarkko@kernel.org (mailing list archive)
Headers show
Series Lazy flush for the auth session | expand

Message

Jarkko Sakkinen Sept. 18, 2024, 8:35 p.m. UTC 
For the sake of:
https://bugzilla.kernel.org/show_bug.cgi?id=219229

The baseline for the series is v6.11 tag.

v3: 
https://lore.kernel.org/linux-integrity/20240917154444.702370-1-jarkko@kernel.org/
v2:
https://lore.kernel.org/linux-integrity/20240916110714.1396407-1-jarkko@kernel.org/
v1:
https://lore.kernel.org/linux-integrity/20240915180448.2030115-1-jarkko@kernel.org/

Jarkko Sakkinen (5):
  tpm: Return on tpm2_create_null_primary() failure
  tpm: Return on tpm2_create_primary() failure in tpm2_load_null()
  tpm: flush the null key only when /dev/tpm0 is accessed
  tpm: Allocate chip->auth in tpm2_start_auth_session()
  tpm: flush the auth session only when /dev/tpm0 is open

 drivers/char/tpm/tpm-chip.c       |  14 ++++
 drivers/char/tpm/tpm-dev-common.c |   8 +++
 drivers/char/tpm/tpm-interface.c  |  10 ++-
 drivers/char/tpm/tpm2-cmd.c       |   3 +
 drivers/char/tpm/tpm2-sessions.c  | 109 +++++++++++++++++++-----------
 include/linux/tpm.h               |   2 +
 6 files changed, 104 insertions(+), 42 deletions(-)

Comments

Pengyu Ma Sept. 19, 2024, 1:12 a.m. UTC | #1 
On Thu, Sep 19, 2024 at 4:36 AM Jarkko Sakkinen <jarkko@kernel.org> wrote:
>
> For the sake of:
> https://bugzilla.kernel.org/show_bug.cgi?id=219229
>
> The baseline for the series is v6.11 tag.

Clean applied on v6.11 upstream kernel.
Boot time is 8.7 seconds which is almost good as 7 seconds without TPM2_HMAC.

Thanks,
Pengyu

>
> v3:
> https://lore.kernel.org/linux-integrity/20240917154444.702370-1-jarkko@kernel.org/
> v2:
> https://lore.kernel.org/linux-integrity/20240916110714.1396407-1-jarkko@kernel.org/
> v1:
> https://lore.kernel.org/linux-integrity/20240915180448.2030115-1-jarkko@kernel.org/
>
> Jarkko Sakkinen (5):
>   tpm: Return on tpm2_create_null_primary() failure
>   tpm: Return on tpm2_create_primary() failure in tpm2_load_null()
>   tpm: flush the null key only when /dev/tpm0 is accessed
>   tpm: Allocate chip->auth in tpm2_start_auth_session()
>   tpm: flush the auth session only when /dev/tpm0 is open
>
>  drivers/char/tpm/tpm-chip.c       |  14 ++++
>  drivers/char/tpm/tpm-dev-common.c |   8 +++
>  drivers/char/tpm/tpm-interface.c  |  10 ++-
>  drivers/char/tpm/tpm2-cmd.c       |   3 +
>  drivers/char/tpm/tpm2-sessions.c  | 109 +++++++++++++++++++-----------
>  include/linux/tpm.h               |   2 +
>  6 files changed, 104 insertions(+), 42 deletions(-)
>
> --
> 2.46.0
>
Jarkko Sakkinen Sept. 19, 2024, 1:45 p.m. UTC | #2 
On Thu Sep 19, 2024 at 4:12 AM EEST, Pengyu Ma wrote:
> On Thu, Sep 19, 2024 at 4:36 AM Jarkko Sakkinen <jarkko@kernel.org> wrote:
> >
> > For the sake of:
> > https://bugzilla.kernel.org/show_bug.cgi?id=219229
> >
> > The baseline for the series is v6.11 tag.
>
> Clean applied on v6.11 upstream kernel.
> Boot time is 8.7 seconds which is almost good as 7 seconds without TPM2_HMAC.

Awesome thank you! I think there could be some places where we could
further make "100 ms here and 50 ms there" time savings. I'll look
at those when I have some bandwidth but overally I think we are
now in pretty acceptable measures :-)

Thanks again for all the effort with testing this!

BR, Jarkko