| Message ID | cover.1720728319.git.jstancek@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | sign-file,extract-cert: switch to PROVIDER API for OpenSSL >= 3.0 | expand |
On Fri, Jul 12, 2024 at 09:11:13AM +0200, Jan Stancek wrote: > The ENGINE interface has its limitations and it has been superseded > by the PROVIDER API, it is deprecated in OpenSSL version 3.0. > Some distros have started removing it from header files. > > Update sign-file and extract-cert to use PROVIDER API for OpenSSL Major >= 3. > > Tested on F39 with openssl-3.1.1, pkcs11-provider-0.5-2, openssl-pkcs11-0.4.12-4 > and softhsm-2.6.1-5 by using same key/cert as PEM and PKCS11 and comparing that > the result is identical. > > Jan Stancek (3): > sign-file,extract-cert: move common SSL helper functions to a header > sign-file,extract-cert: avoid using deprecated ERR_get_error_line() > sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3 > > MAINTAINERS | 1 + > certs/Makefile | 2 +- > certs/extract-cert.c | 138 +++++++++++++++++++++++-------------------- > scripts/sign-file.c | 134 +++++++++++++++++++++-------------------- > scripts/ssl-common.h | 32 ++++++++++ > 5 files changed, 178 insertions(+), 129 deletions(-) > create mode 100644 scripts/ssl-common.h Adding Cc to Jarkko Sakkinen <jarkko@kernel.org>.
On Fri Aug 2, 2024 at 4:10 PM EEST, Herbert Xu wrote: > On Fri, Jul 12, 2024 at 09:11:13AM +0200, Jan Stancek wrote: > > The ENGINE interface has its limitations and it has been superseded > > by the PROVIDER API, it is deprecated in OpenSSL version 3.0. > > Some distros have started removing it from header files. > > > > Update sign-file and extract-cert to use PROVIDER API for OpenSSL Major >= 3. > > > > Tested on F39 with openssl-3.1.1, pkcs11-provider-0.5-2, openssl-pkcs11-0.4.12-4 > > and softhsm-2.6.1-5 by using same key/cert as PEM and PKCS11 and comparing that > > the result is identical. > > > > Jan Stancek (3): > > sign-file,extract-cert: move common SSL helper functions to a header > > sign-file,extract-cert: avoid using deprecated ERR_get_error_line() > > sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3 > > > > MAINTAINERS | 1 + > > certs/Makefile | 2 +- > > certs/extract-cert.c | 138 +++++++++++++++++++++++-------------------- > > scripts/sign-file.c | 134 +++++++++++++++++++++-------------------- > > scripts/ssl-common.h | 32 ++++++++++ > > 5 files changed, 178 insertions(+), 129 deletions(-) > > create mode 100644 scripts/ssl-common.h > > Adding Cc to Jarkko Sakkinen <jarkko@kernel.org>. I can download this but is it likely that there will be v2? If so, I'll hoold on for that. If not, I'll download it. BR, Jarkko
On Fri, Aug 2, 2024 at 8:07 PM Jarkko Sakkinen <jarkko.sakkinen@iki.fi> wrote: > > On Fri Aug 2, 2024 at 4:10 PM EEST, Herbert Xu wrote: > > On Fri, Jul 12, 2024 at 09:11:13AM +0200, Jan Stancek wrote: > > > The ENGINE interface has its limitations and it has been superseded > > > by the PROVIDER API, it is deprecated in OpenSSL version 3.0. > > > Some distros have started removing it from header files. > > > > > > Update sign-file and extract-cert to use PROVIDER API for OpenSSL Major >= 3. > > > > > > Tested on F39 with openssl-3.1.1, pkcs11-provider-0.5-2, openssl-pkcs11-0.4.12-4 > > > and softhsm-2.6.1-5 by using same key/cert as PEM and PKCS11 and comparing that > > > the result is identical. > > > > > > Jan Stancek (3): > > > sign-file,extract-cert: move common SSL helper functions to a header > > > sign-file,extract-cert: avoid using deprecated ERR_get_error_line() > > > sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3 > > > > > > MAINTAINERS | 1 + > > > certs/Makefile | 2 +- > > > certs/extract-cert.c | 138 +++++++++++++++++++++++-------------------- > > > scripts/sign-file.c | 134 +++++++++++++++++++++-------------------- > > > scripts/ssl-common.h | 32 ++++++++++ > > > 5 files changed, 178 insertions(+), 129 deletions(-) > > > create mode 100644 scripts/ssl-common.h > > > > Adding Cc to Jarkko Sakkinen <jarkko@kernel.org>. > > I can download this but is it likely that there will be v2? If so, > I'll hoold on for that. If not, I'll download it. Noone requested any changes to v1 so far, so if you can have a look, it would be much appreciated. Thanks, Jan > > BR, Jarkko >
On Fri Aug 2, 2024 at 9:27 PM EEST, Jan Stancek wrote: > On Fri, Aug 2, 2024 at 8:07 PM Jarkko Sakkinen <jarkko.sakkinen@iki.fi> wrote: > > > > On Fri Aug 2, 2024 at 4:10 PM EEST, Herbert Xu wrote: > > > On Fri, Jul 12, 2024 at 09:11:13AM +0200, Jan Stancek wrote: > > > > The ENGINE interface has its limitations and it has been superseded > > > > by the PROVIDER API, it is deprecated in OpenSSL version 3.0. > > > > Some distros have started removing it from header files. > > > > > > > > Update sign-file and extract-cert to use PROVIDER API for OpenSSL Major >= 3. > > > > > > > > Tested on F39 with openssl-3.1.1, pkcs11-provider-0.5-2, openssl-pkcs11-0.4.12-4 > > > > and softhsm-2.6.1-5 by using same key/cert as PEM and PKCS11 and comparing that > > > > the result is identical. > > > > > > > > Jan Stancek (3): > > > > sign-file,extract-cert: move common SSL helper functions to a header > > > > sign-file,extract-cert: avoid using deprecated ERR_get_error_line() > > > > sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3 > > > > > > > > MAINTAINERS | 1 + > > > > certs/Makefile | 2 +- > > > > certs/extract-cert.c | 138 +++++++++++++++++++++++-------------------- > > > > scripts/sign-file.c | 134 +++++++++++++++++++++-------------------- > > > > scripts/ssl-common.h | 32 ++++++++++ > > > > 5 files changed, 178 insertions(+), 129 deletions(-) > > > > create mode 100644 scripts/ssl-common.h > > > > > > Adding Cc to Jarkko Sakkinen <jarkko@kernel.org>. > > > > I can download this but is it likely that there will be v2? If so, > > I'll hoold on for that. If not, I'll download it. > > Noone requested any changes to v1 so far, so if you can have a look, > it would be much appreciated. OK that is totally fine! I'm just prioritizing and postponing stuff that I can (WHEN it makes sense pragmatically) to get back in the phase ;-) I take a look at this next week. > Thanks, > Jan BR, Jarkko
On Friday, July 12, 2024 3:11:13 AM EDT Jan Stancek wrote: > The ENGINE interface has its limitations and it has been superseded > by the PROVIDER API, it is deprecated in OpenSSL version 3.0. > Some distros have started removing it from header files. > > Update sign-file and extract-cert to use PROVIDER API for OpenSSL Major >= > 3. > > Tested on F39 with openssl-3.1.1, pkcs11-provider-0.5-2, > openssl-pkcs11-0.4.12-4 and softhsm-2.6.1-5 by using same key/cert as PEM > and PKCS11 and comparing that the result is identical. > > Jan Stancek (3): > sign-file,extract-cert: move common SSL helper functions to a header > sign-file,extract-cert: avoid using deprecated ERR_get_error_line() > sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3 > > MAINTAINERS | 1 + > certs/Makefile | 2 +- > certs/extract-cert.c | 138 +++++++++++++++++++++++-------------------- > scripts/sign-file.c | 134 +++++++++++++++++++++-------------------- > scripts/ssl-common.h | 32 ++++++++++ > 5 files changed, 178 insertions(+), 129 deletions(-) > create mode 100644 scripts/ssl-common.h The code looks fairly reasonable to me and behaves as expected. I have been actively using this patch set for several weeks now across linux-6.9.y and now linux-6.10.y with good success. It is in use in production for Fedora Asahi Linux kernels with good success. Thanks for the fixes. :) Reviewed-by: Neal Gompa <neal@gompa.dev>
>Date: Fri, 12 Jul 2024 09:11:13 +0200 [thread overview] >Message-ID: <cover.1720728319.git.jstancek@redhat.com> (raw) > >The ENGINE interface has its limitations and it has been superseded >by the PROVIDER API, it is deprecated in OpenSSL version 3.0. >Some distros have started removing it from header files. > >Update sign-file and extract-cert to use PROVIDER API for OpenSSL Major >= 3. > >Tested on F39 with openssl-3.1.1, pkcs11-provider-0.5-2, openssl-pkcs11-0.4.12-4 >and softhsm-2.6.1-5 by using same key/cert as PEM and PKCS11 and comparing that >the result is identical. > >Jan Stancek (3): > sign-file,extract-cert: move common SSL helper functions to a header > sign-file,extract-cert: avoid using deprecated ERR_get_error_line() > sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3 > > MAINTAINERS | 1 + > certs/Makefile | 2 +- > certs/extract-cert.c | 138 +++++++++++++++++++++++-------------------- > scripts/sign-file.c | 134 +++++++++++++++++++++-------------------- > scripts/ssl-common.h | 32 ++++++++++ > 5 files changed, 178 insertions(+), 129 deletions(-) > create mode 100644 scripts/ssl-common.h Tested on a system where openssl-engine package was not available. With out the patch, couldn't compile upstream kernel (tried 6.11-rc5) With patch, could compile upstream kernel (tried 6.11-rc5) Tested-by: R Nageswara Sastry <rnsastry@linux.ibm.com> > >-- >2.39.3