mbox series

[RESEND,v2,0/2] ecdsa KEYCTL_PKEY_QUERY fixes

Message ID cover.1744052920.git.lukas@wunner.de (mailing list archive)
Headers show
Series ecdsa KEYCTL_PKEY_QUERY fixes | expand

Message

Lukas Wunner April 7, 2025, 7:32 p.m. UTC 
Here are two patches for ecdsa to avoid reporting nonsensical values
for enc/dec size and -- for P521 keys -- also the key size in response
to KEYCTL_PKEY_QUERY system calls.

Resending as requested by Herbert:

  https://lore.kernel.org/r/Z9fuCTAAOphOvEeH@gondor.apana.org.au/

Link to the original submission:

  https://lore.kernel.org/r/cover.1738521533.git.lukas@wunner.de/

Although these are technically fixes, the issues they address are
not critical, so I recommend not applying as fixes for v6.15,
but rather let the patches soak in linux-next for v6.16.


Lukas Wunner (2):
  crypto: ecdsa - Fix enc/dec size reported by KEYCTL_PKEY_QUERY
  crypto: ecdsa - Fix NIST P521 key size reported by KEYCTL_PKEY_QUERY

 crypto/asymmetric_keys/public_key.c | 13 +++++++++----
 crypto/ecdsa-p1363.c                |  6 ++++--
 crypto/ecdsa-x962.c                 |  5 +++--
 crypto/ecdsa.c                      |  2 +-
 crypto/ecrdsa.c                     |  2 +-
 crypto/rsassa-pkcs1.c               |  2 +-
 crypto/sig.c                        |  9 +++++++--
 include/crypto/sig.h                |  2 +-
 8 files changed, 27 insertions(+), 14 deletions(-)

Comments

Herbert Xu April 16, 2025, 7:56 a.m. UTC | #1 
On Mon, Apr 07, 2025 at 09:32:40PM +0200, Lukas Wunner wrote:
> Here are two patches for ecdsa to avoid reporting nonsensical values
> for enc/dec size and -- for P521 keys -- also the key size in response
> to KEYCTL_PKEY_QUERY system calls.
> 
> Resending as requested by Herbert:
> 
>   https://lore.kernel.org/r/Z9fuCTAAOphOvEeH@gondor.apana.org.au/
> 
> Link to the original submission:
> 
>   https://lore.kernel.org/r/cover.1738521533.git.lukas@wunner.de/
> 
> Although these are technically fixes, the issues they address are
> not critical, so I recommend not applying as fixes for v6.15,
> but rather let the patches soak in linux-next for v6.16.
> 
> 
> Lukas Wunner (2):
>   crypto: ecdsa - Fix enc/dec size reported by KEYCTL_PKEY_QUERY
>   crypto: ecdsa - Fix NIST P521 key size reported by KEYCTL_PKEY_QUERY
> 
>  crypto/asymmetric_keys/public_key.c | 13 +++++++++----
>  crypto/ecdsa-p1363.c                |  6 ++++--
>  crypto/ecdsa-x962.c                 |  5 +++--
>  crypto/ecdsa.c                      |  2 +-
>  crypto/ecrdsa.c                     |  2 +-
>  crypto/rsassa-pkcs1.c               |  2 +-
>  crypto/sig.c                        |  9 +++++++--
>  include/crypto/sig.h                |  2 +-
>  8 files changed, 27 insertions(+), 14 deletions(-)
> 
> -- 
> 2.43.0

All applied.  Thanks.