diff mbox series

[01/10] certs: use $@ to simplify the key generation rule

Message ID 20211212192941.1149247-2-masahiroy@kernel.org (mailing list archive)
State New
Headers show
Series kbuild: do not quote string values in Makefile | expand

Commit Message

Masahiro Yamada Dec. 12, 2021, 7:29 p.m. UTC 
Do not repeat $(obj)/signing_key.pem

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 certs/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Nicolas Schier Dec. 13, 2021, 1 p.m. UTC | #1 
On Mon, Dec 13, 2021 at 04:29:32AM +0900, Masahiro Yamada wrote:
> Do not repeat $(obj)/signing_key.pem
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  certs/Makefile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/certs/Makefile b/certs/Makefile
> index a702b70f3cb9..97fd6cc02972 100644
> --- a/certs/Makefile
> +++ b/certs/Makefile
> @@ -61,8 +61,7 @@ keytype-$(CONFIG_MODULE_SIG_KEY_TYPE_ECDSA) := -newkey ec -pkeyopt ec_paramgen_c
>  quiet_cmd_gen_key = GENKEY  $@
>        cmd_gen_key = openssl req -new -nodes -utf8 -$(CONFIG_MODULE_SIG_HASH) -days 36500 \
>  		-batch -x509 -config $(obj)/x509.genkey \

Don't you want to replace $< too?

Reviewed-by: Nicolas Schier <n.schier@avm.de>

> -		-outform PEM -out $(obj)/signing_key.pem \
> -		-keyout $(obj)/signing_key.pem $(keytype-y) 2>&1
> +		-outform PEM -out $@ -keyout $@ $(keytype-y) 2>&1
>  
>  $(obj)/signing_key.pem: $(obj)/x509.genkey FORCE
>  	$(call if_changed,gen_key)
> -- 
> 2.32.0
>
Masahiro Yamada Dec. 14, 2021, 1:45 a.m. UTC | #2 
On Mon, Dec 13, 2021 at 10:30 PM Nicolas Schier <n.schier@avm.de> wrote:
>
> On Mon, Dec 13, 2021 at 04:29:32AM +0900, Masahiro Yamada wrote:
> > Do not repeat $(obj)/signing_key.pem
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> >  certs/Makefile | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/certs/Makefile b/certs/Makefile
> > index a702b70f3cb9..97fd6cc02972 100644
> > --- a/certs/Makefile
> > +++ b/certs/Makefile
> > @@ -61,8 +61,7 @@ keytype-$(CONFIG_MODULE_SIG_KEY_TYPE_ECDSA) := -newkey ec -pkeyopt ec_paramgen_c
> >  quiet_cmd_gen_key = GENKEY  $@
> >        cmd_gen_key = openssl req -new -nodes -utf8 -$(CONFIG_MODULE_SIG_HASH) -days 36500 \
> >               -batch -x509 -config $(obj)/x509.genkey \
>
> Don't you want to replace $< too?

Ah, goot catch! Thanks.

I will change it as well.




> Reviewed-by: Nicolas Schier <n.schier@avm.de>
>
> > -             -outform PEM -out $(obj)/signing_key.pem \
> > -             -keyout $(obj)/signing_key.pem $(keytype-y) 2>&1
> > +             -outform PEM -out $@ -keyout $@ $(keytype-y) 2>&1
> >
> >  $(obj)/signing_key.pem: $(obj)/x509.genkey FORCE
> >       $(call if_changed,gen_key)
> > --
> > 2.32.0
> >



--
Best Regards
Masahiro Yamada
diff mbox series

Patch

diff --git a/certs/Makefile b/certs/Makefile
index a702b70f3cb9..97fd6cc02972 100644
--- a/certs/Makefile
+++ b/certs/Makefile
@@ -61,8 +61,7 @@  keytype-$(CONFIG_MODULE_SIG_KEY_TYPE_ECDSA) := -newkey ec -pkeyopt ec_paramgen_c
 quiet_cmd_gen_key = GENKEY  $@
       cmd_gen_key = openssl req -new -nodes -utf8 -$(CONFIG_MODULE_SIG_HASH) -days 36500 \
 		-batch -x509 -config $(obj)/x509.genkey \
-		-outform PEM -out $(obj)/signing_key.pem \
-		-keyout $(obj)/signing_key.pem $(keytype-y) 2>&1
+		-outform PEM -out $@ -keyout $@ $(keytype-y) 2>&1
 
 $(obj)/signing_key.pem: $(obj)/x509.genkey FORCE
 	$(call if_changed,gen_key)