From patchwork Sun Dec 12 19:29:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 12672563 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F795C433EF for ; Sun, 12 Dec 2021 19:31:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230484AbhLLTbS (ORCPT ); Sun, 12 Dec 2021 14:31:18 -0500 Received: from conuserg-08.nifty.com ([210.131.2.75]:25070 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229693AbhLLTbD (ORCPT ); Sun, 12 Dec 2021 14:31:03 -0500 Received: from grover.. (133-32-232-101.west.xps.vectant.ne.jp [133.32.232.101]) (authenticated) by conuserg-08.nifty.com with ESMTP id 1BCJTqAp000552; Mon, 13 Dec 2021 04:29:56 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com 1BCJTqAp000552 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1639337397; bh=rH8InQ87yWgmbTzWzCuJf5hMM+XsyOHQP3hvLfEpPFI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vwSRDsxspAnGGoqh66zHuoBynGYONkUkQcW7Sjr7KsPLt4jFw6VwMnl/rWdm/Cj3P N01w/r13istNAxOX6ZDa3VTyblhVLEFIXPbGaDcRZ/F4s5JhIICWI485JRyXez+NSX 7VuY+b0i9gtPdYDxZuxXNNWvnDJdyLJPhMa8yIYXG+Z8TlEhmIF9o/QfibkQxpWh8o VYp6MLOy6gxwRn6SO+fxNdcydMm+kwfOOWCVMzQ7U4gBF47Vj1vWzh3rsHjBCYpmzQ UttDljg9LH3+rnqZ+0Wu+stEquup9RPvZlWZShqZ9sklPoZoJeyUMVCBdsNLmtIKIi dwzKCXdcSwK0w== X-Nifty-SrcIP: [133.32.232.101] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Michal Simek , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, David Howells , David Woodhouse , keyrings@vger.kernel.org, Richard Weinberger , Masahiro Yamada Subject: [PATCH 05/10] certs: remove misleading comments about GCC PR Date: Mon, 13 Dec 2021 04:29:36 +0900 Message-Id: <20211212192941.1149247-6-masahiroy@kernel.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211212192941.1149247-1-masahiroy@kernel.org> References: <20211212192941.1149247-1-masahiroy@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: keyrings@vger.kernel.org This dependency is necessary irrespective of the mentioned GCC PR because the embedded certificates are build artifacts and must be generated by extract_certs before *.S files are compiled. The comment sounds like we are hoping to remove these dependencies someday. No, we cannot remove them. Signed-off-by: Masahiro Yamada --- certs/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/certs/Makefile b/certs/Makefile index 0dc523e8ca7c..d21d1612b7fd 100644 --- a/certs/Makefile +++ b/certs/Makefile @@ -19,7 +19,6 @@ ifeq ($(CONFIG_SYSTEM_TRUSTED_KEYRING),y) $(eval $(call config_filename,SYSTEM_TRUSTED_KEYS)) -# GCC doesn't include .incbin files in -MD generated dependencies (PR#66871) $(obj)/system_certificates.o: $(obj)/x509_certificate_list $(obj)/x509_certificate_list: scripts/extract-cert $(SYSTEM_TRUSTED_KEYS_SRCPREFIX)$(SYSTEM_TRUSTED_KEYS_FILENAME) FORCE @@ -80,7 +79,6 @@ ifeq ($(patsubst pkcs11:%,%,$(firstword $(MODULE_SIG_KEY_FILENAME))),$(firstword X509_DEP := $(MODULE_SIG_KEY_SRCPREFIX)$(MODULE_SIG_KEY_FILENAME) endif -# GCC PR#66871 again. $(obj)/system_certificates.o: $(obj)/signing_key.x509 $(obj)/signing_key.x509: scripts/extract-cert $(X509_DEP) FORCE