| Message ID | 20220704112028.183193-1-renzhijie2@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] certs: Fix Kconfig dependency | expand |
On 7/4/22 04:20, Ren Zhijie wrote: > If CONFIG_PKCS7_MESSAGE_PARSER=m and CONFIG_FIPS_SIGNATURE_SELFTEST=y, > make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like this: > > crypto/asymmetric_keys/selftest.o: In function `fips_signature_selftest': > selftest.c:(.init.text+0xc3): undefined reference to `pkcs7_parse_message' > selftest.c:(.init.text+0x101): undefined reference to `pkcs7_supply_detached_data' > selftest.c:(.init.text+0x112): undefined reference to `pkcs7_verify' > selftest.c:(.init.text+0x13f): undefined reference to `pkcs7_validate_trust' > selftest.c:(.init.text+0x169): undefined reference to `pkcs7_free_message' > make: *** [vmlinux] Error 1 > > To fix this error, add depends on PKCS7_MESSAGE_PARSER=y to FIPS_SIGNATURE_SELFTEST > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: 3cde3174eb91 ("certs: Add FIPS selftests") > Signed-off-by: Ren Zhijie <renzhijie2@huawei.com> > --- > crypto/asymmetric_keys/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig > index 3df3fe4ed95f..fe007db96c69 100644 > --- a/crypto/asymmetric_keys/Kconfig > +++ b/crypto/asymmetric_keys/Kconfig > @@ -83,6 +83,6 @@ config FIPS_SIGNATURE_SELFTEST > for FIPS. > depends on KEYS > depends on ASYMMETRIC_KEY_TYPE > - depends on PKCS7_MESSAGE_PARSER > + depends on PKCS7_MESSAGE_PARSER=y > > endif # ASYMMETRIC_KEY_TYPE Acked-by: Randy Dunlap <rdunlap@infradead.org> Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Reported-by: kernel test robot <lkp@intel.com> # 2022-06-30 thanks.
Hi, Just a friendly ping... 在 2022/7/4 19:20, Ren Zhijie 写道: > If CONFIG_PKCS7_MESSAGE_PARSER=m and CONFIG_FIPS_SIGNATURE_SELFTEST=y, > make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like this: > > crypto/asymmetric_keys/selftest.o: In function `fips_signature_selftest': > selftest.c:(.init.text+0xc3): undefined reference to `pkcs7_parse_message' > selftest.c:(.init.text+0x101): undefined reference to `pkcs7_supply_detached_data' > selftest.c:(.init.text+0x112): undefined reference to `pkcs7_verify' > selftest.c:(.init.text+0x13f): undefined reference to `pkcs7_validate_trust' > selftest.c:(.init.text+0x169): undefined reference to `pkcs7_free_message' > make: *** [vmlinux] Error 1 > > To fix this error, add depends on PKCS7_MESSAGE_PARSER=y to FIPS_SIGNATURE_SELFTEST > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: 3cde3174eb91 ("certs: Add FIPS selftests") > Signed-off-by: Ren Zhijie <renzhijie2@huawei.com> > --- > crypto/asymmetric_keys/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig > index 3df3fe4ed95f..fe007db96c69 100644 > --- a/crypto/asymmetric_keys/Kconfig > +++ b/crypto/asymmetric_keys/Kconfig > @@ -83,6 +83,6 @@ config FIPS_SIGNATURE_SELFTEST > for FIPS. > depends on KEYS > depends on ASYMMETRIC_KEY_TYPE > - depends on PKCS7_MESSAGE_PARSER > + depends on PKCS7_MESSAGE_PARSER=y > > endif # ASYMMETRIC_KEY_TYPE
diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig index 3df3fe4ed95f..fe007db96c69 100644 --- a/crypto/asymmetric_keys/Kconfig +++ b/crypto/asymmetric_keys/Kconfig @@ -83,6 +83,6 @@ config FIPS_SIGNATURE_SELFTEST for FIPS. depends on KEYS depends on ASYMMETRIC_KEY_TYPE - depends on PKCS7_MESSAGE_PARSER + depends on PKCS7_MESSAGE_PARSER=y endif # ASYMMETRIC_KEY_TYPE
If CONFIG_PKCS7_MESSAGE_PARSER=m and CONFIG_FIPS_SIGNATURE_SELFTEST=y, make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like this: crypto/asymmetric_keys/selftest.o: In function `fips_signature_selftest': selftest.c:(.init.text+0xc3): undefined reference to `pkcs7_parse_message' selftest.c:(.init.text+0x101): undefined reference to `pkcs7_supply_detached_data' selftest.c:(.init.text+0x112): undefined reference to `pkcs7_verify' selftest.c:(.init.text+0x13f): undefined reference to `pkcs7_validate_trust' selftest.c:(.init.text+0x169): undefined reference to `pkcs7_free_message' make: *** [vmlinux] Error 1 To fix this error, add depends on PKCS7_MESSAGE_PARSER=y to FIPS_SIGNATURE_SELFTEST Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: 3cde3174eb91 ("certs: Add FIPS selftests") Signed-off-by: Ren Zhijie <renzhijie2@huawei.com> --- crypto/asymmetric_keys/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)