| Message ID | 20250112163059.467573-1-linux@treblig.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | crypto: asymmetric_keys - Remove unused key_being_used_for[] | expand |
On Sun, Jan 12, 2025 at 04:30:59PM +0000, linux@treblig.org wrote: > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > key_being_used_for[] is an unused array of textual names for > the elements of the enum key_being_used_for. It was added in 2015 by > commit 99db44350672 ("PKCS#7: Appropriately restrict authenticated > attributes and content type") > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> > --- > crypto/asymmetric_keys/asymmetric_type.c | 10 ---------- > include/linux/verification.h | 2 -- > 2 files changed, 12 deletions(-) Patch applied. Thanks.
linux@treblig.org wrote: > key_being_used_for[] is an unused array of textual names for > the elements of the enum key_being_used_for. It was added in 2015 by > commit 99db44350672 ("PKCS#7: Appropriately restrict authenticated > attributes and content type") > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> Acked-by: David Howells <dhowells@redhat.com>
diff --git a/crypto/asymmetric_keys/asymmetric_type.c b/crypto/asymmetric_keys/asymmetric_type.c index 43af5fa510c0..ba2d9d1ea235 100644 --- a/crypto/asymmetric_keys/asymmetric_type.c +++ b/crypto/asymmetric_keys/asymmetric_type.c @@ -18,16 +18,6 @@ #include "asymmetric_keys.h" -const char *const key_being_used_for[NR__KEY_BEING_USED_FOR] = { - [VERIFYING_MODULE_SIGNATURE] = "mod sig", - [VERIFYING_FIRMWARE_SIGNATURE] = "firmware sig", - [VERIFYING_KEXEC_PE_SIGNATURE] = "kexec PE sig", - [VERIFYING_KEY_SIGNATURE] = "key sig", - [VERIFYING_KEY_SELF_SIGNATURE] = "key self sig", - [VERIFYING_UNSPECIFIED_SIGNATURE] = "unspec sig", -}; -EXPORT_SYMBOL_GPL(key_being_used_for); - static LIST_HEAD(asymmetric_key_parsers); static DECLARE_RWSEM(asymmetric_key_parsers_sem); diff --git a/include/linux/verification.h b/include/linux/verification.h index cb2d47f28091..4f3022d081c3 100644 --- a/include/linux/verification.h +++ b/include/linux/verification.h @@ -38,8 +38,6 @@ enum key_being_used_for { VERIFYING_UNSPECIFIED_SIGNATURE, NR__KEY_BEING_USED_FOR }; -extern const char *const key_being_used_for[NR__KEY_BEING_USED_FOR]; - #ifdef CONFIG_SYSTEM_DATA_VERIFICATION struct key;