| Message ID | ce5bc8c0-2c6d-2a22-1ad3-357254686366@ddn.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | fix certs compilation / export is_key_on_revocation_list | expand |
Sorry for the spam, besides that pasting the patch somehow did not work (I cannot apply it myself), I had also a typo in David W.'s mail. I hope that attaching the patch is fine. On 3/2/22 21:06, Bernd Schubert wrote: > From: Bernd Schubert <bschubert@ddn.com> > > Compilation of 5.17-rc7-master was failing with my .config > (actually taken from Ubuntus 5.17 package) > > certs/system_keyring.o: In function `verify_pkcs7_message_sig': > linux/certs/system_keyring.c:224: > undefined reference to `is_key_on_revocation_list' > > > That got fixed by exporting the 'is_key_on_revocation_list' symbol. > > > Signed-off-by: Bernd Schubert <bschubert@ddn.com> > --- > certs/blacklist.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/certs/blacklist.c b/certs/blacklist.c > index c9a435b15af4..ad39780e5150 100644 > --- a/certs/blacklist.c > +++ b/certs/blacklist.c > @@ -192,6 +192,7 @@ int is_key_on_revocation_list(struct pkcs7_message > *pkcs7) > > return -ENOKEY; > } > +EXPORT_SYMBOL_GPL(is_key_on_revocation_list); > #endif > > /*
ping On 3/2/22 21:19, Bernd Schubert wrote: > Sorry for the spam, besides that pasting the patch somehow did not work > (I cannot apply it myself), I had also a typo in David W.'s mail. I hope > that attaching the patch is fine. > > > > On 3/2/22 21:06, Bernd Schubert wrote: >> From: Bernd Schubert <bschubert@ddn.com> >> >> Compilation of 5.17-rc7-master was failing with my .config >> (actually taken from Ubuntus 5.17 package) >> >> certs/system_keyring.o: In function `verify_pkcs7_message_sig': >> linux/certs/system_keyring.c:224: >> undefined reference to `is_key_on_revocation_list' >> >> >> That got fixed by exporting the 'is_key_on_revocation_list' symbol. >> >> >> Signed-off-by: Bernd Schubert <bschubert@ddn.com> >> --- >> certs/blacklist.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/certs/blacklist.c b/certs/blacklist.c >> index c9a435b15af4..ad39780e5150 100644 >> --- a/certs/blacklist.c >> +++ b/certs/blacklist.c >> @@ -192,6 +192,7 @@ int is_key_on_revocation_list(struct pkcs7_message >> *pkcs7) >> >> return -ENOKEY; >> } >> +EXPORT_SYMBOL_GPL(is_key_on_revocation_list); >> #endif >> >> /*
On 3/29/22 12:09, Bernd Schubert wrote: > ping > > On 3/2/22 21:19, Bernd Schubert wrote: >> Sorry for the spam, besides that pasting the patch somehow did not >> work (I cannot apply it myself), I had also a typo in David W.'s mail. >> I hope that attaching the patch is fine. Actually not needed anymore with released v5.17. Looks like there was another fix for it. Thanks, Bernd
diff --git a/certs/blacklist.c b/certs/blacklist.c index c9a435b15af4..ad39780e5150 100644 --- a/certs/blacklist.c +++ b/certs/blacklist.c @@ -192,6 +192,7 @@ int is_key_on_revocation_list(struct pkcs7_message *pkcs7) return -ENOKEY; } +EXPORT_SYMBOL_GPL(is_key_on_revocation_list); #endif /*