From patchwork Tue Nov 19 09:53:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudio Imbrenda X-Patchwork-Id: 11251655 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1BD81109A for ; Tue, 19 Nov 2019 09:53:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 028C420857 for ; Tue, 19 Nov 2019 09:53:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727324AbfKSJxw (ORCPT ); Tue, 19 Nov 2019 04:53:52 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:9334 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727255AbfKSJxw (ORCPT ); Tue, 19 Nov 2019 04:53:52 -0500 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xAJ9qq1O031231 for ; Tue, 19 Nov 2019 04:53:47 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2wact6pw16-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 19 Nov 2019 04:53:47 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 19 Nov 2019 09:53:43 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 19 Nov 2019 09:53:41 -0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xAJ9reTh57934034 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Nov 2019 09:53:40 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 414C152051; Tue, 19 Nov 2019 09:53:40 +0000 (GMT) Received: from p-imbrenda.boeblingen.de.ibm.com (unknown [9.152.224.108]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id 007235204F; Tue, 19 Nov 2019 09:53:39 +0000 (GMT) From: Claudio Imbrenda To: kvm@vger.kernel.org Cc: linux-s390@vger.kernel.org, thuth@redhat.com, david@redhat.com, borntraeger@de.ibm.com, frankja@linux.ibm.com Subject: [kvm-unit-tests PATCH v4 0/3] s390x: SCLP Unit test Date: Tue, 19 Nov 2019 10:53:36 +0100 X-Mailer: git-send-email 2.7.4 X-TM-AS-GCONF: 00 x-cbid: 19111909-0020-0000-0000-0000038A6D47 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19111909-0021-0000-0000-000021E09863 Message-Id: <1574157219-22052-1-git-send-email-imbrenda@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-19_02:2019-11-15,2019-11-19 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 mlxlogscore=696 suspectscore=1 adultscore=0 mlxscore=0 bulkscore=0 clxscore=1015 spamscore=0 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1911190094 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org This patchset contains some minor cleanup, some preparatory work and then the SCLP unit test itself. The unit test checks the following: * Correctly ignoring instruction bits that should be ignored * Privileged instruction check * Check for addressing exceptions * Specification exceptions: - SCCB size less than 8 - SCCB unaligned - SCCB overlaps prefix or lowcore - SCCB address higher than 2GB * Return codes for - Invalid command - SCCB too short (but at least 8) - SCCB page boundary violation v3 -> v4 * export sclp_setup_int instead of copying it * add more comments * rename some more variables to improve readability * improve the prefix test * improved the invalid address test * addressed further comments received during review v2 -> v3 * generally improved the naming of variables * added and fixed comments * renamed test_one_run to test_one_simple * added some const where needed * addresed many more small comments received during review v1 -> v2 * fix many small issues that came up during the first round of reviews * add comments to each function * use a static buffer for the SCCP template when used Claudio Imbrenda (3): s390x: export sclp_setup_int s390x: sclp: add service call instruction wrapper s390x: SCLP unit test s390x/Makefile | 1 + lib/s390x/asm/arch_def.h | 13 ++ lib/s390x/sclp.h | 1 + lib/s390x/sclp.c | 9 +- s390x/sclp.c | 465 +++++++++++++++++++++++++++++++++++++++++++++++ s390x/unittests.cfg | 3 + 6 files changed, 485 insertions(+), 7 deletions(-) create mode 100644 s390x/sclp.c