| Message ID | 171741323521.6631.11242552089199677395.stgit@linux.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | KVM: PPC: Book3S HV: Nested guest migration fixes | expand |
On Mon Jun 3, 2024 at 9:13 PM AEST, Shivaprasad G Bhat wrote: > The series fixes the issues exposed by the kvm-unit-tests[1] > sprs-migration test. > > The SDAR, MMCR3 were seen to have some typo/refactoring bugs. > The first two patches fix them. > > Though the nestedv2 APIs defined the guest state elements for > Power ISA 3.1B SPRs to save-restore with PHYP during entry-exit, > the DEXCR and HASHKEYR were ignored in code. The KVM_PPC_REG too > for them are missing without which the Qemu is not setting them > to their 'previous' value during guest migration at destination. > The remaining patches take care of this. These aren't just fixes for nested v2 or even just migration, by the way. Good fixes. Thanks, Nick > > References: > [1]: https://github.com/kvm-unit-tests/kvm-unit-tests > > --- > > Shivaprasad G Bhat (6): > KVM: PPC: Book3S HV: Fix the set_one_reg for MMCR3 > KVM: PPC: Book3S HV: Fix the get_one_reg of SDAR > KVM: PPC: Book3S HV nestedv2: Keep nested guest DEXCR in sync > KVM: PPC: Book3S HV: Add one-reg interface for DEXCR register > KVM: PPC: Book3S HV nestedv2: Keep nested guest HASHKEYR in sync > KVM: PPC: Book3S HV: Add one-reg interface for HASHKEYR register > > > Documentation/virt/kvm/api.rst | 2 ++ > arch/powerpc/include/asm/kvm_host.h | 2 ++ > arch/powerpc/include/uapi/asm/kvm.h | 2 ++ > arch/powerpc/kvm/book3s_hv.c | 16 ++++++++++++++-- > arch/powerpc/kvm/book3s_hv.h | 2 ++ > arch/powerpc/kvm/book3s_hv_nestedv2.c | 12 ++++++++++++ > tools/arch/powerpc/include/uapi/asm/kvm.h | 2 ++ > 7 files changed, 36 insertions(+), 2 deletions(-) > > -- > Signature
The series fixes the issues exposed by the kvm-unit-tests[1] sprs-migration test. The SDAR, MMCR3 were seen to have some typo/refactoring bugs. The first two patches fix them. Though the nestedv2 APIs defined the guest state elements for Power ISA 3.1B SPRs to save-restore with PHYP during entry-exit, the DEXCR and HASHKEYR were ignored in code. The KVM_PPC_REG too for them are missing without which the Qemu is not setting them to their 'previous' value during guest migration at destination. The remaining patches take care of this. References: [1]: https://github.com/kvm-unit-tests/kvm-unit-tests --- Shivaprasad G Bhat (6): KVM: PPC: Book3S HV: Fix the set_one_reg for MMCR3 KVM: PPC: Book3S HV: Fix the get_one_reg of SDAR KVM: PPC: Book3S HV nestedv2: Keep nested guest DEXCR in sync KVM: PPC: Book3S HV: Add one-reg interface for DEXCR register KVM: PPC: Book3S HV nestedv2: Keep nested guest HASHKEYR in sync KVM: PPC: Book3S HV: Add one-reg interface for HASHKEYR register Documentation/virt/kvm/api.rst | 2 ++ arch/powerpc/include/asm/kvm_host.h | 2 ++ arch/powerpc/include/uapi/asm/kvm.h | 2 ++ arch/powerpc/kvm/book3s_hv.c | 16 ++++++++++++++-- arch/powerpc/kvm/book3s_hv.h | 2 ++ arch/powerpc/kvm/book3s_hv_nestedv2.c | 12 ++++++++++++ tools/arch/powerpc/include/uapi/asm/kvm.h | 2 ++ 7 files changed, 36 insertions(+), 2 deletions(-) -- Signature