mbox series

[kvm-unit-tests,v2,0/7] Fixes for clang builds

Message ID 20200226094433.210968-1-morbo@google.com (mailing list archive)
Headers show
Series Fixes for clang builds | expand

Message

Bill Wendling Feb. 26, 2020, 9:44 a.m. UTC
Changes to "pci: cast masks to uint32_t for unsigned long values" to
cast the masks instead of changing the values in the header.

Bill Wendling (2):
  x86: emulator: use "SSE2" for the target
  pci: cast masks to uint32_t for unsigned long values

Eric Hankland (2):
  x86: pmu: Test WRMSR on a running counter
  x86: pmu: Test perfctr overflow after WRMSR on a running counter

Oliver Upton (1):
  x86: VMX: Add tests for monitor trap flag

Paolo Bonzini (2):
  x86: provide enabled and disabled variation of the PCID test
  vmx: tweak XFAILS for #DB test

Comments

Oliver Upton Feb. 26, 2020, 7:02 p.m. UTC | #1
Hi Bill,

On Wed, Feb 26, 2020 at 1:44 AM Bill Wendling <morbo@google.com> wrote:
>
> Changes to "pci: cast masks to uint32_t for unsigned long values" to
> cast the masks instead of changing the values in the header.
>
> Bill Wendling (2):
>   x86: emulator: use "SSE2" for the target
>   pci: cast masks to uint32_t for unsigned long values
>
> Eric Hankland (2):
>   x86: pmu: Test WRMSR on a running counter
>   x86: pmu: Test perfctr overflow after WRMSR on a running counter
>
> Oliver Upton (1):
>   x86: VMX: Add tests for monitor trap flag
>
> Paolo Bonzini (2):
>   x86: provide enabled and disabled variation of the PCID test
>   vmx: tweak XFAILS for #DB test
>

These patches have already been pushed. Was there any reason to squash
your v1 patches into the commits that introduced the clang issues?
Otherwise, I'd strongly suggest re-posting the v1 series with just the
clang fixes.

Thanks!

--
Best,
Oliver
Paolo Bonzini Feb. 28, 2020, 11:19 a.m. UTC | #2
On 26/02/20 10:44, Bill Wendling wrote:
> Changes to "pci: cast masks to uint32_t for unsigned long values" to
> cast the masks instead of changing the values in the header.

Applied 1-3-4 and a tweaked version of 2 and 7.

For 5, let's use -fwrapv instead.

For 6, clang people should stop implementing GCC extensions in half and
declaring themselves compatible.  It's just a sanity check, you can wrap
it all with #ifndef __clang__.

Paolo