mbox series

[0/2] KVM: VMX: CR0/CR4 guest/host masks cleanup

Message ID 20200703040422.31536-1-sean.j.christopherson@intel.com (mailing list archive)
Headers show
Series KVM: VMX: CR0/CR4 guest/host masks cleanup | expand

Message

Sean Christopherson July 3, 2020, 4:04 a.m. UTC
Fix a bug where CR4.TSD isn't correctly marked as being possibly owned by
the guest in the common x86 macro, then clean up the mess that made the
bug possible by throwing away VMX's mix of duplicate code and open coded
tweaks.  The lack of a define for the guest-owned CR0 bit has bugged me
for a long time, but adding another define always seemed ridiculous.

Sean Christopherson (2):
  KVM: x86: Mark CR4.TSD as being possibly owned by the guest
  KVM: VMX: Use KVM_POSSIBLE_CR*_GUEST_BITS to initialize guest/host
    masks

 arch/x86/kvm/kvm_cache_regs.h |  2 +-
 arch/x86/kvm/vmx/nested.c     |  4 ++--
 arch/x86/kvm/vmx/vmx.c        | 13 +++++--------
 3 files changed, 8 insertions(+), 11 deletions(-)

Comments

Paolo Bonzini July 3, 2020, 4:16 p.m. UTC | #1
On 03/07/20 06:04, Sean Christopherson wrote:
> Fix a bug where CR4.TSD isn't correctly marked as being possibly owned by
> the guest in the common x86 macro, then clean up the mess that made the
> bug possible by throwing away VMX's mix of duplicate code and open coded
> tweaks.  The lack of a define for the guest-owned CR0 bit has bugged me
> for a long time, but adding another define always seemed ridiculous.
> 
> Sean Christopherson (2):
>   KVM: x86: Mark CR4.TSD as being possibly owned by the guest
>   KVM: VMX: Use KVM_POSSIBLE_CR*_GUEST_BITS to initialize guest/host
>     masks
> 
>  arch/x86/kvm/kvm_cache_regs.h |  2 +-
>  arch/x86/kvm/vmx/nested.c     |  4 ++--
>  arch/x86/kvm/vmx/vmx.c        | 13 +++++--------
>  3 files changed, 8 insertions(+), 11 deletions(-)
> 

Queued, thanks.

Paolo