[kvm-unit-tests,v4,0/3] s390x: mvpg test

Message

Claudio Imbrenda March 2, 2021, 11:41 a.m. UTC

A simple unit test for the MVPG instruction.

The timeout is set to 10 seconds because the test should complete in a
fraction of a second even on busy machines. If the test is run in VSIE
and the host of the host is not handling MVPG properly, the test will
probably hang.

Testing MVPG behaviour in VSIE is the main motivation for this test.

Anything related to storage keys is not tested.

v3->v4
* add memset after the first successful mvpg to make sure memory is really
  copied successfully
* add a comment and an additional prefix to the tests skipped when running
  in TCG

v2->v3
* fix copyright (2020 is over!)
* add the third patch to skip some known issues when running in TCG

v1->v2
* droppped patch 2 which introduced is_pgm();
* patch 1: replace a hardcoded value with the new macro SVC_LEAVE_PSTATE
* patch 2: clear_pgm_int() returns the old value, use that instad of is_pgm()

Claudio Imbrenda (3):
  s390x: introduce leave_pstate to leave userspace
  s390x: mvpg: simple test
  s390x: mvpg: skip some tests when using TCG

 s390x/Makefile           |   1 +
 lib/s390x/asm/arch_def.h |   7 +
 lib/s390x/interrupt.c    |  12 +-
 s390x/mvpg.c             | 277 +++++++++++++++++++++++++++++++++++++++
 s390x/unittests.cfg      |   4 +
 5 files changed, 299 insertions(+), 2 deletions(-)
 create mode 100644 s390x/mvpg.c

Comments

Janosch Frank March 8, 2021, 11:14 a.m. UTC | #1

On 3/2/21 12:41 PM, Claudio Imbrenda wrote:
> A simple unit test for the MVPG instruction.
> 
> The timeout is set to 10 seconds because the test should complete in a
> fraction of a second even on busy machines. If the test is run in VSIE
> and the host of the host is not handling MVPG properly, the test will
> probably hang.
> 
> Testing MVPG behaviour in VSIE is the main motivation for this test.
> 
> Anything related to storage keys is not tested.

Thanks, picked.

> 
> v3->v4
> * add memset after the first successful mvpg to make sure memory is really
>   copied successfully
> * add a comment and an additional prefix to the tests skipped when running
>   in TCG
> 
> v2->v3
> * fix copyright (2020 is over!)
> * add the third patch to skip some known issues when running in TCG
> 
> v1->v2
> * droppped patch 2 which introduced is_pgm();
> * patch 1: replace a hardcoded value with the new macro SVC_LEAVE_PSTATE
> * patch 2: clear_pgm_int() returns the old value, use that instad of is_pgm()
> 
> Claudio Imbrenda (3):
>   s390x: introduce leave_pstate to leave userspace
>   s390x: mvpg: simple test
>   s390x: mvpg: skip some tests when using TCG
> 
>  s390x/Makefile           |   1 +
>  lib/s390x/asm/arch_def.h |   7 +
>  lib/s390x/interrupt.c    |  12 +-
>  s390x/mvpg.c             | 277 +++++++++++++++++++++++++++++++++++++++
>  s390x/unittests.cfg      |   4 +
>  5 files changed, 299 insertions(+), 2 deletions(-)
>  create mode 100644 s390x/mvpg.c
>