| Message ID | 20210331210841.3996155-1-bgardon@google.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | More parallel operations for the TDP MMU | expand |
On 31/03/21 23:08, Ben Gardon wrote: > Now that the TDP MMU is able to handle page faults in parallel, it's a > relatively small change to expand to other operations. This series allows > zapping a range of GFNs, reclaiming collapsible SPTEs (when disabling > dirty logging), and enabling dirty logging to all happen under the MMU > lock in read mode. > > This is partly a cleanup + rewrite of the last few patches of the parallel > page faults series. I've incorporated feedback from Sean and Paolo, but > the patches have changed so much that I'm sending this as a separate > series. > > Ran kvm-unit-tests + selftests on an SMP kernel + Intel Skylake, with the > TDP MMU enabled and disabled. This series introduces no new failures or > warnings. > > I know this will conflict horribly with the patches from Sean's series > which were just queued, and I'll send a v2 to fix those conflicts + > address any feedback on this v1. Mostly looks good (the only substantial remark is from Sean's reply to patch 7); I've made a couple adjustments to the patches I had queued to ease the fixing of conflicts. The patches should hit kvm/queue later today, right after I send my 5.11 pull request to Linus. I have also just sent a completely unrelated remark on the existing page fault function, which was prompted by reviewing these patches. If you agree, I can take care of the change or you can include it in v2, as you prefer (I don't expect conflicts). Paolo
Now that the TDP MMU is able to handle page faults in parallel, it's a relatively small change to expand to other operations. This series allows zapping a range of GFNs, reclaiming collapsible SPTEs (when disabling dirty logging), and enabling dirty logging to all happen under the MMU lock in read mode. This is partly a cleanup + rewrite of the last few patches of the parallel page faults series. I've incorporated feedback from Sean and Paolo, but the patches have changed so much that I'm sending this as a separate series. Ran kvm-unit-tests + selftests on an SMP kernel + Intel Skylake, with the TDP MMU enabled and disabled. This series introduces no new failures or warnings. I know this will conflict horribly with the patches from Sean's series which were just queued, and I'll send a v2 to fix those conflicts + address any feedback on this v1. Ben Gardon (13): KVM: x86/mmu: Re-add const qualifier in kvm_tdp_mmu_zap_collapsible_sptes KVM: x86/mmu: Move kvm_mmu_(get|put)_root to TDP MMU KVM: x86/mmu: use tdp_mmu_free_sp to free roots KVM: x86/mmu: Merge TDP MMU put and free root KVM: x86/mmu: comment for_each_tdp_mmu_root requires MMU write lock KVM: x86/mmu: Refactor yield safe root iterator KVM: x86/mmu: Make TDP MMU root refcount atomic KVM: x86/mmu: Protect the tdp_mmu_roots list with RCU KVM: x86/mmu: Allow zap gfn range to operate under the mmu read lock KVM: x86/mmu: Allow zapping collapsible SPTEs to use MMU read lock KVM: x86/mmu: Allow enabling / disabling dirty logging under MMU read lock KVM: x86/mmu: Fast invalidation for TDP MMU KVM: x86/mmu: Tear down roots in fast invalidation thread arch/x86/kvm/mmu/mmu.c | 70 +++--- arch/x86/kvm/mmu/mmu_internal.h | 27 +-- arch/x86/kvm/mmu/tdp_mmu.c | 383 ++++++++++++++++++++++++-------- arch/x86/kvm/mmu/tdp_mmu.h | 21 +- include/linux/kvm_host.h | 2 +- 5 files changed, 357 insertions(+), 146 deletions(-)