mbox series

[0/3] VMX: configure posted interrupt descriptor when assigning device (v5)

Message ID 20210525134115.135966361@redhat.com (mailing list archive)
Headers show
Series VMX: configure posted interrupt descriptor when assigning device (v5) | expand

Message

Marcelo Tosatti May 25, 2021, 1:41 p.m. UTC
Configuration of the posted interrupt descriptor is incorrect when devices
are hotplugged to the guest (and vcpus are halted).

See patch 3 for details.

---

v5: use KVM_REQ_UNBLOCK instead of kvm_check_block callback (Paolo / Peter Xu)

v4: remove NULL assignments from kvm_x86_ops (Peter Xu)
    check for return value of ->start_assignment directly (Peter Xu)

v3: improved comments (Sean)
    use kvm_vcpu_wake_up (Sean)
    drop device_count from start_assignment function (Peter Xu)

v2: rather than using a potentially racy IPI (vs vcpu->cpu switches),
    kick the vcpus when assigning a device and let the blocked per-CPU
    list manipulation happen locally at ->pre_block and ->post_block
    (Sean Christopherson).

Comments

Paolo Bonzini May 27, 2021, 11:59 a.m. UTC | #1
On 25/05/21 15:41, Marcelo Tosatti wrote:
> Configuration of the posted interrupt descriptor is incorrect when devices
> are hotplugged to the guest (and vcpus are halted).
> 
> See patch 3 for details.
> 
> ---
> 
> v5: use KVM_REQ_UNBLOCK instead of kvm_check_block callback (Paolo / Peter Xu)
> 
> v4: remove NULL assignments from kvm_x86_ops (Peter Xu)
>      check for return value of ->start_assignment directly (Peter Xu)
> 
> v3: improved comments (Sean)
>      use kvm_vcpu_wake_up (Sean)
>      drop device_count from start_assignment function (Peter Xu)
> 
> v2: rather than using a potentially racy IPI (vs vcpu->cpu switches),
>      kick the vcpus when assigning a device and let the blocked per-CPU
>      list manipulation happen locally at ->pre_block and ->post_block
>      (Sean Christopherson).
> 
> 
> 

Queued, thanks.

Paolo