mbox series

[v3,0/2] Wrap EFL binaries into ISO images

Message ID 20210613124724.1850051-1-yi.sun@intel.com (mailing list archive)
Headers show
Series Wrap EFL binaries into ISO images | expand

Message

Yi Sun June 13, 2021, 12:47 p.m. UTC
This patch set make use of tool 'grub-mkrescue' to wrap ELF binaries 
into bootable ISO images.

Cases in kvm-unit-tests can be run with QEMU. But the problem is that
some newer VMMs such as Crosvm/Cloud-hyperviosr does NOT support 
multiboot protocol with which QEMU loads and executes those testing 
binaries correctly. This patch set can wrap each kvm-unit-tests EFL 
binaries into a bootable ISO image aiming to adapt it to more usage 
scenarios. As we know, all PC BIOSes and vBIOSes know how to boot 
from a ISO from CD-ROM drive, hence it can extend the KVM-unit-tests 
a lot.

The patch set provides two approaches to create ISO. One is via 
"make iso". It wrap each ELF in foler x86 into a ISO without any 
parameters passed to the test cases.  The other is via script 
create_iso.sh. The script wraps the ELF according to the configure
file unittests.cfg which descripes various parameters for each testing.

Patch History:
V1: Initial version.
V2: Add the second parament to the script create_iso.sh, that could 
pass environment variables into test cases via the file.
V3: Add some failure handle.

 lib/grub/grub.cfg   |   7 +++
 x86/Makefile.common |  18 +++++++-
 x86/create_iso.sh   | 110 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 134 insertions(+), 1 deletion(-)
 create mode 100644 lib/grub/grub.cfg
 create mode 100755 x86/create_iso.sh

Comments

Nadav Amit June 16, 2021, 5:45 p.m. UTC | #1
> On Jun 13, 2021, at 5:47 AM, Yi Sun <yi.sun@intel.com> wrote:
> 
> This patch set make use of tool 'grub-mkrescue' to wrap ELF binaries 
> into bootable ISO images.
> 
> Cases in kvm-unit-tests can be run with QEMU. But the problem is that
> some newer VMMs such as Crosvm/Cloud-hyperviosr does NOT support 
> multiboot protocol with which QEMU loads and executes those testing 
> binaries correctly. This patch set can wrap each kvm-unit-tests EFL 
> binaries into a bootable ISO image aiming to adapt it to more usage 
> scenarios. As we know, all PC BIOSes and vBIOSes know how to boot 
> from a ISO from CD-ROM drive, hence it can extend the KVM-unit-tests 
> a lot.
> 
> The patch set provides two approaches to create ISO. One is via 
> "make iso". It wrap each ELF in foler x86 into a ISO without any 
> parameters passed to the test cases.  The other is via script 
> create_iso.sh. The script wraps the ELF according to the configure
> file unittests.cfg which descripes various parameters for each testing.
> 
> Patch History:
> V1: Initial version.
> V2: Add the second parament to the script create_iso.sh, that could 
> pass environment variables into test cases via the file.
> V3: Add some failure handle.

Thanks for doing that. I find your work very useful (at least for me).

For what it worth in kvm-unit-tests, I should have gave before:

Tested-by: Nadav Amit <nadav.amit@gmail.com>


Thanks,
Nadav