| Message ID | 20211108152819.12485-1-vkuznets@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | KVM: x86: Sanitize writes to MSR_KVM_PV_EOI_EN | expand |
On 11/8/21 16:28, Vitaly Kuznetsov wrote: > This is a continuation of work started by Li RongQing with > "[PATCH] KVM: x86: disable pv eoi if guest gives a wrong address": > https://lore.kernel.org/kvm/1636078404-48617-1-git-send-email-lirongqing@baidu.com/ > > Instead of resetting 'KVM_MSR_ENABLED' when a bogus address was written to > MSR_KVM_PV_EOI_EN I suggest we refuse to update MSR at all, this aligns > with #GP which is being injected on such writes. > > Vitaly Kuznetsov (2): > KVM: x86: Rename kvm_lapic_enable_pv_eoi() > KVM: x86: Don't update vcpu->arch.pv_eoi.msr_val when a bogus value > was written to MSR_KVM_PV_EOI_EN > > arch/x86/kvm/hyperv.c | 4 ++-- > arch/x86/kvm/lapic.c | 23 ++++++++++++++--------- > arch/x86/kvm/lapic.h | 2 +- > arch/x86/kvm/x86.c | 2 +- > 4 files changed, 18 insertions(+), 13 deletions(-) > Queued, thanks. Paolo
This is a continuation of work started by Li RongQing with "[PATCH] KVM: x86: disable pv eoi if guest gives a wrong address": https://lore.kernel.org/kvm/1636078404-48617-1-git-send-email-lirongqing@baidu.com/ Instead of resetting 'KVM_MSR_ENABLED' when a bogus address was written to MSR_KVM_PV_EOI_EN I suggest we refuse to update MSR at all, this aligns with #GP which is being injected on such writes. Vitaly Kuznetsov (2): KVM: x86: Rename kvm_lapic_enable_pv_eoi() KVM: x86: Don't update vcpu->arch.pv_eoi.msr_val when a bogus value was written to MSR_KVM_PV_EOI_EN arch/x86/kvm/hyperv.c | 4 ++-- arch/x86/kvm/lapic.c | 23 ++++++++++++++--------- arch/x86/kvm/lapic.h | 2 +- arch/x86/kvm/x86.c | 2 +- 4 files changed, 18 insertions(+), 13 deletions(-)