mbox series

[0/7] My set of KVM unit tests + fixes

Message ID 20220208122148.912913-1-mlevitsk@redhat.com (mailing list archive)
Headers show
Series My set of KVM unit tests + fixes | expand

Message

Maxim Levitsky Feb. 8, 2022, 12:21 p.m. UTC
Those are few kvm unit tests tha I developed.

Best regards,
    Maxim Levitsky

Maxim Levitsky (7):
  pmu_lbr: few fixes
  svm: Fix reg_corruption test, to avoid timer interrupt firing in later
    tests.
  svm: NMI is an "exception" and not interrupt in x86 land
  svm: intercept shutdown in all svm tests by default
  svm: add SVM_BARE_VMRUN
  svm: add tests for LBR virtualization
  svm: add tests for case when L1 intercepts various hardware interrupts
    (an interrupt, SMI, NMI), but lets L2 control either EFLAG.IF or GIF

 lib/x86/processor.h |   1 +
 x86/pmu_lbr.c       |   6 +
 x86/svm.c           |  41 +---
 x86/svm.h           |  63 ++++++-
 x86/svm_tests.c     | 447 +++++++++++++++++++++++++++++++++++++++++++-
 x86/unittests.cfg   |   3 +-
 6 files changed, 521 insertions(+), 40 deletions(-)

Comments

Maxim Levitsky Feb. 23, 2022, 12:03 p.m. UTC | #1
On Tue, 2022-02-08 at 14:21 +0200, Maxim Levitsky wrote:
> Those are few kvm unit tests tha I developed.
> 
> Best regards,
>     Maxim Levitsky
> 
> Maxim Levitsky (7):
>   pmu_lbr: few fixes
>   svm: Fix reg_corruption test, to avoid timer interrupt firing in later
>     tests.
>   svm: NMI is an "exception" and not interrupt in x86 land
>   svm: intercept shutdown in all svm tests by default
>   svm: add SVM_BARE_VMRUN
>   svm: add tests for LBR virtualization
>   svm: add tests for case when L1 intercepts various hardware interrupts
>     (an interrupt, SMI, NMI), but lets L2 control either EFLAG.IF or GIF
> 
>  lib/x86/processor.h |   1 +
>  x86/pmu_lbr.c       |   6 +
>  x86/svm.c           |  41 +---
>  x86/svm.h           |  63 ++++++-
>  x86/svm_tests.c     | 447 +++++++++++++++++++++++++++++++++++++++++++-
>  x86/unittests.cfg   |   3 +-
>  6 files changed, 521 insertions(+), 40 deletions(-)
> 
> -- 
> 2.26.3
> 
> 
Any update on these patches?

Best regards,
	Maxim Levitsky
Alexandru Elisei Feb. 24, 2022, 10:20 a.m. UTC | #2
Hi,

On Wed, Feb 23, 2022 at 02:03:54PM +0200, Maxim Levitsky wrote:
> On Tue, 2022-02-08 at 14:21 +0200, Maxim Levitsky wrote:
> > Those are few kvm unit tests tha I developed.
> > 
> > Best regards,
> >     Maxim Levitsky
> > 
> > Maxim Levitsky (7):
> >   pmu_lbr: few fixes
> >   svm: Fix reg_corruption test, to avoid timer interrupt firing in later
> >     tests.
> >   svm: NMI is an "exception" and not interrupt in x86 land
> >   svm: intercept shutdown in all svm tests by default
> >   svm: add SVM_BARE_VMRUN
> >   svm: add tests for LBR virtualization
> >   svm: add tests for case when L1 intercepts various hardware interrupts
> >     (an interrupt, SMI, NMI), but lets L2 control either EFLAG.IF or GIF
> > 
> >  lib/x86/processor.h |   1 +
> >  x86/pmu_lbr.c       |   6 +
> >  x86/svm.c           |  41 +---
> >  x86/svm.h           |  63 ++++++-
> >  x86/svm_tests.c     | 447 +++++++++++++++++++++++++++++++++++++++++++-
> >  x86/unittests.cfg   |   3 +-
> >  6 files changed, 521 insertions(+), 40 deletions(-)
> > 
> > -- 
> > 2.26.3
> > 
> > 
> Any update on these patches?

It is possible that because you haven't sent the patches to the x86
maintainer (as per the MAINTAINERS file), this series has gone unnoticed.
Also, each patch should start with "kvm-unit-tests PATCH" (have a look at
the README file), so people can easily tell them apart from KVM patches,
which go to the same mailing list.

You could try resending the entire series to the x86 mailing list and to
the relevant maintainers. To resend them, the convention is to modify the
subject prefix to "kvm-unit-tests PATCH RESEND" and send them without any
changes (though you can mention in the cover letter why you resent the
series).

Hope this helps!

Thanks,
Alex

> 
> Best regards,
> 	Maxim Levitsky
>
Maxim Levitsky Feb. 24, 2022, 11 a.m. UTC | #3
On Thu, 2022-02-24 at 10:20 +0000, Alexandru Elisei wrote:
> Hi,
> 
> On Wed, Feb 23, 2022 at 02:03:54PM +0200, Maxim Levitsky wrote:
> > On Tue, 2022-02-08 at 14:21 +0200, Maxim Levitsky wrote:
> > > Those are few kvm unit tests tha I developed.
> > > 
> > > Best regards,
> > >     Maxim Levitsky
> > > 
> > > Maxim Levitsky (7):
> > >   pmu_lbr: few fixes
> > >   svm: Fix reg_corruption test, to avoid timer interrupt firing in later
> > >     tests.
> > >   svm: NMI is an "exception" and not interrupt in x86 land
> > >   svm: intercept shutdown in all svm tests by default
> > >   svm: add SVM_BARE_VMRUN
> > >   svm: add tests for LBR virtualization
> > >   svm: add tests for case when L1 intercepts various hardware interrupts
> > >     (an interrupt, SMI, NMI), but lets L2 control either EFLAG.IF or GIF
> > > 
> > >  lib/x86/processor.h |   1 +
> > >  x86/pmu_lbr.c       |   6 +
> > >  x86/svm.c           |  41 +---
> > >  x86/svm.h           |  63 ++++++-
> > >  x86/svm_tests.c     | 447 +++++++++++++++++++++++++++++++++++++++++++-
> > >  x86/unittests.cfg   |   3 +-
> > >  6 files changed, 521 insertions(+), 40 deletions(-)
> > > 
> > > -- 
> > > 2.26.3
> > > 
> > > 
> > Any update on these patches?
> 
> It is possible that because you haven't sent the patches to the x86
> maintainer (as per the MAINTAINERS file), this series has gone unnoticed.
> Also, each patch should start with "kvm-unit-tests PATCH" (have a look at
> the README file), so people can easily tell them apart from KVM patches,
> which go to the same mailing list.
Do kvm-unit tests have MAINTAINERS file? Those patches are not for the kernel
but for the kvm-unit test project.

> 
> You could try resending the entire series to the x86 mailing list and to
> the relevant maintainers. To resend them, the convention is to modify the
> subject prefix to "kvm-unit-tests PATCH RESEND" and send them without any
> changes (though you can mention in the cover letter why you resent the
> series).
Thank you, I missed the prefix to be used!

> 
> Hope this helps!
> 
> Thanks,
> Alex

Thanks!
Best regards,
	Maxim Levitsky

> 
> > Best regards,
> > 	Maxim Levitsky
> >
Alexandru Elisei Feb. 24, 2022, 11:08 a.m. UTC | #4
Hi,

On Thu, Feb 24, 2022 at 01:00:28PM +0200, Maxim Levitsky wrote:
> On Thu, 2022-02-24 at 10:20 +0000, Alexandru Elisei wrote:
> > Hi,
> > 
> > On Wed, Feb 23, 2022 at 02:03:54PM +0200, Maxim Levitsky wrote:
> > > On Tue, 2022-02-08 at 14:21 +0200, Maxim Levitsky wrote:
> > > > Those are few kvm unit tests tha I developed.
> > > > 
> > > > Best regards,
> > > >     Maxim Levitsky
> > > > 
> > > > Maxim Levitsky (7):
> > > >   pmu_lbr: few fixes
> > > >   svm: Fix reg_corruption test, to avoid timer interrupt firing in later
> > > >     tests.
> > > >   svm: NMI is an "exception" and not interrupt in x86 land
> > > >   svm: intercept shutdown in all svm tests by default
> > > >   svm: add SVM_BARE_VMRUN
> > > >   svm: add tests for LBR virtualization
> > > >   svm: add tests for case when L1 intercepts various hardware interrupts
> > > >     (an interrupt, SMI, NMI), but lets L2 control either EFLAG.IF or GIF
> > > > 
> > > >  lib/x86/processor.h |   1 +
> > > >  x86/pmu_lbr.c       |   6 +
> > > >  x86/svm.c           |  41 +---
> > > >  x86/svm.h           |  63 ++++++-
> > > >  x86/svm_tests.c     | 447 +++++++++++++++++++++++++++++++++++++++++++-
> > > >  x86/unittests.cfg   |   3 +-
> > > >  6 files changed, 521 insertions(+), 40 deletions(-)
> > > > 
> > > > -- 
> > > > 2.26.3
> > > > 
> > > > 
> > > Any update on these patches?
> > 
> > It is possible that because you haven't sent the patches to the x86
> > maintainer (as per the MAINTAINERS file), this series has gone unnoticed.
> > Also, each patch should start with "kvm-unit-tests PATCH" (have a look at
> > the README file), so people can easily tell them apart from KVM patches,
> > which go to the same mailing list.
> Do kvm-unit tests have MAINTAINERS file? Those patches are not for the kernel
> but for the kvm-unit test project.

A simple ls should be sufficient [1] to answer that question.

[1] https://gitlab.com/kvm-unit-tests/kvm-unit-tests/-/blob/master/MAINTAINERS

Thanks,
Alex

> 
> > 
> > You could try resending the entire series to the x86 mailing list and to
> > the relevant maintainers. To resend them, the convention is to modify the
> > subject prefix to "kvm-unit-tests PATCH RESEND" and send them without any
> > changes (though you can mention in the cover letter why you resent the
> > series).
> Thank you, I missed the prefix to be used!
> 
> > 
> > Hope this helps!
> > 
> > Thanks,
> > Alex
> 
> Thanks!
> Best regards,
> 	Maxim Levitsky
> 
> > 
> > > Best regards,
> > > 	Maxim Levitsky
> > > 
> 
>
Maxim Levitsky Feb. 24, 2022, 12:44 p.m. UTC | #5
On Thu, 2022-02-24 at 11:08 +0000, Alexandru Elisei wrote:
> Hi,
> 
> On Thu, Feb 24, 2022 at 01:00:28PM +0200, Maxim Levitsky wrote:
> > On Thu, 2022-02-24 at 10:20 +0000, Alexandru Elisei wrote:
> > > Hi,
> > > 
> > > On Wed, Feb 23, 2022 at 02:03:54PM +0200, Maxim Levitsky wrote:
> > > > On Tue, 2022-02-08 at 14:21 +0200, Maxim Levitsky wrote:
> > > > > Those are few kvm unit tests tha I developed.
> > > > > 
> > > > > Best regards,
> > > > >     Maxim Levitsky
> > > > > 
> > > > > Maxim Levitsky (7):
> > > > >   pmu_lbr: few fixes
> > > > >   svm: Fix reg_corruption test, to avoid timer interrupt firing in later
> > > > >     tests.
> > > > >   svm: NMI is an "exception" and not interrupt in x86 land
> > > > >   svm: intercept shutdown in all svm tests by default
> > > > >   svm: add SVM_BARE_VMRUN
> > > > >   svm: add tests for LBR virtualization
> > > > >   svm: add tests for case when L1 intercepts various hardware interrupts
> > > > >     (an interrupt, SMI, NMI), but lets L2 control either EFLAG.IF or GIF
> > > > > 
> > > > >  lib/x86/processor.h |   1 +
> > > > >  x86/pmu_lbr.c       |   6 +
> > > > >  x86/svm.c           |  41 +---
> > > > >  x86/svm.h           |  63 ++++++-
> > > > >  x86/svm_tests.c     | 447 +++++++++++++++++++++++++++++++++++++++++++-
> > > > >  x86/unittests.cfg   |   3 +-
> > > > >  6 files changed, 521 insertions(+), 40 deletions(-)
> > > > > 
> > > > > -- 
> > > > > 2.26.3
> > > > > 
> > > > > 
> > > > Any update on these patches?
> > > 
> > > It is possible that because you haven't sent the patches to the x86
> > > maintainer (as per the MAINTAINERS file), this series has gone unnoticed.
> > > Also, each patch should start with "kvm-unit-tests PATCH" (have a look at
> > > the README file), so people can easily tell them apart from KVM patches,
> > > which go to the same mailing list.
> > Do kvm-unit tests have MAINTAINERS file? Those patches are not for the kernel
> > but for the kvm-unit test project.
> 
> A simple ls should be sufficient [1] to answer that question.
> 
> [1] https://gitlab.com/kvm-unit-tests/kvm-unit-tests/-/blob/master/MAINTAINERS

I am blind. just that. I checked it and haven't seen the file. Now I see it of course.

Best regards,
	Maixm Levitsky

> 
> Thanks,
> Alex
> 
> > > You could try resending the entire series to the x86 mailing list and to
> > > the relevant maintainers. To resend them, the convention is to modify the
> > > subject prefix to "kvm-unit-tests PATCH RESEND" and send them without any
> > > changes (though you can mention in the cover letter why you resent the
> > > series).
> > Thank you, I missed the prefix to be used!
> > 
> > > Hope this helps!
> > > 
> > > Thanks,
> > > Alex
> > 
> > Thanks!
> > Best regards,
> > 	Maxim Levitsky
> > 
> > > > Best regards,
> > > > 	Maxim Levitsky
> > > >