mbox series

[kvmtool,0/4] Update virtio headers (to fix build)

Message ID 20220524150611.523910-1-andre.przywara@arm.com (mailing list archive)
Headers show
Series Update virtio headers (to fix build) | expand

Message

Andre Przywara May 24, 2022, 3:06 p.m. UTC 
Since we implement some virtio devices in kvmtool, we were including
older copies of some virtio UAPI header files in our tree, but were
relying on some other headers to be provided by the distribution.
This leads to problems when we need to use newer virtio features (like
the recent virtio_balloon stat update), which breaks compilation on some
(older) distros.

To fix this and avoid similar problems in the future, just copy in the
virtio UAPI headers from the kernel tree, as we do already for the
actual KVM interface headers. To simplify future syncs, also update our
update_headers.sh script on the way.

Please have a look!

Cheers,
Andre

Andre Przywara (4):
  update virtio_mmio.h
  util: include virtio UAPI headers in sync
  include: update virtio UAPI headers
  include: add new virtio uapi header files

 include/linux/virtio_9p.h      |  44 ++++++
 include/linux/virtio_balloon.h | 119 ++++++++++++++++
 include/linux/virtio_blk.h     | 203 +++++++++++++++++++++++++++
 include/linux/virtio_config.h  | 101 ++++++++++++++
 include/linux/virtio_console.h |  78 +++++++++++
 include/linux/virtio_ids.h     |  63 +++++++--
 include/linux/virtio_mmio.h    |  55 +++++++-
 include/linux/virtio_net.h     | 200 +++++++++++++++++++++++----
 include/linux/virtio_pci.h     | 208 ++++++++++++++++++++++++++++
 include/linux/virtio_ring.h    | 244 +++++++++++++++++++++++++++++++++
 include/linux/virtio_rng.h     |   8 ++
 include/linux/virtio_scsi.h    | 118 ++++++++--------
 include/linux/virtio_vsock.h   |  16 ++-
 util/update_headers.sh         |  10 ++
 virtio/mmio.c                  |   8 +-
 15 files changed, 1372 insertions(+), 103 deletions(-)
 create mode 100644 include/linux/virtio_9p.h
 create mode 100644 include/linux/virtio_balloon.h
 create mode 100644 include/linux/virtio_blk.h
 create mode 100644 include/linux/virtio_config.h
 create mode 100644 include/linux/virtio_console.h
 create mode 100644 include/linux/virtio_pci.h
 create mode 100644 include/linux/virtio_ring.h
 create mode 100644 include/linux/virtio_rng.h

Comments

Will Deacon May 26, 2022, 9:17 a.m. UTC | #1 
On Tue, 24 May 2022 16:06:07 +0100, Andre Przywara wrote:
> Since we implement some virtio devices in kvmtool, we were including
> older copies of some virtio UAPI header files in our tree, but were
> relying on some other headers to be provided by the distribution.
> This leads to problems when we need to use newer virtio features (like
> the recent virtio_balloon stat update), which breaks compilation on some
> (older) distros.
> 
> [...]

Applied to kvmtool (master), thanks!

[1/4] update virtio_mmio.h
      https://git.kernel.org/will/kvmtool/c/7e2209945bb5
[2/4] util: include virtio UAPI headers in sync
      https://git.kernel.org/will/kvmtool/c/393e2187cf68
[3/4] include: update virtio UAPI headers
      https://git.kernel.org/will/kvmtool/c/e5390783db61
[4/4] include: add new virtio uapi header files
      https://git.kernel.org/will/kvmtool/c/1a992bbaab08

Cheers,