| Message ID | 20220613133922.2875594-1-vkuznets@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | KVM: x86: hyper-v: Fine-grained TLB flush + L2 TLB flush features | expand |
On 6/13/22 15:38, Vitaly Kuznetsov wrote: > Changes since v6: > - Rebase to the latest kvm/queue [8baacf67c76c], newly introduced > selftests had to be adapted to the overhauled API [blame Sean]. > - Rename 'entry' to 'flush_all_entry' in hv_tlb_flush_enqueue() [Max]. > - Add "KVM: selftests: Rename 'evmcs_test' to 'hyperv_evmcs'" patch. > - Collect R-b tags. > > Original description: > > Currently, KVM handles HVCALL_FLUSH_VIRTUAL_ADDRESS_LIST{,EX} requests > by flushing the whole VPID and this is sub-optimal. This series introduces > the required mechanism to make handling of these requests more > fine-grained by flushing individual GVAs only (when requested). On this > foundation, "Direct Virtual Flush" Hyper-V feature is implemented. The > feature allows L0 to handle Hyper-V TLB flush hypercalls directly at > L0 without the need to reflect the exit to L1. This has at least two > benefits: reflecting vmexit and the consequent vmenter are avoided + L0 > has precise information whether the target vCPU is actually running (and > thus requires a kick). I haven't reviewed the selftests part yet, but for the rest I only had two very small comments. Paolo
Paolo Bonzini <pbonzini@redhat.com> writes: > On 6/13/22 15:38, Vitaly Kuznetsov wrote: >> Changes since v6: >> - Rebase to the latest kvm/queue [8baacf67c76c], newly introduced >> selftests had to be adapted to the overhauled API [blame Sean]. >> - Rename 'entry' to 'flush_all_entry' in hv_tlb_flush_enqueue() [Max]. >> - Add "KVM: selftests: Rename 'evmcs_test' to 'hyperv_evmcs'" patch. >> - Collect R-b tags. >> >> Original description: >> >> Currently, KVM handles HVCALL_FLUSH_VIRTUAL_ADDRESS_LIST{,EX} requests >> by flushing the whole VPID and this is sub-optimal. This series introduces >> the required mechanism to make handling of these requests more >> fine-grained by flushing individual GVAs only (when requested). On this >> foundation, "Direct Virtual Flush" Hyper-V feature is implemented. The >> feature allows L0 to handle Hyper-V TLB flush hypercalls directly at >> L0 without the need to reflect the exit to L1. This has at least two >> benefits: reflecting vmexit and the consequent vmenter are avoided + L0 >> has precise information whether the target vCPU is actually running (and >> thus requires a kick). > > I haven't reviewed the selftests part yet, but for the rest I only had > two very small comments. I got back to this today and turns out there's a conflict with commit cc5851c6be864c5772944e32df3da322fe3ad415 Author: Sean Christopherson <seanjc@google.com> Date: Wed Jun 8 22:45:15 2022 +0000 KVM: selftests: Use exception fixup for #UD/#GP Hyper-V MSR/hcall tests in selftest part. It's nothing big but I did some non-trivial changes when resolving and I think the reslut looks a bit nicer at the end. Also, I've addresed one of your comments and moved kvm_hv_get_tlb_flush_fifo()'s 'is_guest_mode' parameter introduction to PATCH11. I'm going to send out v8 with these changes.
Changes since v6: - Rebase to the latest kvm/queue [8baacf67c76c], newly introduced selftests had to be adapted to the overhauled API [blame Sean]. - Rename 'entry' to 'flush_all_entry' in hv_tlb_flush_enqueue() [Max]. - Add "KVM: selftests: Rename 'evmcs_test' to 'hyperv_evmcs'" patch. - Collect R-b tags. Original description: Currently, KVM handles HVCALL_FLUSH_VIRTUAL_ADDRESS_LIST{,EX} requests by flushing the whole VPID and this is sub-optimal. This series introduces the required mechanism to make handling of these requests more fine-grained by flushing individual GVAs only (when requested). On this foundation, "Direct Virtual Flush" Hyper-V feature is implemented. The feature allows L0 to handle Hyper-V TLB flush hypercalls directly at L0 without the need to reflect the exit to L1. This has at least two benefits: reflecting vmexit and the consequent vmenter are avoided + L0 has precise information whether the target vCPU is actually running (and thus requires a kick). Sean Christopherson (1): KVM: x86: hyper-v: Add helper to read hypercall data for array Vitaly Kuznetsov (38): KVM: x86: Rename 'enable_direct_tlbflush' to 'enable_l2_tlb_flush' KVM: x86: hyper-v: Resurrect dedicated KVM_REQ_HV_TLB_FLUSH flag KVM: x86: hyper-v: Introduce TLB flush fifo KVM: x86: hyper-v: Handle HVCALL_FLUSH_VIRTUAL_ADDRESS_LIST{,EX} calls gently KVM: x86: hyper-v: Expose support for extended gva ranges for flush hypercalls KVM: x86: Prepare kvm_hv_flush_tlb() to handle L2's GPAs x86/hyperv: Introduce HV_MAX_SPARSE_VCPU_BANKS/HV_VCPUS_PER_SPARSE_BANK constants KVM: x86: hyper-v: Use HV_MAX_SPARSE_VCPU_BANKS/HV_VCPUS_PER_SPARSE_BANK instead of raw '64' KVM: x86: hyper-v: Don't use sparse_set_to_vcpu_mask() in kvm_hv_send_ipi() KVM: x86: hyper-v: Create a separate fifo for L2 TLB flush KVM: x86: hyper-v: Use preallocated buffer in 'struct kvm_vcpu_hv' instead of on-stack 'sparse_banks' KVM: nVMX: Keep track of hv_vm_id/hv_vp_id when eVMCS is in use KVM: nSVM: Keep track of Hyper-V hv_vm_id/hv_vp_id KVM: x86: Introduce .hv_inject_synthetic_vmexit_post_tlb_flush() nested hook KVM: x86: hyper-v: Introduce kvm_hv_is_tlb_flush_hcall() KVM: x86: hyper-v: L2 TLB flush KVM: x86: hyper-v: Introduce fast guest_hv_cpuid_has_l2_tlb_flush() check x86/hyperv: Fix 'struct hv_enlightened_vmcs' definition KVM: nVMX: hyper-v: Cache VP assist page in 'struct kvm_vcpu_hv' KVM: nVMX: hyper-v: Enable L2 TLB flush KVM: nSVM: hyper-v: Enable L2 TLB flush KVM: x86: Expose Hyper-V L2 TLB flush feature KVM: selftests: Better XMM read/write helpers KVM: selftests: Move HYPERV_LINUX_OS_ID definition to a common header KVM: selftests: Move the function doing Hyper-V hypercall to a common header KVM: selftests: Hyper-V PV IPI selftest KVM: selftests: Fill in vm->vpages_mapped bitmap in virt_map() too KVM: selftests: Export vm_vaddr_unused_gap() to make it possible to request unmapped ranges KVM: selftests: Export _vm_get_page_table_entry() KVM: selftests: Hyper-V PV TLB flush selftest KVM: selftests: Sync 'struct hv_enlightened_vmcs' definition with hyperv-tlfs.h KVM: selftests: nVMX: Allocate Hyper-V partition assist page KVM: selftests: nSVM: Allocate Hyper-V partition assist and VP assist pages KVM: selftests: Sync 'struct hv_vp_assist_page' definition with hyperv-tlfs.h KVM: selftests: evmcs_test: Introduce L2 TLB flush test KVM: selftests: Move Hyper-V VP assist page enablement out of evmcs.h KVM: selftests: hyperv_svm_test: Introduce L2 TLB flush test KVM: selftests: Rename 'evmcs_test' to 'hyperv_evmcs' arch/x86/include/asm/hyperv-tlfs.h | 6 +- arch/x86/include/asm/kvm-x86-ops.h | 2 +- arch/x86/include/asm/kvm_host.h | 43 +- arch/x86/kvm/Makefile | 3 +- arch/x86/kvm/hyperv.c | 334 +++++++-- arch/x86/kvm/hyperv.h | 53 +- arch/x86/kvm/svm/hyperv.c | 18 + arch/x86/kvm/svm/hyperv.h | 48 ++ arch/x86/kvm/svm/nested.c | 39 +- arch/x86/kvm/svm/svm_onhyperv.c | 2 +- arch/x86/kvm/svm/svm_onhyperv.h | 6 +- arch/x86/kvm/trace.h | 21 +- arch/x86/kvm/vmx/evmcs.c | 42 +- arch/x86/kvm/vmx/evmcs.h | 13 +- arch/x86/kvm/vmx/nested.c | 44 +- arch/x86/kvm/vmx/vmx.c | 6 +- arch/x86/kvm/x86.c | 18 +- arch/x86/kvm/x86.h | 1 + include/asm-generic/hyperv-tlfs.h | 5 + include/asm-generic/mshyperv.h | 11 +- tools/testing/selftests/kvm/.gitignore | 4 +- tools/testing/selftests/kvm/Makefile | 5 +- .../selftests/kvm/include/kvm_util_base.h | 1 + .../selftests/kvm/include/x86_64/evmcs.h | 40 +- .../selftests/kvm/include/x86_64/hyperv.h | 62 ++ .../selftests/kvm/include/x86_64/processor.h | 72 +- .../selftests/kvm/include/x86_64/svm_util.h | 10 + .../selftests/kvm/include/x86_64/vmx.h | 4 + tools/testing/selftests/kvm/lib/kvm_util.c | 7 +- .../testing/selftests/kvm/lib/x86_64/hyperv.c | 21 + .../selftests/kvm/lib/x86_64/processor.c | 5 +- tools/testing/selftests/kvm/lib/x86_64/svm.c | 10 + tools/testing/selftests/kvm/lib/x86_64/vmx.c | 7 + .../x86_64/{evmcs_test.c => hyperv_evmcs.c} | 43 +- .../selftests/kvm/x86_64/hyperv_features.c | 23 +- .../testing/selftests/kvm/x86_64/hyperv_ipi.c | 341 +++++++++ .../selftests/kvm/x86_64/hyperv_svm_test.c | 54 +- .../selftests/kvm/x86_64/hyperv_tlb_flush.c | 649 ++++++++++++++++++ 38 files changed, 1869 insertions(+), 204 deletions(-) create mode 100644 arch/x86/kvm/svm/hyperv.c create mode 100644 tools/testing/selftests/kvm/lib/x86_64/hyperv.c rename tools/testing/selftests/kvm/x86_64/{evmcs_test.c => hyperv_evmcs.c} (81%) create mode 100644 tools/testing/selftests/kvm/x86_64/hyperv_ipi.c create mode 100644 tools/testing/selftests/kvm/x86_64/hyperv_tlb_flush.c