mbox series

[0/2] KVM: selftests: Fix Clang build issues in KVM_ASM_SAFE()

Message ID 20220722234838.2160385-1-dmatlack@google.com (mailing list archive)
Headers show
Series KVM: selftests: Fix Clang build issues in KVM_ASM_SAFE() | expand

Message

David Matlack July 22, 2022, 11:48 p.m. UTC
The LLVM integrated assembler has some differences from the GNU
assembler, and recent commit 3b23054cd3f5 ("KVM: selftests: Add x86-64
support for exception fixup") seems to be tripping over a few of those
differences.

David Matlack (2):
  KVM: selftests: Fix KVM_EXCEPTION_MAGIC build with Clang
  KVM: selftests: Fix ambiguous mov in KVM_ASM_SAFE()

 tools/testing/selftests/kvm/include/x86_64/processor.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


base-commit: 1a4d88a361af4f2e91861d632c6a1fe87a9665c2

Comments

David Matlack Aug. 10, 2022, 10:53 p.m. UTC | #1
On Fri, Jul 22, 2022 at 4:48 PM David Matlack <dmatlack@google.com> wrote:
>
> The LLVM integrated assembler has some differences from the GNU
> assembler, and recent commit 3b23054cd3f5 ("KVM: selftests: Add x86-64
> support for exception fixup") seems to be tripping over a few of those
> differences.

Paolo, what do you think about these changes? I'm still hitting the
mentioned Clang build issues on kvm/master, commit 93472b797153
("Merge tag 'kvmarm-5.20' of
git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm into
HEAD").

>
> David Matlack (2):
>   KVM: selftests: Fix KVM_EXCEPTION_MAGIC build with Clang
>   KVM: selftests: Fix ambiguous mov in KVM_ASM_SAFE()
>
>  tools/testing/selftests/kvm/include/x86_64/processor.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
>
> base-commit: 1a4d88a361af4f2e91861d632c6a1fe87a9665c2
> --
> 2.37.1.359.gd136c6c3e2-goog
>
Paolo Bonzini Aug. 12, 2022, 7:49 a.m. UTC | #2
On 8/11/22 00:53, David Matlack wrote:
> On Fri, Jul 22, 2022 at 4:48 PM David Matlack <dmatlack@google.com> wrote:
>>
>> The LLVM integrated assembler has some differences from the GNU
>> assembler, and recent commit 3b23054cd3f5 ("KVM: selftests: Add x86-64
>> support for exception fixup") seems to be tripping over a few of those
>> differences.
> 
> Paolo, what do you think about these changes? I'm still hitting the
> mentioned Clang build issues on kvm/master, commit 93472b797153
> ("Merge tag 'kvmarm-5.20' of
> git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm into
> HEAD").

I had missed them, so thanks for pinging.

Paolo
Paolo Bonzini Aug. 12, 2022, 7:57 a.m. UTC | #3
Queued, thanks.

Paolo