mbox series

[v6,0/8] KVM: arm64: Enable ring-based dirty memory tracking

Message ID 20221011061447.131531-1-gshan@redhat.com (mailing list archive)
Headers show
Series KVM: arm64: Enable ring-based dirty memory tracking | expand

Message

Gavin Shan Oct. 11, 2022, 6:14 a.m. UTC
This series enables the ring-based dirty memory tracking for ARM64.
The feature has been available and enabled on x86 for a while. It
is beneficial when the number of dirty pages is small in a checkpointing
system or live migration scenario. More details can be found from
fb04a1eddb1a ("KVM: X86: Implement ring-based dirty memory tracking").

This series is applied on top of Marc's v2 series [0], fixing dirty-ring
ordering issue. This series is going to land on v6.1.rc0 pretty soon.

[0] https://lore.kernel.org/kvmarm/20220926145120.27974-1-maz@kernel.org

v5: https://lore.kernel.org/all/20221005004154.83502-1-gshan@redhat.com/
v4: https://lore.kernel.org/kvmarm/20220927005439.21130-1-gshan@redhat.com/
v3: https://lore.kernel.org/r/20220922003214.276736-1-gshan@redhat.com
v2: https://lore.kernel.org/lkml/YyiV%2Fl7O23aw5aaO@xz-m1.local/T/
v1: https://lore.kernel.org/lkml/20220819005601.198436-1-gshan@redhat.com

Testing
=======
(1) kvm/selftests/dirty_log_test
(2) Live migration by QEMU

Changelog
=========
v6:
  * Add CONFIG_HAVE_KVM_DIRTY_RING_WITH_BITMAP, for arm64
    to advertise KVM_CAP_DIRTY_RING_WITH_BITMAP in
    PATCH[v6 3/8]                                              (Oliver/Peter)
  * Add helper kvm_dirty_ring_exclusive() to check if
    traditional bitmap-based dirty log tracking is
    exclusive to dirty-ring in PATCH[v6 3/8]                   (Peter)
  * Enable KVM_CAP_DIRTY_RING_WITH_BITMAP in PATCH[v6 5/8]     (Gavin)
v5:
  * Drop empty stub kvm_dirty_ring_check_request()             (Marc/Peter)
  * Add PATCH[v5 3/7] to allow using bitmap, indicated by
    KVM_CAP_DIRTY_LOG_RING_ALLOW_BITMAP                        (Marc/Peter)
v4:
  * Commit log improvement                                     (Marc)
  * Add helper kvm_dirty_ring_check_request()                  (Marc)
  * Drop ifdef for kvm_cpu_dirty_log_size()                    (Marc)
v3:
  * Check KVM_REQ_RING_SOFT_RULL inside kvm_request_pending()  (Peter)
  * Move declaration of kvm_cpu_dirty_log_size()               (test-robot)
v2:
  * Introduce KVM_REQ_RING_SOFT_FULL                           (Marc)
  * Changelog improvement                                      (Marc)
  * Fix dirty_log_test without knowing host page size          (Drew)

Gavin Shan (8):
  KVM: x86: Introduce KVM_REQ_RING_SOFT_FULL
  KVM: x86: Move declaration of kvm_cpu_dirty_log_size() to
    kvm_dirty_ring.h
  KVM: Add support for using dirty ring in conjunction with bitmap
  KVM: arm64: Enable ring-based dirty memory tracking
  KVM: selftests: Enable KVM_CAP_DIRTY_LOG_RING_WITH_BITMAP if possible
  KVM: selftests: Use host page size to map ring buffer in
    dirty_log_test
  KVM: selftests: Clear dirty ring states between two modes in
    dirty_log_test
  KVM: selftests: Automate choosing dirty ring size in dirty_log_test

 Documentation/virt/kvm/api.rst               | 19 ++++---
 arch/arm64/include/uapi/asm/kvm.h            |  1 +
 arch/arm64/kvm/Kconfig                       |  2 +
 arch/arm64/kvm/arm.c                         |  3 ++
 arch/x86/include/asm/kvm_host.h              |  2 -
 arch/x86/kvm/x86.c                           | 15 +++---
 include/linux/kvm_dirty_ring.h               | 15 +++---
 include/linux/kvm_host.h                     |  2 +
 include/uapi/linux/kvm.h                     |  1 +
 tools/testing/selftests/kvm/dirty_log_test.c | 53 ++++++++++++++------
 tools/testing/selftests/kvm/lib/kvm_util.c   |  5 +-
 virt/kvm/Kconfig                             |  8 +++
 virt/kvm/dirty_ring.c                        | 24 ++++++++-
 virt/kvm/kvm_main.c                          | 34 +++++++++----
 14 files changed, 132 insertions(+), 52 deletions(-)

Comments

Gavin Shan Oct. 11, 2022, 6:23 a.m. UTC | #1
On 10/11/22 2:14 PM, Gavin Shan wrote:
> This series enables the ring-based dirty memory tracking for ARM64.
> The feature has been available and enabled on x86 for a while. It
> is beneficial when the number of dirty pages is small in a checkpointing
> system or live migration scenario. More details can be found from
> fb04a1eddb1a ("KVM: X86: Implement ring-based dirty memory tracking").
> 
> This series is applied on top of Marc's v2 series [0], fixing dirty-ring
> ordering issue. This series is going to land on v6.1.rc0 pretty soon.
> 
> [0] https://lore.kernel.org/kvmarm/20220926145120.27974-1-maz@kernel.org
> 
> v5: https://lore.kernel.org/all/20221005004154.83502-1-gshan@redhat.com/
> v4: https://lore.kernel.org/kvmarm/20220927005439.21130-1-gshan@redhat.com/
> v3: https://lore.kernel.org/r/20220922003214.276736-1-gshan@redhat.com
> v2: https://lore.kernel.org/lkml/YyiV%2Fl7O23aw5aaO@xz-m1.local/T/
> v1: https://lore.kernel.org/lkml/20220819005601.198436-1-gshan@redhat.com
> 
> Testing
> =======
> (1) kvm/selftests/dirty_log_test
> (2) Live migration by QEMU
> 
> Changelog
> =========
> v6:
>    * Add CONFIG_HAVE_KVM_DIRTY_RING_WITH_BITMAP, for arm64
>      to advertise KVM_CAP_DIRTY_RING_WITH_BITMAP in
>      PATCH[v6 3/8]                                              (Oliver/Peter)
>    * Add helper kvm_dirty_ring_exclusive() to check if
>      traditional bitmap-based dirty log tracking is
>      exclusive to dirty-ring in PATCH[v6 3/8]                   (Peter)
>    * Enable KVM_CAP_DIRTY_RING_WITH_BITMAP in PATCH[v6 5/8]     (Gavin)
> v5:
>    * Drop empty stub kvm_dirty_ring_check_request()             (Marc/Peter)
>    * Add PATCH[v5 3/7] to allow using bitmap, indicated by
>      KVM_CAP_DIRTY_LOG_RING_ALLOW_BITMAP                        (Marc/Peter)
> v4:
>    * Commit log improvement                                     (Marc)
>    * Add helper kvm_dirty_ring_check_request()                  (Marc)
>    * Drop ifdef for kvm_cpu_dirty_log_size()                    (Marc)
> v3:
>    * Check KVM_REQ_RING_SOFT_RULL inside kvm_request_pending()  (Peter)
>    * Move declaration of kvm_cpu_dirty_log_size()               (test-robot)
> v2:
>    * Introduce KVM_REQ_RING_SOFT_FULL                           (Marc)
>    * Changelog improvement                                      (Marc)
>    * Fix dirty_log_test without knowing host page size          (Drew)
> 
> Gavin Shan (8):
>    KVM: x86: Introduce KVM_REQ_RING_SOFT_FULL
>    KVM: x86: Move declaration of kvm_cpu_dirty_log_size() to
>      kvm_dirty_ring.h
>    KVM: Add support for using dirty ring in conjunction with bitmap
>    KVM: arm64: Enable ring-based dirty memory tracking
>    KVM: selftests: Enable KVM_CAP_DIRTY_LOG_RING_WITH_BITMAP if possible
>    KVM: selftests: Use host page size to map ring buffer in
>      dirty_log_test
>    KVM: selftests: Clear dirty ring states between two modes in
>      dirty_log_test
>    KVM: selftests: Automate choosing dirty ring size in dirty_log_test
> 
>   Documentation/virt/kvm/api.rst               | 19 ++++---
>   arch/arm64/include/uapi/asm/kvm.h            |  1 +
>   arch/arm64/kvm/Kconfig                       |  2 +
>   arch/arm64/kvm/arm.c                         |  3 ++
>   arch/x86/include/asm/kvm_host.h              |  2 -
>   arch/x86/kvm/x86.c                           | 15 +++---
>   include/linux/kvm_dirty_ring.h               | 15 +++---
>   include/linux/kvm_host.h                     |  2 +
>   include/uapi/linux/kvm.h                     |  1 +
>   tools/testing/selftests/kvm/dirty_log_test.c | 53 ++++++++++++++------
>   tools/testing/selftests/kvm/lib/kvm_util.c   |  5 +-
>   virt/kvm/Kconfig                             |  8 +++
>   virt/kvm/dirty_ring.c                        | 24 ++++++++-
>   virt/kvm/kvm_main.c                          | 34 +++++++++----
>   14 files changed, 132 insertions(+), 52 deletions(-)
> 

It seems Oliver and Sean were missed in the loop, even though I explicitly
copied them by git-send-email. Amend to include them.

Thanks,
Gavin