mbox series

[00/14] KVM: x86: Remove unnecessary exported symbols

Message ID 20221114095606.39785-1-likexu@tencent.com (mailing list archive)
Headers show
Series KVM: x86: Remove unnecessary exported symbols | expand

Message

Like Xu Nov. 14, 2022, 9:55 a.m. UTC 
Inspired by the Sean's minor fix [1], more unnecessary (from a GPL
developer's perspective) exported symbols could be cleaned up
(automation to find out true positives is possible). This move helps reduce
the attack surface of KVM modules and guides more developers to practice
the principle of low coupling in the KVM context.

[1] https://lore.kernel.org/kvm/20221110010354.1342128-1-seanjc@google.com/

Like Xu (13):
  KVM: x86: Remove unnecessary export of kvm_inject_pending_timer_irqs()
  KVM: x86: Remove unnecessary export of kvm_get_apic_base()
  KVM: x86: Remove unnecessary export of kvm_set_apic_base()
  KVM: x86: Remove unnecessary export of kvm_inject_page_fault()
  KVM: x86: Remove unnecessary export of kvm_inject_nmi()
  KVM: x86: Remove unnecessary export of kvm_require_cpl()
  KVM: x86: Remove unnecessary export of kvm_emulate_as_nop()
  KVM: x86: Remove unnecessary export of kvm_scale_tsc()
  KVM: x86: Remove unnecessary export of kvm_vcpu_is_reset_bsp()
  KVM: x86: Remove unnecessary export of kvm_hv_assist_page_enabled()
  KVM: x86: Remove unnecessary export of kvm_can_use_hv_timer()
  KVM: x86: Remove unnecessary export of kvm_lapic_hv_timer_in_use()
  KVM: x86: Remove unnecessary export of kvm_apic_update_apicv()

Sean Christopherson (1):
  KVM: x86: Remove unnecessary export of kvm_cpu_has_pending_timer()

 arch/x86/kvm/hyperv.c |  1 -
 arch/x86/kvm/irq.c    |  2 --
 arch/x86/kvm/lapic.c  |  3 ---
 arch/x86/kvm/x86.c    | 18 +++++-------------
 arch/x86/kvm/x86.h    |  2 ++
 5 files changed, 7 insertions(+), 19 deletions(-)

Comments

Paolo Bonzini Dec. 2, 2022, 6:37 p.m. UTC | #1 
On 11/14/22 10:55, Like Xu wrote:
> Inspired by the Sean's minor fix [1], more unnecessary (from a GPL
> developer's perspective) exported symbols could be cleaned up
> (automation to find out true positives is possible). This move helps reduce
> the attack surface of KVM modules and guides more developers to practice
> the principle of low coupling in the KVM context.
> 
> [1] https://lore.kernel.org/kvm/20221110010354.1342128-1-seanjc@google.com/

I'll squash everything in a single patch and limit the change to just 
removing EXPORT_SYMBOL_GPL().

Paolo

> Like Xu (13):
>    KVM: x86: Remove unnecessary export of kvm_inject_pending_timer_irqs()
>    KVM: x86: Remove unnecessary export of kvm_get_apic_base()
>    KVM: x86: Remove unnecessary export of kvm_set_apic_base()
>    KVM: x86: Remove unnecessary export of kvm_inject_page_fault()
>    KVM: x86: Remove unnecessary export of kvm_inject_nmi()
>    KVM: x86: Remove unnecessary export of kvm_require_cpl()
>    KVM: x86: Remove unnecessary export of kvm_emulate_as_nop()
>    KVM: x86: Remove unnecessary export of kvm_scale_tsc()
>    KVM: x86: Remove unnecessary export of kvm_vcpu_is_reset_bsp()
>    KVM: x86: Remove unnecessary export of kvm_hv_assist_page_enabled()
>    KVM: x86: Remove unnecessary export of kvm_can_use_hv_timer()
>    KVM: x86: Remove unnecessary export of kvm_lapic_hv_timer_in_use()
>    KVM: x86: Remove unnecessary export of kvm_apic_update_apicv()
> 
> Sean Christopherson (1):
>    KVM: x86: Remove unnecessary export of kvm_cpu_has_pending_timer()
> 
>   arch/x86/kvm/hyperv.c |  1 -
>   arch/x86/kvm/irq.c    |  2 --
>   arch/x86/kvm/lapic.c  |  3 ---
>   arch/x86/kvm/x86.c    | 18 +++++-------------
>   arch/x86/kvm/x86.h    |  2 ++
>   5 files changed, 7 insertions(+), 19 deletions(-)
>