[PATCH-for-8.0,0/4] ppc: Clean up few headers to make them target agnostic

Message

Philippe Mathieu-Daudé Dec. 13, 2022, 12:35 p.m. UTC

Few changes in hw/ & target/ to reduce the target specificity
of some sPAPR headers.

Philippe Mathieu-Daudé (4):
  target/ppc/kvm: Add missing "cpu.h" and "exec/hwaddr.h"
  hw/ppc/vof: Do not include the full "cpu.h"
  hw/ppc/spapr: Reduce "vof.h" inclusion
  hw/ppc/spapr_ovec: Avoid target_ulong spapr_ovec_parse_vector()

 hw/ppc/spapr.c              | 1 +
 hw/ppc/spapr_ovec.c         | 3 ++-
 include/hw/ppc/spapr.h      | 3 ++-
 include/hw/ppc/spapr_ovec.h | 4 ++--
 include/hw/ppc/vof.h        | 2 +-
 target/ppc/kvm_ppc.h        | 3 +++
 6 files changed, 11 insertions(+), 5 deletions(-)

Comments

Daniel Henrique Barboza Dec. 16, 2022, 4:54 p.m. UTC | #1

On 12/13/22 09:35, Philippe Mathieu-Daudé wrote:
> Few changes in hw/ & target/ to reduce the target specificity
> of some sPAPR headers.
> 
> Philippe Mathieu-Daudé (4):
>    target/ppc/kvm: Add missing "cpu.h" and "exec/hwaddr.h"
>    hw/ppc/vof: Do not include the full "cpu.h"
>    hw/ppc/spapr: Reduce "vof.h" inclusion
>    hw/ppc/spapr_ovec: Avoid target_ulong spapr_ovec_parse_vector()

Patches 1-3 queued in https://gitlab.com/danielhb/qemu/tree/ppc-next. Patch
4 can use a few more comments.


Thanks,


Daniel

> 
>   hw/ppc/spapr.c              | 1 +
>   hw/ppc/spapr_ovec.c         | 3 ++-
>   include/hw/ppc/spapr.h      | 3 ++-
>   include/hw/ppc/spapr_ovec.h | 4 ++--
>   include/hw/ppc/vof.h        | 2 +-
>   target/ppc/kvm_ppc.h        | 3 +++
>   6 files changed, 11 insertions(+), 5 deletions(-)
>

Philippe Mathieu-Daudé Dec. 16, 2022, 8:32 p.m. UTC | #2

On 16/12/22 17:54, Daniel Henrique Barboza wrote:
> 
> 
> On 12/13/22 09:35, Philippe Mathieu-Daudé wrote:
>> Few changes in hw/ & target/ to reduce the target specificity
>> of some sPAPR headers.
>>
>> Philippe Mathieu-Daudé (4):
>>    target/ppc/kvm: Add missing "cpu.h" and "exec/hwaddr.h"
>>    hw/ppc/vof: Do not include the full "cpu.h"
>>    hw/ppc/spapr: Reduce "vof.h" inclusion
>>    hw/ppc/spapr_ovec: Avoid target_ulong spapr_ovec_parse_vector()
> 
> Patches 1-3 queued in https://gitlab.com/danielhb/qemu/tree/ppc-next.

Thanks!

> Patch 4 can use a few more comments.

Yes, I'm not sure yet how to improve it, but I'll work on it.

Regards,

Phil.