Message ID | 20230202182809.1929122-1-bgardon@google.com (mailing list archive) |
---|---|
Headers | show |
Series | KVM: x86/MMU: Formalize the Shadow MMU | expand |
On Thu, Feb 02, 2023, Ben Gardon wrote: > Patches 4-6 prepare for the refactor by adding files and exporting > functions. For future reference, please do not conflate "export" with "make globally visible" (here and in many of the changelogs). The distinction matters, especially for modules, as an exported symbol is quite different than a globally visible symbol. We (sadly) lose sight of this in KVM far too often due kvm.ko exporting an asburd number of symbols for kvm-{amd,intel}.ko, and as a result we've ended up with non-KVM code using helpers that realy should be KVM-only. This is something I hope to remedy in the near-ish future, and so I want us to start getting the terminology right.
On Thu, 02 Feb 2023 18:27:48 +0000, Ben Gardon wrote: > This series makes the Shadow MMU a distinct part of the KVM x86 MMU, > implemented in separate files, with a defined interface to common code. > > When the TDP (Two Dimensional Paging) MMU was added to x86 KVM, it came in > a separate file with a (reasonably) clear interface. This lead to many > points in the KVM MMU like this: > > [...] Applied the first three to kvm-x86 mmu, which just makes me look like a jerk since they're all my patches. :-( [01/21] KVM: x86/mmu: Rename slot rmap walkers to add clarity and clean up code https://github.com/kvm-x86/linux/commit/727ae3770132 [02/21] KVM: x86/mmu: Replace comment with an actual lockdep assertion on mmu_lock https://github.com/kvm-x86/linux/commit/eddd9e8302de [03/21] KVM: x86/mmu: Clean up mmu.c functions that put return type on separate line https://github.com/kvm-x86/linux/commit/f3d90f901d18 -- https://github.com/kvm-x86/linux/tree/next https://github.com/kvm-x86/linux/tree/fixes