mbox series

[v1,0/2] KVM: s390: CMMA migration selftest and small bugfix

Message ID 20230208144827.131300-1-nrb@linux.ibm.com (mailing list archive)
Headers show
Series KVM: s390: CMMA migration selftest and small bugfix | expand

Message

Nico Boehr Feb. 8, 2023, 2:48 p.m. UTC 
Add a new selftest for CMMA migration. Also fix a small issue found during
development of the test.

Nico Boehr (2):
  KVM: s390: selftests: add selftest for CMMA migration
  KVM: s390: fix KVM_S390_GET_CMMA_BITS for GFNs in memslot holes

 arch/s390/kvm/kvm-s390.c                      |   4 +
 tools/testing/selftests/kvm/Makefile          |   1 +
 tools/testing/selftests/kvm/s390x/cmma_test.c | 679 ++++++++++++++++++
 3 files changed, 684 insertions(+)
 create mode 100644 tools/testing/selftests/kvm/s390x/cmma_test.c

Comments

Nico Boehr March 22, 2023, 3 p.m. UTC | #1 
Quoting Nico Boehr (2023-02-08 15:48:25)
> Add a new selftest for CMMA migration. Also fix a small issue found during
> development of the test.
> 
> Nico Boehr (2):
>   KVM: s390: selftests: add selftest for CMMA migration
>   KVM: s390: fix KVM_S390_GET_CMMA_BITS for GFNs in memslot holes
> 
>  arch/s390/kvm/kvm-s390.c                      |   4 +
>  tools/testing/selftests/kvm/Makefile          |   1 +
>  tools/testing/selftests/kvm/s390x/cmma_test.c | 679 ++++++++++++++++++
>  3 files changed, 684 insertions(+)
>  create mode 100644 tools/testing/selftests/kvm/s390x/cmma_test.c

Polite ping.
Claudio Imbrenda March 22, 2023, 3:06 p.m. UTC | #2 
On Wed, 22 Mar 2023 16:00:38 +0100
Nico Boehr <nrb@linux.ibm.com> wrote:

> Quoting Nico Boehr (2023-02-08 15:48:25)
> > Add a new selftest for CMMA migration. Also fix a small issue found during
> > development of the test.
> > 
> > Nico Boehr (2):
> >   KVM: s390: selftests: add selftest for CMMA migration
> >   KVM: s390: fix KVM_S390_GET_CMMA_BITS for GFNs in memslot holes
> > 
> >  arch/s390/kvm/kvm-s390.c                      |   4 +
> >  tools/testing/selftests/kvm/Makefile          |   1 +
> >  tools/testing/selftests/kvm/s390x/cmma_test.c | 679 ++++++++++++++++++
> >  3 files changed, 684 insertions(+)
> >  create mode 100644 tools/testing/selftests/kvm/s390x/cmma_test.c  
> 
> Polite ping.

oops this had fallen off my radar

I'll have a look at it ASAP
Claudio Imbrenda March 23, 2023, 2:38 p.m. UTC | #3 
On Wed,  8 Feb 2023 15:48:25 +0100
Nico Boehr <nrb@linux.ibm.com> wrote:

> Add a new selftest for CMMA migration. Also fix a small issue found during
> development of the test.
> 
> Nico Boehr (2):
>   KVM: s390: selftests: add selftest for CMMA migration
>   KVM: s390: fix KVM_S390_GET_CMMA_BITS for GFNs in memslot holes
> 
>  arch/s390/kvm/kvm-s390.c                      |   4 +
>  tools/testing/selftests/kvm/Makefile          |   1 +
>  tools/testing/selftests/kvm/s390x/cmma_test.c | 679 ++++++++++++++++++
>  3 files changed, 684 insertions(+)
>  create mode 100644 tools/testing/selftests/kvm/s390x/cmma_test.c
> 

the series looks good in general, but I would swap the order and have
the fix first, and the tests after
Nico Boehr March 24, 2023, 1:32 p.m. UTC | #4 
Quoting Claudio Imbrenda (2023-03-23 15:38:03)
> On Wed,  8 Feb 2023 15:48:25 +0100
> Nico Boehr <nrb@linux.ibm.com> wrote:
> 
> > Add a new selftest for CMMA migration. Also fix a small issue found during
> > development of the test.
> > 
> > Nico Boehr (2):
> >   KVM: s390: selftests: add selftest for CMMA migration
> >   KVM: s390: fix KVM_S390_GET_CMMA_BITS for GFNs in memslot holes
> > 
> >  arch/s390/kvm/kvm-s390.c                      |   4 +
> >  tools/testing/selftests/kvm/Makefile          |   1 +
> >  tools/testing/selftests/kvm/s390x/cmma_test.c | 679 ++++++++++++++++++
> >  3 files changed, 684 insertions(+)
> >  create mode 100644 tools/testing/selftests/kvm/s390x/cmma_test.c
> > 
> 
> the series looks good in general, but I would swap the order and have
> the fix first, and the tests after

Sure can swap the order in v2.