From patchwork Tue Mar 28 16:02:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 13191323 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33441C761AF for ; Tue, 28 Mar 2023 16:02:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233305AbjC1QCU (ORCPT ); Tue, 28 Mar 2023 12:02:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233029AbjC1QCQ (ORCPT ); Tue, 28 Mar 2023 12:02:16 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D107AE184 for ; Tue, 28 Mar 2023 09:02:08 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id q7-20020a05600c46c700b003ef6e809574so4570694wmo.4 for ; Tue, 28 Mar 2023 09:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680019327; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NmsSjup+xEQ0gc2TIeG2hC6j/mKEA8p4JNIyDCKCDnk=; b=TXS+Ym0GCybLQ+ER+7Oa64F9rrGVRrgJJHHwtCwuS35WZ4qfoTxmWr9K11Xw/xLIvC HyxDht7nCxqWeRQn1c1jnzfl4FIZs5Ue0uZY5GHM0kvyX4ai9P/BjvtiQVoHf+gEuaS+ vffYGdeuaiGR7ecdBjMu0x0rXTwgv3MukciKmf7Ne52JOIHM8mNxZIDRZ7Gh8ZYeQcWO lzeM6dSuSYR1E02pRPkzet5emj1HYJk5xqrlMEhfihx2P1itD0KWD1HlqqDIeVUoMkhE pOhST29TgROk1lCDEy6wQ5b9G2A5T/uG2wGWxO/ZDPuPfSBsc7NugKZoE1BAtT8x9K/s IXYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680019327; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NmsSjup+xEQ0gc2TIeG2hC6j/mKEA8p4JNIyDCKCDnk=; b=ZIniQaAZCzBrnlrKs47yZZ+ULRfIw/ihC2qLwBz6P/E6dIkvWND02e+aSb5uDk/qkM iGUMHHRlz9N8R6ERBpykNsu/eB/Qf/FsTN+xoB8c599FMdE1nRBk1+VN+JeoA2PYePMV CP1tLLXW5aGpO4bIHiZcPgxn9CbhdYi6grtxPfeI8fH+j9oS92cEy5k1yBvZyu5r+/SH 7znfH+txH9x2NDi6JjQqhdrwUfkc59lhqt56WRg24zWJuuhCLr352Fn6sDCqA0EMW/rQ cpDy8Jj6C1/W/1bkrUEyuaWfkeAv+vwOV1XWuWm8rYzQ9op0JlMmczIsulfDPw7xj0ZE 99Mg== X-Gm-Message-State: AO0yUKUWo7jvbaWD3XJ2SfXkTgGIZWD/hUq4UPanZPCwgrScNnrJ5pwa 1CBfKsjOG7h5ygxXcnXILNFzOA== X-Google-Smtp-Source: AK7set9QdPz+EVC4C8quH18Yt0Nyoa2yv+ZsJ7j72om3axKiVorYuqs2XM+85Et9x6gjQRM3bWSGKA== X-Received: by 2002:a7b:ce08:0:b0:3ee:da1:135f with SMTP id m8-20020a7bce08000000b003ee0da1135fmr12778012wmc.7.1680019327311; Tue, 28 Mar 2023 09:02:07 -0700 (PDT) Received: from localhost.localdomain ([176.187.210.212]) by smtp.gmail.com with ESMTPSA id hg13-20020a05600c538d00b003ed793d9de0sm2937626wmb.1.2023.03.28.09.02.05 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 28 Mar 2023 09:02:06 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Eduardo Habkost , kvm@vger.kernel.org, qemu-s390x@nongnu.org, Fabiano Rosas , David Hildenbrand , Marcel Apfelbaum , Paolo Bonzini , Greg Kurz , Christian Borntraeger , Thomas Huth , Peter Maydell , Richard Henderson , Ilya Leoshkevich , Halil Pasic , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Daniel Henrique Barboza , David Gibson , Yanan Wang , qemu-ppc@nongnu.org, =?utf-8?q?Alex_Be?= =?utf-8?q?nn=C3=A9e?= , qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH-for-8.0 0/3] softmmu: Restore use of CPU watchpoint for non-TCG accelerators Date: Tue, 28 Mar 2023 18:02:00 +0200 Message-Id: <20230328160203.13510-1-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Commit 2609ec2868 ("softmmu: Extract watchpoint API from physmem.c") restricted CPU watchpoints to TCG accelerator. This is wrong, as other accelerators such KVM do use watchpoints. Revert (partially) this commit. https://lore.kernel.org/qemu-devel/4784948c-1a92-1991-d6a2-b4d1ee23136c@redhat.com/ Philippe Mathieu-Daudé (3): softmmu/watchpoint: Add missing 'qemu/error-report.h' include softmmu: Restrict cpu_check_watchpoint / address_matches to TCG accel softmmu: Restore use of CPU watchpoint for all accelerators include/hw/core/cpu.h | 39 +------------------------------ include/hw/core/tcg-cpu-ops.h | 43 +++++++++++++++++++++++++++++++++++ softmmu/watchpoint.c | 5 ++++ softmmu/meson.build | 2 +- 4 files changed, 50 insertions(+), 39 deletions(-)