| Message ID | 20230426145419.450922-1-yi.l.liu@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Enhance vfio PCI hot reset for vfio cdev device | expand |
> From: Liu, Yi L <yi.l.liu@intel.com> > Sent: Wednesday, April 26, 2023 10:54 PM > > VFIO_DEVICE_PCI_HOT_RESET requires user to pass an array of group fds > to prove that it owns all devices affected by resetting the calling > device. While for cdev devices, user can use an iommufd-based ownership > checking model and invoke VFIO_DEVICE_PCI_HOT_RESET with a zero-length > fd array. > > This series first creates iommufd_access for noiommu devices to fill the > gap for adding iommufd-based ownership checking model, then extends > VFIO_DEVICE_GET_PCI_HOT_RESET_INFO to check ownership and return the > check result and the devid of affected devices to user. In the end, extends > the VFIO_DEVICE_PCI_HOT_RESET to accept zero-length fd array for hot-reset > with cdev devices. > > The new hot reset method and updated _INFO ioctl are tested with the > below qemu: > > https://github.com/yiliu1765/qemu/tree/iommufd_rfcv4.mig.reset.v4_var3 > (requires to test with the cdev kernel) The cdev kernel is below branch, this series is part of below branch. https://github.com/yiliu1765/iommufd/tree/vfio_device_cdev_v10 Regards, Yi Liu
> VFIO_DEVICE_PCI_HOT_RESET requires user to pass an array of group fds to > prove that it owns all devices affected by resetting the calling device. While for > cdev devices, user can use an iommufd-based ownership checking model and > invoke VFIO_DEVICE_PCI_HOT_RESET with a zero-length fd array. > > This series first creates iommufd_access for noiommu devices to fill the gap for > adding iommufd-based ownership checking model, then extends > VFIO_DEVICE_GET_PCI_HOT_RESET_INFO to check ownership and return the > check result and the devid of affected devices to user. In the end, extends the > VFIO_DEVICE_PCI_HOT_RESET to accept zero-length fd array for hot-reset with > cdev devices. > > The new hot reset method and updated _INFO ioctl are tested with the below > qemu: > > https://github.com/yiliu1765/qemu/tree/iommufd_rfcv4.mig.reset.v4_var3 > (requires to test with the cdev kernel) > Tested NIC passthrough on Intel platform. Result looks good hence, Tested-by: Yanting Jiang <yanting.jiang@intel.com> Thanks, Yanting
VFIO_DEVICE_PCI_HOT_RESET requires user to pass an array of group fds to prove that it owns all devices affected by resetting the calling device. While for cdev devices, user can use an iommufd-based ownership checking model and invoke VFIO_DEVICE_PCI_HOT_RESET with a zero-length fd array. This series first creates iommufd_access for noiommu devices to fill the gap for adding iommufd-based ownership checking model, then extends VFIO_DEVICE_GET_PCI_HOT_RESET_INFO to check ownership and return the check result and the devid of affected devices to user. In the end, extends the VFIO_DEVICE_PCI_HOT_RESET to accept zero-length fd array for hot-reset with cdev devices. The new hot reset method and updated _INFO ioctl are tested with the below qemu: https://github.com/yiliu1765/qemu/tree/iommufd_rfcv4.mig.reset.v4_var3 (requires to test with the cdev kernel) Change log: v4: - Rename the patch series subject - Patch 01 is moved from the cdev series - Patch 02, 06 are new per review comments in v3 - Patch 03/04/05/07/08/09 are from v3 with updates v3: https://lore.kernel.org/kvm/20230401144429.88673-1-yi.l.liu@intel.com/ - Remove the new _INFO ioctl of v2, extend the existing _INFO ioctl to report devid (Alex) - Add r-b from Jason - Add t-b from Terrence Xu and Yanting Jiang (mainly regression test) v2: https://lore.kernel.org/kvm/20230327093458.44939-1-yi.l.liu@intel.com/ - Split the patch 03 of v1 to be 03, 04 and 05 of v2 (Jaon) - Add r-b from Kevin and Jason - Add patch 10 to introduce a new _INFO ioctl for the usage of device fd passing usage in cdev path (Jason, Alex) v1: https://lore.kernel.org/kvm/20230316124156.12064-1-yi.l.liu@intel.com/ Regards, Yi Liu Yi Liu (9): vfio: Determine noiommu in vfio_device registration vfio-iommufd: Create iommufd_access for noiommu devices vfio/pci: Update comment around group_fd get in vfio_pci_ioctl_pci_hot_reset() vfio/pci: Move the existing hot reset logic to be a helper vfio: Mark cdev usage in vfio_device iommufd: Reserved -1 in the iommufd xarray vfio-iommufd: Add helper to retrieve iommufd_ctx and devid for vfio_device vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET drivers/iommu/iommufd/device.c | 24 ++++ drivers/iommu/iommufd/main.c | 5 +- drivers/vfio/iommufd.c | 48 +++++-- drivers/vfio/pci/vfio_pci_core.c | 223 +++++++++++++++++++++++++------ drivers/vfio/vfio.h | 7 +- drivers/vfio/vfio_main.c | 4 + include/linux/iommufd.h | 6 + include/linux/vfio.h | 22 +++ include/uapi/linux/vfio.h | 61 ++++++++- 9 files changed, 347 insertions(+), 53 deletions(-)