[kvmtool,0/2] vfio/pci: Fix unmaskable MSI

Message

Jean-Philippe Brucker June 28, 2023, 11:23 a.m. UTC

Patch 1 fixes an issue reported by Vivek, when assigning a device that
supports classic MSI without maskable vectors.

Patch 2 adds some comments and renames the states, because the MSI code
is difficult to understand. I haven't found a way to simplify it but
this should at least help people debug it.

Jean-Philippe Brucker (2):
  vfio/pci: Initialize MSI vectors unmasked
  vfio/pci: Clarify the MSI states

 include/kvm/vfio.h |  8 ++---
 vfio/pci.c         | 86 ++++++++++++++++++++++++++++------------------
 2 files changed, 57 insertions(+), 37 deletions(-)

Comments

Will Deacon July 6, 2023, 2:36 p.m. UTC | #1

On Wed, 28 Jun 2023 12:23:30 +0100, Jean-Philippe Brucker wrote:
> Patch 1 fixes an issue reported by Vivek, when assigning a device that
> supports classic MSI without maskable vectors.
> 
> Patch 2 adds some comments and renames the states, because the MSI code
> is difficult to understand. I haven't found a way to simplify it but
> this should at least help people debug it.
> 
> [...]

Applied to kvmtool (master), thanks!

[1/2] vfio/pci: Initialize MSI vectors unmasked
      https://git.kernel.org/will/kvmtool/c/3a36d3410e99
[2/2] vfio/pci: Clarify the MSI states
      https://git.kernel.org/will/kvmtool/c/0b5e55fc032d

Cheers,