From patchwork Sat Aug 26 17:58:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arseniy Krasnov X-Patchwork-Id: 13366642 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE888C83F01 for ; Sat, 26 Aug 2023 18:06:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230500AbjHZSFz (ORCPT ); Sat, 26 Aug 2023 14:05:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230207AbjHZSFc (ORCPT ); Sat, 26 Aug 2023 14:05:32 -0400 Received: from mx1.sberdevices.ru (mx2.sberdevices.ru [45.89.224.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0253BE6B; Sat, 26 Aug 2023 11:05:28 -0700 (PDT) Received: from p-infra-ksmg-sc-msk02 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 9C30E120007; Sat, 26 Aug 2023 21:05:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 9C30E120007 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1693073124; bh=DZ63VY+riAS2OjANpg4EYNb3j25oD5i1PQmJd4MbmdU=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=hh2HFu9IMfn51laUllJx0ig/R/SCZqmXj35rWWyE4C4zK1LG3uzU4CP3SzweMgnf8 PwACs1LB5XclQzBAYTzmISi7cJxgS5cAqVIrwOkuccZFVu38v5wTXsKYKrC3GmAiUl fb+iYpe/0vTuxDX4ICZ32kWJEY1yMvn/JaEkE79aEBWzHYhQfNYyItmZm7gGhvBxPP yRjMcd5FO9egWobeIaIU6ijyPrDUtqS2iorAJOt7p1LhnQaKUzVaJ8nAWWp0b8hNPu SzrVVweXfs3anyg7+qGC0TM1ktvtldvGkJj5cH8erW83dUsaoGEPvLmfj+EoWmM/0c 2VeBfS7Me/i+g== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Sat, 26 Aug 2023 21:05:24 +0300 (MSK) Received: from localhost.localdomain (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Sat, 26 Aug 2023 21:05:08 +0300 From: Arseniy Krasnov To: Stefan Hajnoczi , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Michael S. Tsirkin" , Jason Wang , Bobby Eshleman CC: , , , , , , Subject: [RFC PATCH v2 0/2] vsock: handle writes to shutdowned socket Date: Sat, 26 Aug 2023 20:58:58 +0300 Message-ID: <20230826175900.3693844-1-avkrasnov@salutedevices.com> X-Mailer: git-send-email 2.35.0 MIME-Version: 1.0 X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 179455 [Aug 25 2023] X-KSMG-AntiSpam-Version: 5.9.59.0 X-KSMG-AntiSpam-Envelope-From: avkrasnov@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 527 527 5bb611be2ca2baa31d984ccbf4ef4415504fc308, {Tracking_uf_ne_domains}, {Tracking_from_domain_doesnt_match_to}, salutedevices.com:7.1.1;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;100.64.160.123:7.1.2;lore.kernel.org:7.1.1;git.kernel.org:7.1.1;p-i-exch-sc-m01.sberdevices.ru:7.1.1,5.0.1, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean, bases: 2023/08/26 16:57:00 X-KSMG-LinksScanning: Clean, bases: 2023/08/26 16:57:00 X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/08/26 15:09:00 #21728460 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hello, this small patchset adds POSIX compliant behaviour on writes to the socket which was shutdowned with 'shutdown()' (both sides - local with SHUT_WR flag, peer - with SHUT_RD flag). According POSIX we must send SIGPIPE in such cases (but SIGPIPE is not send when MSG_NOSIGNAL is set). First patch is implemented in the same way as net/ipv4/tcp.c:tcp_sendmsg_locked(). It uses 'sk_stream_error()' function which handles EPIPE error. Another way is to use code from net/unix/af_unix.c:unix_stream_sendmsg() where same logic from 'sk_stream_error()' is implemented "from scratch", but it doesn't check 'sk_err' field. I think error from this field has more priority to be returned from syscall. So I guess it is better to reuse currently implemented 'sk_stream_error()' function. Test is also added. Head for this patchset is: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=b38460bc463c54e0c15ff3b37e81f7e2059bb9bb Link to v1: https://lore.kernel.org/netdev/20230801141727.481156-1-AVKrasnov@sberdevices.ru/ Changelog: v1 -> v2: * 0001 stills the same - SIGPIPE is sent only for SOCK_STREAM as discussed in v1 with Stefano Garzarella . * 0002 - use 'sig_atomic_t' instead of 'bool' for flag variables updated from signal handler. Arseniy Krasnov (2): vsock: send SIGPIPE on write to shutdowned socket test/vsock: shutdowned socket test net/vmw_vsock/af_vsock.c | 3 + tools/testing/vsock/vsock_test.c | 138 +++++++++++++++++++++++++++++++ 2 files changed, 141 insertions(+)