[0/3] KVM: x86 - misc fixes

Message

Mathias Krause Feb. 3, 2024, 12:45 p.m. UTC

This is v2 of an old patch which gained an info leak fix to make it a
series.

v1 -> v2:
- drop the stable cc, shorten commit log
- split out dr6 change
- add KVM_GET_MSRS stack info leak fix

v1: https://lore.kernel.org/kvm/[e-mail]/

Please apply!

Thanks,
Mathias

Mathias Krause (3):
  KVM: x86: Fix KVM_GET_MSRS stack info leak
  KVM: x86: Simplify kvm_vcpu_ioctl_x86_get_debugregs()
  KVM: x86: Fix broken debugregs ABI for 32 bit kernels

 arch/x86/kvm/x86.c | 32 +++++++++++++++++---------------
 1 file changed, 17 insertions(+), 15 deletions(-)

Comments

Sean Christopherson Feb. 5, 2024, 7:56 p.m. UTC | #1

On Sat, Feb 03, 2024, Mathias Krause wrote:
> This is v2 of an old patch which gained an info leak fix to make it a
> series.
> 
> v1 -> v2:
> - drop the stable cc, shorten commit log
> - split out dr6 change
> - add KVM_GET_MSRS stack info leak fix

In the future, please post unrelated patches separately.  Bundling things into a
"misc fixes" series might seem like it's less work for maintainers, but for me at
least, it ends up being more work, e.g. to route patches into different branches.
It often ends up being more work for the contributor too, e.g. if only one patch
needs a new version.

Mathias Krause Feb. 6, 2024, 6:24 p.m. UTC | #2

On 05.02.24 20:56, Sean Christopherson wrote:
> On Sat, Feb 03, 2024, Mathias Krause wrote:
>> This is v2 of an old patch which gained an info leak fix to make it a
>> series.
>>
>> v1 -> v2:
>> - drop the stable cc, shorten commit log
>> - split out dr6 change
>> - add KVM_GET_MSRS stack info leak fix
> 
> In the future, please post unrelated patches separately.  Bundling things into a
> "misc fixes" series might seem like it's less work for maintainers, but for me at
> least, it ends up being more work, e.g. to route patches into different branches.
> It often ends up being more work for the contributor too, e.g. if only one patch
> needs a new version.

That was a little sloppy, agreed. Will do better next time.

Thanks,
Mathias

Sean Christopherson Feb. 6, 2024, 6:52 p.m. UTC | #3

On Sat, 03 Feb 2024 13:45:19 +0100, Mathias Krause wrote:
> This is v2 of an old patch which gained an info leak fix to make it a
> series.
> 
> v1 -> v2:
> - drop the stable cc, shorten commit log
> - split out dr6 change
> - add KVM_GET_MSRS stack info leak fix
> 
> [...]

Applied patch 1 to kvm-x86 fixes (for 6.8), and patch 3 to misc (for 6.9).  As
promised/threatened, I'll send a small series to cleanup the kvm_get_dr() mess.

[1/3] KVM: x86: Fix KVM_GET_MSRS stack info leak
      https://github.com/kvm-x86/linux/commit/3376ca3f1a20
[2/3] KVM: x86: Simplify kvm_vcpu_ioctl_x86_get_debugregs()
      (not applied)
[3/3] KVM: x86: Fix broken debugregs ABI for 32 bit kernels
      https://github.com/kvm-x86/linux/commit/e1dda3afe2a9

--
https://github.com/kvm-x86/linux/tree/next