[kvm-unit-tests,0/2] s390x: run script fixes for PV tests

Message

Nicholas Piggin April 6, 2024, 12:24 p.m. UTC

Shellcheck caught what looks like two bugs. May not have been too
noticable because one just seems like it allows TCG to run PV tests
which fails (and might be guarded out later anyway), and the other
might only affect running and individual .pv.bin test with s390x-run
and not unittests runs.

I don't know about running PV tests or have a system with KVM to try,
so these are not tested beyond gitlab CI. That might run some PV tests
with s390x-kvm, but I don't know so please test/review/ack/nack if
possible.

Thanks,
Nick

Nicholas Piggin (2):
  s390x: Fix misspelt variable name in func.bash
  s390x: Fix is_pv check in run script

 s390x/run               | 8 ++++----
 scripts/s390x/func.bash | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

Comments

Janosch Frank April 8, 2024, 11:23 a.m. UTC | #1

On 4/6/24 14:24, Nicholas Piggin wrote:
> Shellcheck caught what looks like two bugs. May not have been too
> noticable because one just seems like it allows TCG to run PV tests
> which fails (and might be guarded out later anyway), and the other
> might only affect running and individual .pv.bin test with s390x-run
> and not unittests runs.
> 
> I don't know about running PV tests or have a system with KVM to try,
> so these are not tested beyond gitlab CI. That might run some PV tests
> with s390x-kvm, but I don't know so please test/review/ack/nack if
> possible.
> 
> Thanks,
> Nick

Hey Nick, thanks for cleaning this up.
The changes work on my machine and I've thrown them into our CI.

Give me a sec to check the patches itself.