mbox series

[kvm-unit-tests,v1,0/3] s390x: small Makefile improvements

Message ID 20240604115932.86596-1-mhartmay@linux.ibm.com (mailing list archive)
Headers show
Series s390x: small Makefile improvements | expand

Message

Marc Hartmayer June 4, 2024, 11:59 a.m. UTC 
The first patch is useful anyway, the third could be dropped to be consistent
with the other architectures.

Marc Hartmayer (2):
  s390x/Makefile: snippets: Add separate target for the ELF snippets
  s390x/Makefile: snippets: Avoid creation of .eh_frame and
    .eh_frame_hdr sections

Super User (1):
  Revert "s390x: Specify program headers with flags to avoid linker
    warnings"

 s390x/Makefile              | 16 ++++++++++------
 s390x/snippets/c/flat.lds.S | 12 +++---------
 2 files changed, 13 insertions(+), 15 deletions(-)


base-commit: 31f2cece1db4175869ca3fe4cbe229c0e15fdaf0

Comments

Nicholas Piggin June 5, 2024, 1:30 a.m. UTC | #1 
On Tue Jun 4, 2024 at 9:59 PM AEST, Marc Hartmayer wrote:
> The first patch is useful anyway, the third could be dropped to be consistent
> with the other architectures.

Interesting. Is this the reason for the warning on all the other archs?
Maybe they should all use the same options and all remove the explicit
PHDR specification?

Thanks,
Nick
Marc Hartmayer June 5, 2024, 8:03 a.m. UTC | #2 
On Wed, Jun 05, 2024 at 11:30 AM +1000, "Nicholas Piggin" <npiggin@gmail.com> wrote:
> On Tue Jun 4, 2024 at 9:59 PM AEST, Marc Hartmayer wrote:
>> The first patch is useful anyway, the third could be dropped to be consistent
>> with the other architectures.
>
> Interesting. Is this the reason for the warning on all the other
> archs?

Could be, but the .eh_frame and .eh_frame_hdr sections are sometimes
required, e.g for __builtin_return_address(n),…. Another fix would be to
specify the sections in the linker scripts explicitly - but I’ve to ask
whether this has other side effects…

> Maybe they should all use the same options and all remove the explicit
> PHDR specification?
>
> Thanks,
> Nick
>
Marc Hartmayer July 26, 2024, 8:31 a.m. UTC | #3 
On Tue, Jun 04, 2024 at 01:59 PM +0200, Marc Hartmayer <mhartmay@linux.ibm.com> wrote:
> The first patch is useful anyway, the third could be dropped to be consistent
> with the other architectures.
>
> Marc Hartmayer (2):
>   s390x/Makefile: snippets: Add separate target for the ELF snippets
>   s390x/Makefile: snippets: Avoid creation of .eh_frame and
>     .eh_frame_hdr sections
>
> Super User (1):
>   Revert "s390x: Specify program headers with flags to avoid linker
>     warnings"
>
>  s390x/Makefile              | 16 ++++++++++------
>  s390x/snippets/c/flat.lds.S | 12 +++---------
>  2 files changed, 13 insertions(+), 15 deletions(-)
>
>
> base-commit: 31f2cece1db4175869ca3fe4cbe229c0e15fdaf0
> -- 
> 2.34.1
>
>

Polite ping.