[v2,0/6] selftests: kvm: s390: Reject invalid ioctls on ucontrol VMs

Message

Christoph Schlameuss Dec. 16, 2024, 9:21 a.m. UTC

This patch series adds more test case issuing ioctls to ucontrol VMs and
its floating interrupt controller.
The test cases trigger three possible null pointer dereferences within
the handling of the KVM_DEV_FLIC_APF_ENABLE,
KVM_DEV_FLIC_APF_DISABLE_WAIT and KVM_SET_GSI_ROUTING ioctl.

All of these issues do only exist on ucontrol VMs. Fixes for the issues
are included within the patch series.

v2:
- added documentation changes
- simplify uc_flic_attrs; remove .getrc and .setrc from uc_flic_attrs
(Thanks Claudio)

Christoph Schlameuss (6):
  kvm: s390: Reject setting flic pfault attributes on ucontrol VMs
  selftests: kvm: s390: Add ucontrol flic attr selftests
  kvm: s390: Reject KVM_SET_GSI_ROUTING on ucontrol VMs
  selftests: kvm: s390: Add ucontrol gis routing test
  selftests: kvm: s390: Streamline uc_skey test to issue iske after sske
  selftests: kvm: s390: Add has device attr check to uc_attr_mem_limit
    selftest

 Documentation/virt/kvm/api.rst                |   3 +
 Documentation/virt/kvm/devices/s390_flic.rst  |   4 +
 arch/s390/kvm/interrupt.c                     |   6 +
 .../selftests/kvm/s390x/ucontrol_test.c       | 194 ++++++++++++++++--
 4 files changed, 189 insertions(+), 18 deletions(-)

Comments

Claudio Imbrenda Dec. 16, 2024, 1:01 p.m. UTC | #1

On Mon, 16 Dec 2024 10:21:34 +0100
Christoph Schlameuss <[e-mail]> wrote:

> This patch series adds more test case issuing ioctls to ucontrol VMs and
> its floating interrupt controller.
> The test cases trigger three possible null pointer dereferences within
> the handling of the KVM_DEV_FLIC_APF_ENABLE,
> KVM_DEV_FLIC_APF_DISABLE_WAIT and KVM_SET_GSI_ROUTING ioctl.
> 
> All of these issues do only exist on ucontrol VMs. Fixes for the issues
> are included within the patch series.

Whole series:
Reviewed-by: Claudio Imbrenda <[e-mail]>

> 
> v2:
> - added documentation changes
> - simplify uc_flic_attrs; remove .getrc and .setrc from uc_flic_attrs
> (Thanks Claudio)
> 
> Christoph Schlameuss (6):
>   kvm: s390: Reject setting flic pfault attributes on ucontrol VMs
>   selftests: kvm: s390: Add ucontrol flic attr selftests
>   kvm: s390: Reject KVM_SET_GSI_ROUTING on ucontrol VMs
>   selftests: kvm: s390: Add ucontrol gis routing test
>   selftests: kvm: s390: Streamline uc_skey test to issue iske after sske
>   selftests: kvm: s390: Add has device attr check to uc_attr_mem_limit
>     selftest
> 
>  Documentation/virt/kvm/api.rst                |   3 +
>  Documentation/virt/kvm/devices/s390_flic.rst  |   4 +
>  arch/s390/kvm/interrupt.c                     |   6 +
>  .../selftests/kvm/s390x/ucontrol_test.c       | 194 ++++++++++++++++--
>  4 files changed, 189 insertions(+), 18 deletions(-)
>