From patchwork Mon Feb 24 16:54:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Christopherson X-Patchwork-Id: 13988467 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31CBE1917F1 for ; Mon, 24 Feb 2025 16:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740416086; cv=none; b=WGtWeywR9DGMfvQbuorLKcClAasTkJlgA+3pXy0fhlGkuijP1YTCQWHXK/iO+huVRT1I/+CY5iXfG9aqyAGct51StXsQSlSH8Cnr+aaqg2Wa7NGkWcVJnzgytcdKXss/JogfsC9YDhWnTt3o+q5FIha5Fk+wuLT++uZEqWFA1ns= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740416086; c=relaxed/simple; bh=qMqS5eEfht6kZYvGjtkUVdSw27+r0jMN/tKHjQa2x00=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=UrKYrj2lsGRMhx3lflxaH+YfWJ9EltLUjfJKJtB8XYE9R99/mx/j7Vvga4iqbrz+5TZkD9MoIqdKCoer98zc0I7U3GT5cGZxfdX8inUcgwy5dIhe/3uy2yTqjwr9SH9ZVvhP0juHCfXi080WZpqpqfiZKqoCRWCxJpGlpwg5UJY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=jDChtEOW; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jDChtEOW" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2fc3e239675so15108244a91.0 for ; Mon, 24 Feb 2025 08:54:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740416084; x=1741020884; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:reply-to:from:to:cc :subject:date:message-id:reply-to; bh=mO++5hfTZIp7IqLdPpH8usJ/YROL6etz3YUnuU1xDcQ=; b=jDChtEOWamrjaXAXnf5OtYZz1WeXSs6iwFh466WPSD46mHWmaHE6t5BOBO9w3TSHW5 P15fDON3VP9cUr3q+jfqjVWOxspP45P9KWXMwDwJgEtPYM1wcBx/duDG0BI/bZZEHZ+x /Kkm+vfrn7js/wMWUH7TARsQUjwiCVQlVDKp4wPXRHvEhbj5Z3gZyzRc0xXNRSbvW964 UURJ2WZ3muM53n+7YBDiMTS8GRBpjH26gaEIq0vcFqVKhtH/k/YvHBH7PJkQbuo3eY5Q y9fL+imvsaHCfGyZ8qQF61pjxRab0X5ipdhc1BYUG8tX1OvYZPmLLvOq01HepGfk/3tm 3BDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740416084; x=1741020884; h=cc:to:from:subject:message-id:mime-version:date:reply-to :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mO++5hfTZIp7IqLdPpH8usJ/YROL6etz3YUnuU1xDcQ=; b=a1ZuvekSdELE533gEMxETTY2J+yDcsAE4XmbvgDN6/BsDCY7DH80kR4NFTU9McSlYa cPcA9qEzwau1aEBgR6gu3geU7qEGrq5e+CgmmvkML8UlU+dUHHpmIouVYnsnDFqE0N2p KlZoJtrHgIYOVdnUgO1HAWKuqlmMB8m4kwHPNRUl4NsoVm9baey7B4oUQnifp7I1jwIE yNwSExhvRUCEaEXg7LpKxIwem9n6Zqxd5tRnf14g5nf/2Wdx5ejGYd5y500JgSvzw/29 M71YP/DqXF9UVKhHgfHp744YIDjCkXFCGY28nnehhbMGC74EkS4SnYZXpYYA9/eAFPwt cimw== X-Gm-Message-State: AOJu0YzQhw7MjRa+WdIdAYCI5P/aiy8V+MLurfCz88T1tZzyc2kKAgTf J2jLHx3CixZ3Fsi5RXSZsM6vDzM2lDxMUzir0Q+/RxOsQhFkag3fEQy3JhtutqBwj4YkMtmyC7J loA== X-Google-Smtp-Source: AGHT+IGb+f7j2I0nb12t7zmDGMmEI0YCFwJ+uRhnZXJ8MRHxJkt6TTRNK3XmV8KQPwwgSN4ciXRzHh216so= X-Received: from pjboe12.prod.google.com ([2002:a17:90b:394c:b0:2fa:1fac:2695]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90a:d40c:b0:2ee:fdf3:38ea with SMTP id 98e67ed59e1d1-2fce87243b6mr19543865a91.23.1740416084497; Mon, 24 Feb 2025 08:54:44 -0800 (PST) Reply-To: Sean Christopherson Date: Mon, 24 Feb 2025 08:54:40 -0800 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.48.1.601.g30ceb7b040-goog Message-ID: <20250224165442.2338294-1-seanjc@google.com> Subject: [PATCH v2 0/2] KVM: SVM: Fix an STI shadow on VMRUN bug From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Doug Covelli Fix a bug where KVM puts VMRUN in an STI shadow, which AMD CPUs bleed into guest state if a #VMEXIT occurs before completing the VMRUN, e.g. if vectoring an injected exception triggers an exit. v2: Use "raw" variants to avoid tracing in noinstr code. [kernel test robot] v1: https://lore.kernel.org/all/20250215010946.1201353-1-seanjc@google.com Sean Christopherson (2): KVM: SVM: Set RFLAGS.IF=1 in C code, to get VMRUN out of the STI shadow KVM: selftests: Assert that STI blocking isn't set after event injection arch/x86/kvm/svm/svm.c | 14 ++++++++++++++ arch/x86/kvm/svm/vmenter.S | 10 +--------- .../selftests/kvm/x86/nested_exceptions_test.c | 2 ++ 3 files changed, 17 insertions(+), 9 deletions(-) base-commit: fed48e2967f402f561d80075a20c5c9e16866e53