From patchwork Sun Apr 2 18:14:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arseniy Krasnov X-Patchwork-Id: 13197524 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F18DC77B62 for ; Sun, 2 Apr 2023 18:18:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231364AbjDBSST (ORCPT ); Sun, 2 Apr 2023 14:18:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230229AbjDBSSS (ORCPT ); Sun, 2 Apr 2023 14:18:18 -0400 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09B138A71; Sun, 2 Apr 2023 11:18:14 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 8D50D5FD04; Sun, 2 Apr 2023 21:18:12 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1680459492; bh=s4eKgbhgNv4f1gYW15n6VyDdSflCXwAy8F8mScWFz1Y=; h=Message-ID:Date:MIME-Version:To:From:Subject:Content-Type; b=kebCLhG8m8b44nPUXgIiLoHlm2div159+gCaxPZlok7PfL1MsDsFZz7JTObR9vHeh RaHgn0m3DSUt2AraE9JbfNEuaT/J5X9lJtnWOCH9INtbfLQHiVIgzbhbcLD6nl1KIE oNnsJ8jlNspkJhTkllNgItCG3s3gG/WuKp9IAGvHNbQYauohrFBuV0Q7+SOLEoqC/e vU2K9Q7GN5MQJA1Ah6WfIlvfUfgeWMoVNJ0R7GEHs9U6joeqT/ht5ATK0qewNvIiCO p8ZcDzfqXIqSJyx+c4MTTTfu7It2vzriaFKU+5p+A0XYcXKnhxVzMlSCef79mQQXpm gjxWCEVSsLQYQ== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Sun, 2 Apr 2023 21:18:07 +0300 (MSK) Message-ID: <5440aa51-8a6c-ac9f-9578-5bf9d66217a5@sberdevices.ru> Date: Sun, 2 Apr 2023 21:14:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Stefan Hajnoczi , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bobby Eshleman , Bryan Tan , Vishnu Dasa CC: , , , , , , , From: Arseniy Krasnov Subject: [RFC PATCH v4 0/3] vsock: return errors other than -ENOMEM to socket X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH02.sberdevices.ru (172.16.1.5) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/04/02 13:52:00 #21029650 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hello, this patchset removes behaviour, where error code returned from any transport was always switched to ENOMEM. This works in the same way as patch from Bobby Eshleman: commit c43170b7e157 ("vsock: return errors other than -ENOMEM to socket"), but for receive calls. VMCI transport is also updated (both tx and rx SOCK_STREAM callbacks), because it returns VMCI specific error code to af_vsock.c (like VMCI_ERROR_*). Tx path is already merged to net, so it was excluded from patchset in v4. At the same time, virtio and Hyper-V transports are using general error codes, so there is no need to update them. vsock_test suite is also updated. Link to v1: https://lore.kernel.org/netdev/97f19214-ba04-c47e-7486-72e8aa16c690@sberdevices.ru/ Link to v2: https://lore.kernel.org/netdev/60abc0da-0412-6e25-eeb0-8e32e3ec21e7@sberdevices.ru/ Link to v3: https://lore.kernel.org/netdev/dead4842-333a-015e-028b-302151336ff9@sberdevices.ru/ Changelog: v1 -> v2: - Add patch for VMCI as Vishnu Dasa suggested. v2 -> v3: - Change type of 'err' var in VMCI patches from 'int' to 'ssize_t'. - Split VMCI patch to two patches: for send and for receive cases. - Reorder patches: move VMCI before af_vsock.c. v3 -> v4: - Exclude VMCI patch for send from patchset (merged to 'net'). - Update commit message of VMCI patch for receive. Arseniy Krasnov (3): vsock/vmci: convert VMCI error code to -ENOMEM on receive vsock: return errors other than -ENOMEM to socket vsock/test: update expected return values net/vmw_vsock/af_vsock.c | 4 ++-- net/vmw_vsock/vmci_transport.c | 11 +++++++++-- tools/testing/vsock/vsock_test.c | 4 ++-- 3 files changed, 13 insertions(+), 6 deletions(-)