From patchwork Thu Jul 11 14:28:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Farhan Ali X-Patchwork-Id: 11040155 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 51BCF112C for ; Thu, 11 Jul 2019 14:29:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4039F28ABE for ; Thu, 11 Jul 2019 14:29:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 33C7128AD1; Thu, 11 Jul 2019 14:29:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D92B228ABE for ; Thu, 11 Jul 2019 14:29:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728612AbfGKO3L (ORCPT ); Thu, 11 Jul 2019 10:29:11 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:50460 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729074AbfGKO3K (ORCPT ); Thu, 11 Jul 2019 10:29:10 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6BESvGj057051 for ; Thu, 11 Jul 2019 10:29:08 -0400 Received: from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206]) by mx0b-001b2d01.pphosted.com with ESMTP id 2tp5y5b0j0-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 11 Jul 2019 10:29:08 -0400 Received: from localhost by e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 11 Jul 2019 15:28:59 +0100 Received: from b01cxnp22033.gho.pok.ibm.com (9.57.198.23) by e16.ny.us.ibm.com (146.89.104.203) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 11 Jul 2019 15:28:56 +0100 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6BEStD540501664 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Jul 2019 14:28:56 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E33CCAC060; Thu, 11 Jul 2019 14:28:55 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 89B37AC05F; Thu, 11 Jul 2019 14:28:55 +0000 (GMT) Received: from alifm-ThinkPad-T470p.ibm.com (unknown [9.85.180.152]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTPS; Thu, 11 Jul 2019 14:28:55 +0000 (GMT) From: Farhan Ali To: cohuck@redhat.com, farman@linux.ibm.com, pasic@linux.ibm.com Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org, alifm@linux.ibm.com Subject: [PATCH v3 0/5] Some vfio-ccw fixes Date: Thu, 11 Jul 2019 10:28:50 -0400 X-Mailer: git-send-email 2.7.4 X-TM-AS-GCONF: 00 x-cbid: 19071114-0072-0000-0000-000004479795 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00011408; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000286; SDB=6.01230659; UDB=6.00648232; IPR=6.01011935; MB=3.00027679; MTD=3.00000008; XFM=3.00000015; UTC=2019-07-11 14:28:57 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19071114-0073-0000-0000-00004CB7DC19 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-07-11_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=911 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907110163 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, While trying to chase down the problem regarding the stacktraces, I have also found some minor problems in the code. Would appreciate any review or feedback regarding them. Thanks Farhan ChangeLog --------- v2 -> v3 - Minor changes as suggested by Conny - Add Conny's reviewed-by tags - Add fixes tag for patch 4 and patch 5 v1 -> v2 - Update docs for csch/hsch since we can support those instructions now (patch 5) - Fix the memory leak where we fail to free a ccwchain (patch 2) - Add fixes tag where appropriate. - Fix comment instead of the order when setting orb.cmd.c64 (patch 1) Farhan Ali (5): vfio-ccw: Fix misleading comment when setting orb.cmd.c64 vfio-ccw: Fix memory leak and don't call cp_free in cp_init vfio-ccw: Set pa_nr to 0 if memory allocation fails for pa_iova_pfn vfio-ccw: Don't call cp_free if we are processing a channel program vfio-ccw: Update documentation for csch/hsch Documentation/s390/vfio-ccw.rst | 31 ++++++++++++++++++++++++++++--- drivers/s390/cio/vfio_ccw_cp.c | 28 +++++++++++++++++----------- drivers/s390/cio/vfio_ccw_drv.c | 2 +- 3 files changed, 46 insertions(+), 15 deletions(-)