From patchwork Thu Apr 30 08:39:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kalra, Ashish" X-Patchwork-Id: 11519475 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3725E14B4 for ; Thu, 30 Apr 2020 08:40:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14FD72192A for ; Thu, 30 Apr 2020 08:40:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="xjByJDfZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726531AbgD3IkI (ORCPT ); Thu, 30 Apr 2020 04:40:08 -0400 Received: from mail-dm6nam12on2083.outbound.protection.outlook.com ([40.107.243.83]:6127 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726127AbgD3IkI (ORCPT ); Thu, 30 Apr 2020 04:40:08 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eFNThh4XP+o5Koz5sEKYVzcNIqEOVKfDMvyVFG3ymCVmepOP+OC3hO2wfeJHqboGgu5L7FNeo3ERWE/CU1sAwg+oAl7SwzaqTCRX8rvgSOeQx/vru2cHvvgoWk+Frd8T2+IbB7OfM5KooOAc8vrs/kDIzrO6tznSWo43DfEBqsteMtH4+sJ/YlgOy885un9bXWZYU8FziAoosWHOS78RSmPJmXwil+iwpQ/JI4BTy0br6zKnj0ZIycf367VCeqZUm0QPH0sY9M4jtwwX3FuA+w4GptrCuhh9/ZAYszwMxj2vDDNgtYqnMVtFo7RFAzb+mbouP4k4HqrEsTJmiVONBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8JSvXoDvfk/PKQtqIWV3iyCle/egNbUegtRIAqJZ6gw=; b=CSg4PrtwEYDkI9EE1k661IRRvtajah79AP9pOBrwBfmq0VV8fzl0WShGD9uh+z4x1gPeuhdEImPHIeZWMr6D5T7KjG8ReZQeRGre4F0eprFVL1ZnWsyH7aWvXiFt1VXTCM9sqx0oT/LiuXccqqakPjw0MYaF0ykiIzs9x16R0laAUN0Coldqx3TSN+NhxyBgQtb4hFjuTqSNyUUl44Evsc+xiRpAiAWTf2TEiSlS4Er7P46r6zwdj44FyTrhcO0x5CAKh5yoXtz3JxVH9Qn5WynbcdwqwOECTPmSW+yXi3jm9O9P7Fud1iYMMaZ0rE3E6/4dLJjszFgk9fo5ktnCSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8JSvXoDvfk/PKQtqIWV3iyCle/egNbUegtRIAqJZ6gw=; b=xjByJDfZpTXRjREmRLcd0Gl07gBj5F/bCDputa5jZZPiWliwYl6LFB5wSnHyCd163VdwR97S4J1YrP3/od+87mbptJ5eY99pt/JRMftdkGzo+3UImtASttAuCoeOCbAPENe6B+Mh4MlvdE03mwdTnqwMlqMQSmFthzlIpSqhCCM= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1386.namprd12.prod.outlook.com (2603:10b6:3:77::9) by DM5PR12MB1194.namprd12.prod.outlook.com (2603:10b6:3:6e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Thu, 30 Apr 2020 08:40:01 +0000 Received: from DM5PR12MB1386.namprd12.prod.outlook.com ([fe80::969:3d4e:6f37:c33c]) by DM5PR12MB1386.namprd12.prod.outlook.com ([fe80::969:3d4e:6f37:c33c%12]) with mapi id 15.20.2937.028; Thu, 30 Apr 2020 08:40:01 +0000 From: Ashish Kalra To: pbonzini@redhat.com Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, joro@8bytes.org, bp@suse.de, thomas.lendacky@amd.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, srutherford@google.com, rientjes@google.com, venu.busireddy@oracle.com, brijesh.singh@amd.com Subject: [PATCH v7 00/18] Add AMD SEV guest live migration support Date: Thu, 30 Apr 2020 08:39:50 +0000 Message-Id: X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: SN6PR16CA0037.namprd16.prod.outlook.com (2603:10b6:805:ca::14) To DM5PR12MB1386.namprd12.prod.outlook.com (2603:10b6:3:77::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from ashkalra_ubuntu_server.amd.com (165.204.77.1) by SN6PR16CA0037.namprd16.prod.outlook.com (2603:10b6:805:ca::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19 via Frontend Transport; Thu, 30 Apr 2020 08:40:00 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [165.204.77.1] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 5a33a662-3fe4-4840-a8e7-08d7ece21266 X-MS-TrafficTypeDiagnostic: DM5PR12MB1194:|DM5PR12MB1194: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2150; X-Forefront-PRVS: 0389EDA07F X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1386.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(136003)(396003)(366004)(376002)(39860400002)(4326008)(6486002)(6916009)(66476007)(66946007)(52116002)(186003)(36756003)(7696005)(6666004)(316002)(5660300002)(26005)(86362001)(2906002)(8676002)(478600001)(66556008)(8936002)(956004)(2616005)(7416002)(966005)(16526019)(136400200001);DIR:OUT;SFP:1101; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Rd2znMkmZAzUAjAwO8CC/g9xIJQSuGuvSx6WyOzsQRM3ijF4XLZnsOHR/p4NX/BTDsJvXb225ZKlcQvHkc0geuIOe9Q6VYSohFOJ/SZzPI3Rdx00xSqFjkw7w8QuKSWCdDsevz3hLuS84lXwlU1FN1a4GoJSJ0DZsCmvI9RlIyw1Jix9mOKB4+tNvqcgfUW96GwjIBqahvJOu4ldfPrVbHwoTxCAmZ7xjCefW0kJXy/0bN9LPOJVlFx/hXi1f6D01kSnrIXT8RYEVg30GXjCiX/IgecpLZobWePb/pnyyt1+LrY2/QtC6TI8xhrZwbSZ30Jj591oh4c01BH43xYmLRnHerzSvut35fM300g9IfbO/kUjkwZxHp/O5oksLhPXhTPk+buY4BnNRpeDQxIktCA+tfptTFi8QGSuwDgKbHh9MiKSR7icW6i1+T00zzKmoXsboPgd/SjxENM/eBiIYvLJQAmuUZz4CRlTfgEZk/DWFZRMJu742ADJY/bLON2PoT88siJ+QALKD/frsL4De+tzKdKJadhwUoIO42jlZUgdnRZt4IsscuuXI8s7LJXuIXXc9TrSfUykzPS+xoxz8w== X-MS-Exchange-AntiSpam-MessageData: wrKrbeRYi/Vv1G+W+D3gB2FfCz9xYbrjB74lu+/XWC0FTkQD8sB+dBef4XxIB1xdXmgowlyCw3hTJV2TAxLLbhV9LImFq5I7m+c1v2+B3wztC1rzYTvsBZxLns89XMdiv54ZErAyXW28a2Y4xJZ4Mx5QzDtIAw5X0CPgJ0AYOwhlgr4VdYTwCx7OfgtARUi+l2tp1GVR9pWdqvHvJVNTBtyx7jT4vD4HCH7EM+lVWCmVOaQRnn5W+T96bbe9mzMz2ixK1I5ook11CSpD4gm0HouDgiAQP1km4crOmQ3+GcG/Wjt1BbYhkFXflBghKylYuqz66noew6gnuU+w8NGJDEswC2ebLQHBgrYVfhbEKPBTVFw4s++N7RQs+bUirT/VZZWTfs8JoxDKw7fPaqO47m2ZPrSNWwrUTcjDCX7eXnX1ov7P2YetEA0X3w+MqMZRlcnl5c0zjQmS3Ko4kgWjX18k5TA2MO20ALqtq93p11RKwhL8HJFPoi0TuRUt+nWQ/2ETRP63GBzRKczxoMNQYhwVIP6M1HZsctZdtsLBJJudHhTXj1oDufA8l2jV6+8safDuSNdxYetkFTWiL2/msrfh9MglZIp+z1KeZjxmaPiluF1fraOvISyl9GiIn8QU+3DRfj1BEThPjynG+u6cQXmQCSL2I6w09lLWh6wzv5/TVA60wAcmNSMb2w6A9yH4SF1XAcXVpWQmKuhgNXgCDUWAIhxdycnwS6H/rJDsQzAS0ooLVos1ctk4mlaMyn9SaKQ7zySmwVuoqHYvPQH8g5dqvtHiCxFGDBZG70QtyJI= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a33a662-3fe4-4840-a8e7-08d7ece21266 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2020 08:40:01.3685 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iXV29ma58TsRYDZapts0Rr6iWsycB2UdtGufwhxgJfZX8+yScL+FdQnfWoZOwthn2AmhgRZOad7C0RdvmyQ6Lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1194 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Ashish Kalra The series add support for AMD SEV guest live migration commands. To protect the confidentiality of an SEV protected guest memory while in transit we need to use the SEV commands defined in SEV API spec [1]. SEV guest VMs have the concept of private and shared memory. Private memory is encrypted with the guest-specific key, while shared memory may be encrypted with hypervisor key. The commands provided by the SEV FW are meant to be used for the private memory only. The patch series introduces a new hypercall. The guest OS can use this hypercall to notify the page encryption status. If the page is encrypted with guest specific-key then we use SEV command during the migration. If page is not encrypted then fallback to default. The patch adds new ioctls KVM_{SET,GET}_PAGE_ENC_BITMAP. The ioctl can be used by the qemu to get the page encrypted bitmap. Qemu can consult this bitmap during the migration to know whether the page is encrypted. [1] https://developer.amd.com/wp-content/resources/55766.PDF Changes since v6: - Rebasing to mainline and refactoring to the new split SVM infrastructre. - Move to static allocation of the unified Page Encryption bitmap instead of the dynamic resizing of the bitmap, the static allocation is done implicitly by extending kvm_arch_commit_memory_region() callack to add svm specific x86_ops which can read the userspace provided memory region/memslots and calculate the amount of guest RAM managed by the KVM and grow the bitmap. - Fixed KVM_SET_PAGE_ENC_BITMAP ioctl to set the whole bitmap instead of simply clearing specific bits. - Removed KVM_PAGE_ENC_BITMAP_RESET ioctl, which is now performed using KVM_SET_PAGE_ENC_BITMAP. - Extended guest support for enabling Live Migration feature by adding a check for UEFI environment variable indicating OVMF support for Live Migration feature and additionally checking for KVM capability for the same feature. If not booted under EFI, then we simply check for KVM capability. - Add hypervisor specific hypercall for SEV live migration by adding a new paravirt callback as part of x86_hyper_runtime. (x86 hypervisor specific runtime callbacks) - Moving MSR handling for MSR_KVM_SEV_LIVE_MIG_EN into svm/sev code and adding check for SEV live migration enabled by guest in the KVM_GET_PAGE_ENC_BITMAP ioctl. - Instead of the complete __bss_decrypted section, only specific variables such as hv_clock_boot and wall_clock are marked as decrypted in the page encryption bitmap Changes since v5: - Fix build errors as Reported-by: kbuild test robot Changes since v4: - Host support has been added to extend KVM capabilities/feature bits to include a new KVM_FEATURE_SEV_LIVE_MIGRATION, which the guest can query for host-side support for SEV live migration and a new custom MSR MSR_KVM_SEV_LIVE_MIG_EN is added for guest to enable the SEV live migration feature. - Ensure that _bss_decrypted section is marked as decrypted in the page encryption bitmap. - Fixing KVM_GET_PAGE_ENC_BITMAP ioctl to return the correct bitmap as per the number of pages being requested by the user. Ensure that we only copy bmap->num_pages bytes in the userspace buffer, if bmap->num_pages is not byte aligned we read the trailing bits from the userspace and copy those bits as is. This fixes guest page(s) corruption issues observed after migration completion. - Add kexec support for SEV Live Migration to reset the host's page encryption bitmap related to kernel specific page encryption status settings before we load a new kernel by kexec. We cannot reset the complete page encryption bitmap here as we need to retain the UEFI/OVMF firmware specific settings. Changes since v3: - Rebasing to mainline and testing. - Adding a new KVM_PAGE_ENC_BITMAP_RESET ioctl, which resets the page encryption bitmap on a guest reboot event. - Adding a more reliable sanity check for GPA range being passed to the hypercall to ensure that guest MMIO ranges are also marked in the page encryption bitmap. Changes since v2: - reset the page encryption bitmap on vcpu reboot Changes since v1: - Add support to share the page encryption between the source and target machine. - Fix review feedbacks from Tom Lendacky. - Add check to limit the session blob length. - Update KVM_GET_PAGE_ENC_BITMAP icotl to use the base_gfn instead of the memory slot when querying the bitmap. Ashish Kalra (7): x86/paravirt: Add hypervisor specific hypercall for SEV live migration. KVM: SVM: Add support for static allocation of unified Page Encryption Bitmap. KVM: x86: Introduce new KVM_FEATURE_SEV_LIVE_MIGRATION feature & Custom MSR. EFI: Introduce the new AMD Memory Encryption GUID. KVM: x86: Add guest support for detecting and enabling SEV Live Migration feature. KVM: x86: Mark _bss_decrypted section variables as decrypted in page encryption bitmap. KVM: x86: Add kexec support for SEV Live Migration. Brijesh Singh (11): KVM: SVM: Add KVM_SEV SEND_START command KVM: SVM: Add KVM_SEND_UPDATE_DATA command KVM: SVM: Add KVM_SEV_SEND_FINISH command KVM: SVM: Add support for KVM_SEV_RECEIVE_START command KVM: SVM: Add KVM_SEV_RECEIVE_UPDATE_DATA command KVM: SVM: Add KVM_SEV_RECEIVE_FINISH command KVM: x86: Add AMD SEV specific Hypercall3 KVM: X86: Introduce KVM_HC_PAGE_ENC_STATUS hypercall KVM: x86: Introduce KVM_GET_PAGE_ENC_BITMAP ioctl mm: x86: Invoke hypercall when page encryption status is changed KVM: x86: Introduce KVM_SET_PAGE_ENC_BITMAP ioctl .../virt/kvm/amd-memory-encryption.rst | 120 +++ Documentation/virt/kvm/api.rst | 71 ++ Documentation/virt/kvm/cpuid.rst | 5 + Documentation/virt/kvm/hypercalls.rst | 15 + Documentation/virt/kvm/msr.rst | 10 + arch/x86/include/asm/kvm_host.h | 7 + arch/x86/include/asm/kvm_para.h | 12 + arch/x86/include/asm/mem_encrypt.h | 11 + arch/x86/include/asm/paravirt.h | 10 + arch/x86/include/asm/paravirt_types.h | 2 + arch/x86/include/asm/x86_init.h | 10 +- arch/x86/include/uapi/asm/kvm_para.h | 5 + arch/x86/kernel/kvm.c | 102 +++ arch/x86/kernel/kvmclock.c | 12 + arch/x86/kernel/paravirt.c | 1 + arch/x86/kvm/svm/sev.c | 723 +++++++++++++++++- arch/x86/kvm/svm/svm.c | 21 + arch/x86/kvm/svm/svm.h | 9 + arch/x86/kvm/vmx/vmx.c | 1 + arch/x86/kvm/x86.c | 35 + arch/x86/mm/mem_encrypt.c | 69 +- arch/x86/mm/pat/set_memory.c | 7 + include/linux/efi.h | 1 + include/linux/psp-sev.h | 8 +- include/uapi/linux/kvm.h | 52 ++ include/uapi/linux/kvm_para.h | 1 + 26 files changed, 1310 insertions(+), 10 deletions(-)