From patchwork Tue Mar 5 11:18:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 13582183 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8C0A548FB; Tue, 5 Mar 2024 11:18:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709637534; cv=none; b=ImC5dSX2H4w9Zcji9Zg+ObiyXaPt8Y8jtnNhsU0qQKDwD7LhOwL+oWolbYqsisIZ4HZmINfJ+W/fLh33jFE/GVKO8x2cFeHZVUkkvZKCr6wzbKrIPIi58HoPiQ5nPCTtlghTT/GHiaKY0sz7H962jkAW+765kz7ezASlO3ZYWR8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709637534; c=relaxed/simple; bh=NxhQVbYsKSwyvGgGk5qfaF5a/Y1wAzitab7stbdLKEk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VI9SaCC4Q8VqXbsinGVdNZrzh6IY88g73STuTSWR4u6Rl8j2LSfjq0TocVvhLuAHjkYgiepZp34bbds3d6H1MbAsXfIB5i/Jcv389rcvQPrzNVdnmF+mHxmjzRf0oSdPtgBQAiJySJ6vsw6no1d3TQhS/kgqb9fLLHjN0Fu7188= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=r002UdI0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r002UdI0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 531A2C433F1; Tue, 5 Mar 2024 11:18:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709637534; bh=NxhQVbYsKSwyvGgGk5qfaF5a/Y1wAzitab7stbdLKEk=; h=From:To:Cc:Subject:Date:From; b=r002UdI01gg2rXuVaeOK/D1fhwvZco1HuVKXX0raiRp4PUfsfXV1wc5RAqWyZvJGK mRH29l4+teuQlcz7MYEH/XOhAk5fjO/D/+ObXI96O5zHSMTDzcXW1equc4uEnI9Kre 2BcxvXeVYU69p4m+lD0jFj6BxZAVk5SYUzkfEQXMq9ZQADbWBmK/mOgQSEndSNXrmU N0zqFP6N8iRdWJolF3xUwGboWwTM+WK03mm/r/4T6jt0HRL4N+JZfELJzmdMuRU5c2 3ntsHZLDUHj1RvDsUQibOL0qdzbtw4jvy9b1b8vryqWssRm+htmwj9BHKQEKphbBXH 1E2fwP28bIgFw== From: Leon Romanovsky To: Christoph Hellwig , Robin Murphy , Marek Szyprowski , Joerg Roedel , Will Deacon , Jason Gunthorpe , Chaitanya Kulkarni Cc: Jonathan Corbet , Jens Axboe , Keith Busch , Sagi Grimberg , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?utf-8?b?SsOpcsO0bWUgR2xp?= =?utf-8?b?c3Nl?= , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, kvm@vger.kernel.org, linux-mm@kvack.org, Bart Van Assche , Damien Le Moal , Amir Goldstein , "josef@toxicpanda.com" , "Martin K. Petersen" , "daniel@iogearbox.net" , Dan Williams , "jack@suse.com" , Leon Romanovsky , Zhu Yanjun Subject: [RFC RESEND 00/16] Split IOMMU DMA mapping operation to two steps Date: Tue, 5 Mar 2024 13:18:31 +0200 Message-ID: X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This is complimentary part to the proposed LSF/MM topic. https://lore.kernel.org/linux-rdma/22df55f8-cf64-4aa8-8c0b-b556c867b926@linux.dev/T/#m85672c860539fdbbc8fe0f5ccabdc05b40269057 This is posted as RFC to get a feedback on proposed split, but RDMA, VFIO and DMA patches are ready for review and inclusion, the NVMe patches are still in progress as they require agreement on API first. Thanks ------------------------------------------------------------------------------- The DMA mapping operation performs two steps at one same time: allocates IOVA space and actually maps DMA pages to that space. This one shot operation works perfectly for non-complex scenarios, where callers use that DMA API in control path when they setup hardware. However in more complex scenarios, when DMA mapping is needed in data path and especially when some sort of specific datatype is involved, such one shot approach has its drawbacks. That approach pushes developers to introduce new DMA APIs for specific datatype. For example existing scatter-gather mapping functions, or latest Chuck's RFC series to add biovec related DMA mapping [1] and probably struct folio will need it too. These advanced DMA mapping APIs are needed to calculate IOVA size to allocate it as one chunk and some sort of offset calculations to know which part of IOVA to map. Instead of teaching DMA to know these specific datatypes, let's separate existing DMA mapping routine to two steps and give an option to advanced callers (subsystems) perform all calculations internally in advance and map pages later when it is needed. In this series, three users are converted and each of such conversion presents different positive gain: 1. RDMA simplifies and speeds up its pagefault handling for on-demand-paging (ODP) mode. 2. VFIO PCI live migration code saves huge chunk of memory. 3. NVMe PCI avoids intermediate SG table manipulation and operates directly on BIOs. Thanks [1] https://lore.kernel.org/all/169772852492.5232.17148564580779995849.stgit@klimt.1015granger.net Chaitanya Kulkarni (2): block: add dma_link_range() based API nvme-pci: use blk_rq_dma_map() for NVMe SGL Leon Romanovsky (14): mm/hmm: let users to tag specific PFNs dma-mapping: provide an interface to allocate IOVA dma-mapping: provide callbacks to link/unlink pages to specific IOVA iommu/dma: Provide an interface to allow preallocate IOVA iommu/dma: Prepare map/unmap page functions to receive IOVA iommu/dma: Implement link/unlink page callbacks RDMA/umem: Preallocate and cache IOVA for UMEM ODP RDMA/umem: Store ODP access mask information in PFN RDMA/core: Separate DMA mapping to caching IOVA and page linkage RDMA/umem: Prevent UMEM ODP creation with SWIOTLB vfio/mlx5: Explicitly use number of pages instead of allocated length vfio/mlx5: Rewrite create mkey flow to allow better code reuse vfio/mlx5: Explicitly store page list vfio/mlx5: Convert vfio to use DMA link API Documentation/core-api/dma-attributes.rst | 7 + block/blk-merge.c | 156 ++++++++++++++ drivers/infiniband/core/umem_odp.c | 219 +++++++------------ drivers/infiniband/hw/mlx5/mlx5_ib.h | 1 + drivers/infiniband/hw/mlx5/odp.c | 59 +++-- drivers/iommu/dma-iommu.c | 129 ++++++++--- drivers/nvme/host/pci.c | 220 +++++-------------- drivers/vfio/pci/mlx5/cmd.c | 252 ++++++++++++---------- drivers/vfio/pci/mlx5/cmd.h | 22 +- drivers/vfio/pci/mlx5/main.c | 136 +++++------- include/linux/blk-mq.h | 9 + include/linux/dma-map-ops.h | 13 ++ include/linux/dma-mapping.h | 39 ++++ include/linux/hmm.h | 3 + include/rdma/ib_umem_odp.h | 22 +- include/rdma/ib_verbs.h | 54 +++++ kernel/dma/debug.h | 2 + kernel/dma/direct.h | 7 +- kernel/dma/mapping.c | 91 ++++++++ mm/hmm.c | 34 +-- 20 files changed, 870 insertions(+), 605 deletions(-) Signed-off-by: Leon Romanovsky