[v4,0/2] KVM: SVM: Make VMGEXIT GHCB exit codes more readable

Message

Melody Wang Dec. 30, 2024, 8:36 p.m. UTC

Hi all,

This patchset addresses all of review comments from Sean. All feedback is appreciated.

Thanks,
Melody

Changelog:
v3:

Here are two patches to make VMGEXIT GHCB exit codes more readable. All
feedback is appreciated.

Melody Wang (2):
  KVM: SVM: Convert plain error code numbers to defines
  KVM: SVM: Provide helpers to set the error code

 arch/x86/include/asm/sev-common.h |  8 +++++++
 arch/x86/kvm/svm/sev.c            | 36 ++++++++++++++++---------------
 arch/x86/kvm/svm/svm.c            |  6 +-----
 arch/x86/kvm/svm/svm.h            | 29 +++++++++++++++++++++++++
 4 files changed, 57 insertions(+), 22 deletions(-)

Comments

Tom Lendacky Jan. 2, 2025, 2:58 p.m. UTC | #1

On 12/30/24 14:36, Melody Wang wrote:

Just some FYIs when it comes to cover letters.

> Hi all,

No need to put this in a cover letter.

> 
> This patchset addresses all of review comments from Sean. All feedback is appreciated.

This should be part of your change log below.

Here you should have a summary of what the series is about.

> 
> Thanks,
> Melody
> 
> Changelog:
> v3:

You're missing the changes from v3 to v4 and you shouldn't delete the
previous log of changes from v1 to v2 and v2 to v3.

> 
> Here are two patches to make VMGEXIT GHCB exit codes more readable. All
> feedback is appreciated.

This should be at the top. Also, this isn't for exit codes, it is for the
hypervisor return error codes, right?

Thanks,
Tom

> 
> Melody Wang (2):
>   KVM: SVM: Convert plain error code numbers to defines
>   KVM: SVM: Provide helpers to set the error code
> 
>  arch/x86/include/asm/sev-common.h |  8 +++++++
>  arch/x86/kvm/svm/sev.c            | 36 ++++++++++++++++---------------
>  arch/x86/kvm/svm/svm.c            |  6 +-----
>  arch/x86/kvm/svm/svm.h            | 29 +++++++++++++++++++++++++
>  4 files changed, 57 insertions(+), 22 deletions(-)
>