libkvm not compile with latest qemu-kvm

Commit Message

Xu, Jiajun May 21, 2009, 8:42 a.m. UTC

Hi Avi,
I found libkvm.a not compiled with latest qemu-kvm with following error message:
####
gcc  -I. -I.. -I/home/jiajun/kvm/qemu-kvm/target-i386 -I/home/jiajun/kvm/qemu-kvm -MMD -MT qemu-kvm-helper.o -MP -DNEED_CPU_H -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D__user= -I/home/jiajun/kvm/qemu-kvm/tcg -I/home/jiajun/kvm/qemu-kvm/tcg/x86_64 -I/home/jiajun/kvm/qemu-kvm/fpu   -DHAS_AUDIO -DHAS_AUDIO_CHOICE -I/home/jiajun/kvm/qemu-kvm/slirp -O2 -g -fno-strict-aliasing -Wall -Wundef -Wendif-labels -Wwrite-strings -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -I/home/jiajun/kvm/qemu-kvm/kvm/libkvm  -m64 -I/home/jiajun/kvm/qemu-kvm/kvm/include -I/home/jiajun/kvm/qemu-kvm/kvm/include/x86 -c -o qemu-kvm-helper.o /home/jiajun/kvm/qemu-kvm/qemu-kvm-helper.c
  CC    x86_64-softmmu/kvm-tpr-opt.o
  CC    x86_64-softmmu/disas.o
  CC    x86_64-softmmu/i386-dis.o
  CC    x86_64-softmmu/vl.o
  CC    x86_64-softmmu/gdbstub-xml.o
/home/jiajun/kvm/qemu-kvm/vl.c:4885: warning: âalloc_mem_areaâ defined but not used
  AR    x86_64-softmmu/libqemu.a
  LINK  x86_64-softmmu/qemu-system-x86_64
gcc: libkvm.a: No such file or directory
make[1]: *** [qemu-system-x86_64] Error 1
make: *** [subdir-x86_64-softmmu] Error 2
####

After I modified the Makefile.target, it can pass:



Best Regards
Jiajun--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Avi Kivity May 21, 2009, 11:56 a.m. UTC | #1

Xu, Jiajun wrote:
> Hi Avi,
> I found libkvm.a not compiled with latest qemu-kvm with following error message:
> ####
> gcc  -I. -I.. -I/home/jiajun/kvm/qemu-kvm/target-i386 -I/home/jiajun/kvm/qemu-kvm -MMD -MT qemu-kvm-helper.o -MP -DNEED_CPU_H -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D__user= -I/home/jiajun/kvm/qemu-kvm/tcg -I/home/jiajun/kvm/qemu-kvm/tcg/x86_64 -I/home/jiajun/kvm/qemu-kvm/fpu   -DHAS_AUDIO -DHAS_AUDIO_CHOICE -I/home/jiajun/kvm/qemu-kvm/slirp -O2 -g -fno-strict-aliasing -Wall -Wundef -Wendif-labels -Wwrite-strings -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -I/home/jiajun/kvm/qemu-kvm/kvm/libkvm  -m64 -I/home/jiajun/kvm/qemu-kvm/kvm/include -I/home/jiajun/kvm/qemu-kvm/kvm/include/x86 -c -o qemu-kvm-helper.o /home/jiajun/kvm/qemu-kvm/qemu-kvm-helper.c
>   CC    x86_64-softmmu/kvm-tpr-opt.o
>   CC    x86_64-softmmu/disas.o
>   CC    x86_64-softmmu/i386-dis.o
>   CC    x86_64-softmmu/vl.o
>   CC    x86_64-softmmu/gdbstub-xml.o
> /home/jiajun/kvm/qemu-kvm/vl.c:4885: warning: âalloc_mem_areaâ defined but not used
>   AR    x86_64-softmmu/libqemu.a
>   LINK  x86_64-softmmu/qemu-system-x86_64
> gcc: libkvm.a: No such file or directory
> make[1]: *** [qemu-system-x86_64] Error 1
> make: *** [subdir-x86_64-softmmu] Error 2
> ####
>
> After I modified the Makefile.target, it can pass:
>
> diff --git a/Makefile.target b/Makefile.target
> index 575466c..78bf5d7 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -796,7 +796,7 @@ vl.o: qemu-options.h
>
>  $(QEMU_PROG): LIBS += $(SDL_LIBS) $(COCOA_LIBS) $(CURSES_LIBS) $(BRLAPI_LIBS) $(VDE_LIBS)
>  $(QEMU_PROG): ARLIBS=../libqemu_common.a libqemu.a $(HWLIB)
> -$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a $(HWLIB)
> +$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a $(HWLIB) $(DEPLIBS)
>         $(call LINK,$(OBJS))
>
>  $(QEMU_PROG): ARLIBS += $(DEPLIBS)
>
>   

Thanks, I've applied something similar (added the dependency in a 
separate line to avoid future merge conflicts).

Patch

diff --git a/Makefile.target b/Makefile.target
index 575466c..78bf5d7 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -796,7 +796,7 @@  vl.o: qemu-options.h

 $(QEMU_PROG): LIBS += $(SDL_LIBS) $(COCOA_LIBS) $(CURSES_LIBS) $(BRLAPI_LIBS) $(VDE_LIBS)
 $(QEMU_PROG): ARLIBS=../libqemu_common.a libqemu.a $(HWLIB)
-$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a $(HWLIB)
+$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a $(HWLIB) $(DEPLIBS)
        $(call LINK,$(OBJS))

 $(QEMU_PROG): ARLIBS += $(DEPLIBS)