From patchwork Tue Jan 13 17:27:33 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark McLoughlin X-Patchwork-Id: 2188 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n0DHNcOU026562 for ; Tue, 13 Jan 2009 09:23:38 -0800 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752665AbZAMR1i (ORCPT ); Tue, 13 Jan 2009 12:27:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753053AbZAMR1i (ORCPT ); Tue, 13 Jan 2009 12:27:38 -0500 Received: from mx2.redhat.com ([66.187.237.31]:41051 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752665AbZAMR1i (ORCPT ); Tue, 13 Jan 2009 12:27:38 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0DHRbPb023510; Tue, 13 Jan 2009 12:27:37 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n0DHRamW021536; Tue, 13 Jan 2009 12:27:37 -0500 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n0DHRYan016118; Tue, 13 Jan 2009 12:27:36 -0500 Subject: Re: [ANNOUNCE] kvm-83 release From: Mark McLoughlin Reply-To: Mark McLoughlin To: John Wong Cc: Avi Kivity , KVM list In-Reply-To: <496CBE09.4060801@wonghome.net> References: <496C9CE0.2080103@redhat.com> <496CBE09.4060801@wonghome.net> Date: Tue, 13 Jan 2009 17:27:33 +0000 Message-Id: <1231867653.4290.196.camel@localhost.localdomain> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi John, On Wed, 2009-01-14 at 00:15 +0800, John Wong wrote: > Hi, i installed kvm-83 on xubuntu-amd64/kernel-2.6.7-11. > i notice some problem with -net downscript. > my kvm start up script like this: > qemu-system-x86_64 ... ... -net > tap,ifname=tap0,script=/path/kvm-ifup,downscript=/path/kvm-ifdown > when the guest shutdown, kvm pass all argument to downscript. > > the command like this (kvm-83): > /path/kvm-ifdown > "tap0,script=/path/kvm-ifup,downscript=/path/kvm-ifdown" > > kvm-82 only pass tap0 to downscript like this: > /path/kvm-ifdown "tap0" Thanks for the report. Can you try this simple change and see if it fixes it for you? Thanks, Mark. --- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- qemu/net.c +++ qemu/net.c @@ -1740,7 +1740,7 @@ void net_cleanup(void) TAPState *s = vc->opaque; if (strcmp(vc->model, "tap") == 0 && - sscanf(vc->info_str, "ifname=%63s ", ifname) == 1 && + sscanf(vc->info_str, "ifname=%63s,", ifname) == 1 && s->down_script[0]) launch_script(s->down_script, ifname, s->fd); }