| Message ID | 1234967203-6031-2-git-send-email-sheng@linux.intel.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Sheng Yang wrote: > _IOR for copy_to_user and _IOW for copy_from_user... > > Noticed by Avi. > > Signed-off-by: Sheng Yang <sheng@linux.intel.com> > --- > include/linux/kvm.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/kvm.h b/include/linux/kvm.h > index 2163b3d..d742cbf 100644 > --- a/include/linux/kvm.h > +++ b/include/linux/kvm.h > @@ -469,10 +469,10 @@ struct kvm_irq_routing { > _IOW(KVMIO, 0x67, struct kvm_coalesced_mmio_zone) > #define KVM_UNREGISTER_COALESCED_MMIO \ > _IOW(KVMIO, 0x68, struct kvm_coalesced_mmio_zone) > -#define KVM_ASSIGN_PCI_DEVICE _IOR(KVMIO, 0x69, \ > +#define KVM_ASSIGN_PCI_DEVICE _IOW(KVMIO, 0x69, \ > struct kvm_assigned_pci_dev) > #define KVM_SET_GSI_ROUTING _IOW(KVMIO, 0x6a, struct kvm_irq_routing) > -#define KVM_ASSIGN_IRQ _IOR(KVMIO, 0x70, \ > +#define KVM_ASSIGN_IRQ _IOW(KVMIO, 0x70, \ > struct kvm_assigned_irq) > #define KVM_REINJECT_CONTROL _IO(KVMIO, 0x71) > > KVM_ASSIGN_PCI_DEVICE was introduced in 2.6.28. We can't fix it since it's part of the ABI.
On Wednesday 18 February 2009 22:44:15 Avi Kivity wrote: > Sheng Yang wrote: > > _IOR for copy_to_user and _IOW for copy_from_user... > > > > Noticed by Avi. > > > > Signed-off-by: Sheng Yang <sheng@linux.intel.com> > > --- > > include/linux/kvm.h | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/kvm.h b/include/linux/kvm.h > > index 2163b3d..d742cbf 100644 > > --- a/include/linux/kvm.h > > +++ b/include/linux/kvm.h > > @@ -469,10 +469,10 @@ struct kvm_irq_routing { > > _IOW(KVMIO, 0x67, struct kvm_coalesced_mmio_zone) > > #define KVM_UNREGISTER_COALESCED_MMIO \ > > _IOW(KVMIO, 0x68, struct kvm_coalesced_mmio_zone) > > -#define KVM_ASSIGN_PCI_DEVICE _IOR(KVMIO, 0x69, \ > > +#define KVM_ASSIGN_PCI_DEVICE _IOW(KVMIO, 0x69, \ > > struct kvm_assigned_pci_dev) > > #define KVM_SET_GSI_ROUTING _IOW(KVMIO, 0x6a, struct > > kvm_irq_routing) -#define KVM_ASSIGN_IRQ _IOR(KVMIO, 0x70, \ > > +#define KVM_ASSIGN_IRQ _IOW(KVMIO, 0x70, \ > > struct kvm_assigned_irq) > > #define KVM_REINJECT_CONTROL _IO(KVMIO, 0x71) > > KVM_ASSIGN_PCI_DEVICE was introduced in 2.6.28. We can't fix it since > it's part of the ABI. OK... So please take this one off.
diff --git a/include/linux/kvm.h b/include/linux/kvm.h index 2163b3d..d742cbf 100644 --- a/include/linux/kvm.h +++ b/include/linux/kvm.h @@ -469,10 +469,10 @@ struct kvm_irq_routing { _IOW(KVMIO, 0x67, struct kvm_coalesced_mmio_zone) #define KVM_UNREGISTER_COALESCED_MMIO \ _IOW(KVMIO, 0x68, struct kvm_coalesced_mmio_zone) -#define KVM_ASSIGN_PCI_DEVICE _IOR(KVMIO, 0x69, \ +#define KVM_ASSIGN_PCI_DEVICE _IOW(KVMIO, 0x69, \ struct kvm_assigned_pci_dev) #define KVM_SET_GSI_ROUTING _IOW(KVMIO, 0x6a, struct kvm_irq_routing) -#define KVM_ASSIGN_IRQ _IOR(KVMIO, 0x70, \ +#define KVM_ASSIGN_IRQ _IOW(KVMIO, 0x70, \ struct kvm_assigned_irq) #define KVM_REINJECT_CONTROL _IO(KVMIO, 0x71)
_IOR for copy_to_user and _IOW for copy_from_user... Noticed by Avi. Signed-off-by: Sheng Yang <sheng@linux.intel.com> --- include/linux/kvm.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)