From patchwork Mon Mar 2 08:29:28 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sheng Yang X-Patchwork-Id: 9501 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n228Tjw0011310 for ; Mon, 2 Mar 2009 08:29:46 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755540AbZCBI3n (ORCPT ); Mon, 2 Mar 2009 03:29:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756282AbZCBI3m (ORCPT ); Mon, 2 Mar 2009 03:29:42 -0500 Received: from mga01.intel.com ([192.55.52.88]:23518 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755540AbZCBI3j (ORCPT ); Mon, 2 Mar 2009 03:29:39 -0500 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 02 Mar 2009 00:22:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.38,288,1233561600"; d="scan'208";a="669528440" Received: from syang10-desktop.sh.intel.com (HELO syang10-desktop) ([10.239.13.189]) by fmsmga001.fm.intel.com with ESMTP; 02 Mar 2009 00:33:26 -0800 Received: from yasker by syang10-desktop with local (Exim 4.69) (envelope-from ) id 1Le3Wo-0001oN-1P; Mon, 02 Mar 2009 16:29:34 +0800 From: Sheng Yang To: Avi Kivity , Marcelo Tosatti , Anthony Liguori Cc: kvm@vger.kernel.org, Sheng Yang Subject: [PATCH 05/10] kvm: user interface for MSI type irq routing Date: Mon, 2 Mar 2009 16:29:28 +0800 Message-Id: <1235982573-6932-6-git-send-email-sheng@linux.intel.com> X-Mailer: git-send-email 1.5.6.3 In-Reply-To: <1235982573-6932-1-git-send-email-sheng@linux.intel.com> References: <1235982573-6932-1-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Signed-off-by: Sheng Yang --- libkvm/libkvm.c | 98 ++++++++++++++++++++++++++++++++++++++++++++----------- libkvm/libkvm.h | 22 ++++++++++++ 2 files changed, 101 insertions(+), 19 deletions(-) diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c index 0ac1c28..050eacd 100644 --- a/libkvm/libkvm.c +++ b/libkvm/libkvm.c @@ -1229,11 +1229,12 @@ int kvm_clear_gsi_routes(kvm_context_t kvm) #endif } -int kvm_add_irq_route(kvm_context_t kvm, int gsi, int irqchip, int pin) +int kvm_add_routing_entry(kvm_context_t kvm, + struct kvm_irq_routing_entry* entry) { #ifdef KVM_CAP_IRQ_ROUTING struct kvm_irq_routing *z; - struct kvm_irq_routing_entry *e; + struct kvm_irq_routing_entry *new; int n, size; if (kvm->irq_routes->nr == kvm->nr_allocated_irq_routes) { @@ -1241,7 +1242,7 @@ int kvm_add_irq_route(kvm_context_t kvm, int gsi, int irqchip, int pin) if (n < 64) n = 64; size = sizeof(struct kvm_irq_routing); - size += n * sizeof(*e); + size += n * sizeof(*new); z = realloc(kvm->irq_routes, size); if (!z) return -ENOMEM; @@ -1249,34 +1250,77 @@ int kvm_add_irq_route(kvm_context_t kvm, int gsi, int irqchip, int pin) kvm->irq_routes = z; } n = kvm->irq_routes->nr++; - e = &kvm->irq_routes->entries[n]; - memset(e, 0, sizeof(*e)); - e->gsi = gsi; - e->type = KVM_IRQ_ROUTING_IRQCHIP; - e->flags = 0; - e->u.irqchip.irqchip = irqchip; - e->u.irqchip.pin = pin; + new = &kvm->irq_routes->entries[n]; + memset(new, 0, sizeof(*new)); + new->gsi = entry->gsi; + new->type = entry->type; + new->flags = entry->flags; + new->u = entry->u; return 0; #else return -ENOSYS; #endif } -int kvm_del_irq_route(kvm_context_t kvm, int gsi, int irqchip, int pin) +int kvm_add_irq_route(kvm_context_t kvm, int gsi, int irqchip, int pin) +{ +#ifdef KVM_CAP_IRQ_ROUTING + struct kvm_irq_routing_entry e; + + e.gsi = gsi; + e.type = KVM_IRQ_ROUTING_IRQCHIP; + e.flags = 0; + e.u.irqchip.irqchip = irqchip; + e.u.irqchip.pin = pin; + return kvm_add_routing_entry(kvm, &e); +#else + return -ENOSYS; +#endif +} + +int kvm_del_routing_entry(kvm_context_t kvm, + struct kvm_irq_routing_entry* entry) { #ifdef KVM_CAP_IRQ_ROUTING struct kvm_irq_routing_entry *e, *p; - int i; + int i, found = 0; for (i = 0; i < kvm->irq_routes->nr; ++i) { e = &kvm->irq_routes->entries[i]; - if (e->type == KVM_IRQ_ROUTING_IRQCHIP - && e->gsi == gsi - && e->u.irqchip.irqchip == irqchip - && e->u.irqchip.pin == pin) { - p = &kvm->irq_routes->entries[--kvm->irq_routes->nr]; - *e = *p; - return 0; + if (e->type == entry->type + && e->gsi == entry->gsi) { + switch (e->type) + { + case KVM_IRQ_ROUTING_IRQCHIP: { + if (e->u.irqchip.irqchip == + entry->u.irqchip.irqchip + && e->u.irqchip.pin == + entry->u.irqchip.pin) { + p = &kvm->irq_routes-> + entries[--kvm->irq_routes->nr]; + *e = *p; + found = 1; + } + break; + } + case KVM_IRQ_ROUTING_MSI: { + if (e->u.msi.address_lo == + entry->u.msi.address_lo + && e->u.msi.address_hi == + entry->u.msi.address_hi + && e->u.msi.data == entry->u.msi.data) { + p = &kvm->irq_routes-> + entries[--kvm->irq_routes->nr]; + *e = *p; + found = 1; + } + break; + } + default: + break; + } + if (found) + return 0; } } return -ESRCH; @@ -1285,6 +1329,22 @@ int kvm_del_irq_route(kvm_context_t kvm, int gsi, int irqchip, int pin) #endif } +int kvm_del_irq_route(kvm_context_t kvm, int gsi, int irqchip, int pin) +{ +#ifdef KVM_CAP_IRQ_ROUTING + struct kvm_irq_routing_entry e; + + e.gsi = gsi; + e.type = KVM_IRQ_ROUTING_IRQCHIP; + e.flags = 0; + e.u.irqchip.irqchip = irqchip; + e.u.irqchip.pin = pin; + return kvm_del_routing_entry(kvm, &e); +#else + return -ENOSYS; +#endif +} + int kvm_commit_irq_routes(kvm_context_t kvm) { #ifdef KVM_CAP_IRQ_ROUTING diff --git a/libkvm/libkvm.h b/libkvm/libkvm.h index 0239cb6..d9b3ce1 100644 --- a/libkvm/libkvm.h +++ b/libkvm/libkvm.h @@ -803,6 +803,28 @@ int kvm_add_irq_route(kvm_context_t kvm, int gsi, int irqchip, int pin); int kvm_del_irq_route(kvm_context_t kvm, int gsi, int irqchip, int pin); /*! + * \brief Adds a routing entry to the temporary irq routing table + * + * Adds a filled routing entry to the temporary irq routing table. Nothing is + * committed to the running VM. + * + * \param kvm Pointer to the current kvm_context + */ +int kvm_add_routing_entry(kvm_context_t kvm, + struct kvm_irq_routing_entry* entry); + +/*! + * \brief Removes a routing from the temporary irq routing table + * + * Remove a routing to the temporary irq routing table. Nothing is + * committed to the running VM. + * + * \param kvm Pointer to the current kvm_context + */ +int kvm_del_routing_entry(kvm_context_t kvm, + struct kvm_irq_routing_entry* entry); + +/*! * \brief Commit the temporary irq routing table * * Commit the temporary irq routing table to the running VM.