diff mbox

[16/21] Remove clean rule change

Message ID 1241040038-17183-17-git-send-email-aliguori@us.ibm.com (mailing list archive)
State New, archived
Headers show

Commit Message

Anthony Liguori April 29, 2009, 9:20 p.m. UTC
It's not in upstream QEMU so apparently it's not useful.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
 pc-bios/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Avi Kivity April 30, 2009, 9:42 a.m. UTC | #1
Anthony Liguori wrote:
> It's not in upstream QEMU so apparently it's not useful.
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
>  pc-bios/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/pc-bios/Makefile b/pc-bios/Makefile
> index dabeb4c..315288d 100644
> --- a/pc-bios/Makefile
> +++ b/pc-bios/Makefile
> @@ -16,4 +16,4 @@ all: $(TARGETS)
>  	dtc -I dts -O dtb -o $@ $<
>  
>  clean:
> -	rm -f $(TARGETS) *.o *~ *.dtb
> +	rm -f $(TARGETS) *.o *~
>   

Hollis?
Hollis Blanchard April 30, 2009, 3:10 p.m. UTC | #2
On Thu, 2009-04-30 at 12:42 +0300, Avi Kivity wrote:
> Anthony Liguori wrote:
> > It's not in upstream QEMU so apparently it's not useful.
> >
> > Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> > ---
> >  pc-bios/Makefile |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/pc-bios/Makefile b/pc-bios/Makefile
> > index dabeb4c..315288d 100644
> > --- a/pc-bios/Makefile
> > +++ b/pc-bios/Makefile
> > @@ -16,4 +16,4 @@ all: $(TARGETS)
> >  	dtc -I dts -O dtb -o $@ $<
> >  
> >  clean:
> > -	rm -f $(TARGETS) *.o *~ *.dtb
> > +	rm -f $(TARGETS) *.o *~
> >   
> 
> Hollis?

dtb is the compiled (binary) form of dts (source) device tree files.

Think of it like bios.bin: if make clean doesn't delete bios.bin (and it
looks like it doesn't), neither should it delete *.dtb, and we can drop
the patch.

Acked-by: Hollis Blanchard <hollisb@us.ibm.com>
Avi Kivity April 30, 2009, 3:13 p.m. UTC | #3
Hollis Blanchard wrote:
> dtb is the compiled (binary) form of dts (source) device tree files.
>
> Think of it like bios.bin: if make clean doesn't delete bios.bin (and it
> looks like it doesn't), neither should it delete *.dtb, and we can drop
> the patch.
>
> Acked-by: Hollis Blanchard <hollisb@us.ibm.com>
>   

make clean doesn't delete bios.bin, because bios.bin is under source 
control (as it requires special tools to build).

I see that *.dtb is also under source control, so will apply the patch.
diff mbox

Patch

diff --git a/pc-bios/Makefile b/pc-bios/Makefile
index dabeb4c..315288d 100644
--- a/pc-bios/Makefile
+++ b/pc-bios/Makefile
@@ -16,4 +16,4 @@  all: $(TARGETS)
 	dtc -I dts -O dtb -o $@ $<
 
 clean:
-	rm -f $(TARGETS) *.o *~ *.dtb
+	rm -f $(TARGETS) *.o *~