From patchwork Tue May 26 21:32:58 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Glauber Costa X-Patchwork-Id: 26103 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n4QLXr2a027508 for ; Tue, 26 May 2009 21:33:53 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756236AbZEZVdE (ORCPT ); Tue, 26 May 2009 17:33:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756245AbZEZVdD (ORCPT ); Tue, 26 May 2009 17:33:03 -0400 Received: from mx2.redhat.com ([66.187.237.31]:49576 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754998AbZEZVdB (ORCPT ); Tue, 26 May 2009 17:33:01 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4QLX3Rw005901 for ; Tue, 26 May 2009 17:33:03 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n4QLX2OS019375; Tue, 26 May 2009 17:33:02 -0400 Received: from localhost.localdomain (virtlab1.virt.bos.redhat.com [10.16.72.21]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n4QLX1QJ013830; Tue, 26 May 2009 17:33:01 -0400 From: Glauber Costa To: kvm@vger.kernel.org Cc: avi@redhat.com Subject: [PATCH 1/4] remove duplicated code. Date: Tue, 26 May 2009 17:32:58 -0400 Message-Id: <1243373581-18085-2-git-send-email-glommer@redhat.com> In-Reply-To: <1243373581-18085-1-git-send-email-glommer@redhat.com> References: <1243373581-18085-1-git-send-email-glommer@redhat.com> X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org This is a leftover from old days. There is already a call from this function in kvm_main_loop_cpu(), which is called unconditionally on the end of ap_main_loop. No need to duplicate. Signed-off-by: Glauber Costa --- qemu-kvm.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemu-kvm.c b/qemu-kvm.c index fd957d9..d16917f 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -433,7 +433,6 @@ static void *ap_main_loop(void *_env) sigfillset(&signals); sigprocmask(SIG_BLOCK, &signals, NULL); kvm_create_vcpu(kvm_context, env->cpu_index); - kvm_qemu_init_env(env); #ifdef USE_KVM_DEVICE_ASSIGNMENT /* do ioperm for io ports of assigned devices */