diff mbox

[1/3] KVM: MMU: Fix is_dirty_pte()

Message ID 1244633302-27545-2-git-send-email-avi@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Avi Kivity June 10, 2009, 11:28 a.m. UTC
is_dirty_pte() is used on guest ptes, not shadow ptes, so it needs to avoid
shadow_dirty_mask and use PT_DIRTY_MASK instead.

Misdetecting dirty pages could lead to unnecessarily setting the dirty bit
under EPT.

Signed-off-by: Avi Kivity <avi@redhat.com>
 arch/x86/kvm/mmu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff mbox


diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 809cce0..8e5003c 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -242,7 +242,7 @@  static int is_writeble_pte(unsigned long pte)
 static int is_dirty_pte(unsigned long pte)
-	return pte & shadow_dirty_mask;
+	return pte & PT_DIRTY_MASK;
 static int is_rmap_pte(u64 pte)