From patchwork Wed Jun 24 23:14:33 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dustin Kirkland X-Patchwork-Id: 32279 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n5ONEfr9013547 for ; Wed, 24 Jun 2009 23:14:41 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752411AbZFXXOe (ORCPT ); Wed, 24 Jun 2009 19:14:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752476AbZFXXOe (ORCPT ); Wed, 24 Jun 2009 19:14:34 -0400 Received: from adelie.canonical.com ([91.189.90.139]:34522 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283AbZFXXOe (ORCPT ); Wed, 24 Jun 2009 19:14:34 -0400 Received: from hutte.canonical.com ([91.189.90.181]) by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian)) id 1MJbfo-0008DL-DY; Thu, 25 Jun 2009 00:14:36 +0100 Received: from cpe-66-69-254-183.austin.res.rr.com ([66.69.254.183] helo=[192.168.1.114]) by hutte.canonical.com with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1MJbfo-0005c8-2A; Thu, 25 Jun 2009 00:14:36 +0100 Subject: Re: [PATCH] Only compile KVM support for matching CPU types From: Dustin Kirkland Reply-To: kirkland@canonical.com To: Anthony Liguori Cc: kvm@vger.kernel.org, Avi Kivity , Hollis Blanchard In-Reply-To: <1245884974.4479.1.camel@t61p> References: <1245883217-27455-1-git-send-email-aliguori@us.ibm.com> <1245884974.4479.1.camel@t61p> Date: Wed, 24 Jun 2009 18:14:33 -0500 Message-Id: <1245885273.4479.5.camel@t61p> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 2009-06-24 at 18:09 -0500, Dustin Kirkland wrote: > On Wed, 2009-06-24 at 17:40 -0500, Anthony Liguori wrote: > > # Make sure the target and host cpus are compatible > > if test ! \( "$target_cpu" = "$cpu" -o \ > > \( "$target_cpu" = "ppcemb" -a "$cpu" = "ppc" \) -o \ > > \( "$target_cpu" = "x86_64" -a "$cpu" = "i386" \) -o \ > > \( "$target_cpu" = "i386" -a "$cpu" = "x86_64" \) \) ; then > > + \( "$target_cpu" = "ia64" -a "$cpu" = "ia64" \) \) ; then > > Almost... > > - \( "$target_cpu" = "i386" -a "$cpu" = "x86_64" \) \) ; then > + \( "$target_cpu" = "i386" -a "$cpu" = "x86_64" \) \) -o \ > + \( "$target_cpu" = "ia64" -a "$cpu" = "ia64" \) \) ; then Doh. Still not quite right... Clean patch below. Signed-off-by: Dustin Kirkland === modified file 'configure' --- configure 2009-06-17 11:16:33 +0000 +++ configure 2009-06-24 23:13:00 +0000 @@ -2117,13 +2117,12 @@ fi } -if [ use_upstream_kvm = yes ]; then - # Make sure the target and host cpus are compatible if test ! \( "$target_cpu" = "$cpu" -o \ \( "$target_cpu" = "ppcemb" -a "$cpu" = "ppc" \) -o \ \( "$target_cpu" = "x86_64" -a "$cpu" = "i386" \) -o \ - \( "$target_cpu" = "i386" -a "$cpu" = "x86_64" \) \) ; then + \( "$target_cpu" = "i386" -a "$cpu" = "x86_64" \) -o \ + \( "$target_cpu" = "ia64" -a "$cpu" = "ia64" \) \) ; then target_kvm="no" fi # Disable KVM for linux-user @@ -2131,8 +2130,6 @@ target_kvm="no" fi -fi - case "$target_cpu" in i386) echo "TARGET_ARCH=i386" >> $config_mak