diff mbox

KVM test: Fix KVM release tag detection

Message ID 1249912254-16606-1-git-send-email-lmr@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Lucas Meneghel Rodrigues Aug. 10, 2009, 1:50 p.m. UTC 
As sourceforge keeps changing the way it organizes its
download pages, a slightly better way to sort out the
latest KVM release tag was devised: Look in all regexp
matches of what looks like a release tag, and return the
largest integer, which will be therefore the latest
release tag. This way we don't have to rely on how
sourceforge organizes their display of downloads.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
---
 client/tests/kvm/kvm_utils.py |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
diff mbox

Patch

diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py
index 4edf371..5b47e02 100644
--- a/client/tests/kvm/kvm_utils.py
+++ b/client/tests/kvm/kvm_utils.py
@@ -142,8 +142,10 @@  def get_latest_kvm_release_tag(release_dir):
         f.close()
         rx = re.compile("kvm-(\d+).tar.gz", re.IGNORECASE)
         matches = rx.findall(data)
-        package_id = matches[0]
-        return matches[0] # the first match contains the latest release tag
+        # In all regexp matches to something that looks like a release tag,
+        # get the largest integer. That will be our latest release tag.
+        latest_tag = max(int(x) for x in matches)
+        return str(latest_tag)
     except Exception, e:
         message = "Could not fetch latest KVM release tag: %s" % str(e)
         logging.error(message)