From patchwork Wed Oct 14 16:29:12 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Glauber Costa X-Patchwork-Id: 53747 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n9EGaSer012620 for ; Wed, 14 Oct 2009 16:36:29 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932262AbZJNQ3s (ORCPT ); Wed, 14 Oct 2009 12:29:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761994AbZJNQ3r (ORCPT ); Wed, 14 Oct 2009 12:29:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12906 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761951AbZJNQ3q (ORCPT ); Wed, 14 Oct 2009 12:29:46 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9EGTK4L000427 for ; Wed, 14 Oct 2009 12:29:20 -0400 Received: from localhost.localdomain (vpn-12-132.rdu.redhat.com [10.11.12.132]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n9EGTEvA011561; Wed, 14 Oct 2009 12:29:19 -0400 From: Glauber Costa To: kvm@vger.kernel.org Cc: avi@redhat.com Subject: [PATCH 2/3] get rid of vcpu structure Date: Wed, 14 Oct 2009 13:29:12 -0300 Message-Id: <1255537753-18694-3-git-send-email-glommer@redhat.com> In-Reply-To: <1255537753-18694-2-git-send-email-glommer@redhat.com> References: <1255537753-18694-1-git-send-email-glommer@redhat.com> <1255537753-18694-2-git-send-email-glommer@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org diff --git a/qemu-kvm.c b/qemu-kvm.c index 700d030..7943281 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -440,16 +440,13 @@ static void kvm_create_vcpu(CPUState *env, int id) { long mmap_size; int r; - kvm_vcpu_context_t vcpu_ctx = qemu_malloc(sizeof(struct kvm_vcpu_context)); r = kvm_vm_ioctl(kvm_state, KVM_CREATE_VCPU, id); if (r < 0) { fprintf(stderr, "kvm_create_vcpu: %m\n"); - goto err; + return; } - vcpu_ctx->fd = r; - env->kvm_fd = r; env->kvm_state = kvm_state; @@ -459,7 +456,7 @@ static void kvm_create_vcpu(CPUState *env, int id) goto err_fd; } env->kvm_run = - mmap(NULL, mmap_size, PROT_READ | PROT_WRITE, MAP_SHARED, vcpu_ctx->fd, + mmap(NULL, mmap_size, PROT_READ | PROT_WRITE, MAP_SHARED, env->kvm_fd, 0); if (env->kvm_run == MAP_FAILED) { fprintf(stderr, "mmap vcpu area: %m\n"); @@ -468,9 +465,7 @@ static void kvm_create_vcpu(CPUState *env, int id) return; err_fd: - close(vcpu_ctx->fd); - err: - free(vcpu_ctx); + close(env->kvm_fd); } static int kvm_set_boot_vcpu_id(kvm_context_t kvm, uint32_t id) diff --git a/qemu-kvm.h b/qemu-kvm.h index abcb98d..588bc80 100644 --- a/qemu-kvm.h +++ b/qemu-kvm.h @@ -76,12 +76,7 @@ struct kvm_context { int max_gsi; }; -struct kvm_vcpu_context { - int fd; -}; - typedef struct kvm_context *kvm_context_t; -typedef struct kvm_vcpu_context *kvm_vcpu_context_t; #include "kvm.h" int kvm_alloc_kernel_memory(kvm_context_t kvm, unsigned long memory,